You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "kyooosukedn (via GitHub)" <gi...@apache.org> on 2023/04/20 14:52:52 UTC
[GitHub] [eventmesh] kyooosukedn opened a new pull request, #3788: [ISSUE #3463] Do some code optimization[EventmeshRebalanceImpl]
kyooosukedn opened a new pull request, #3788:
URL: https://github.com/apache/eventmesh/pull/3788
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #3463 .
### Motivation
*Code optimization on EventmeshRebalanceImpl*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
*Replace null with Collections.emptyMap()*
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3788: [ISSUE #3463] Do some code optimization[EventmeshRebalanceImpl]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3788:
URL: https://github.com/apache/eventmesh/pull/3788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3788: [ISSUE #3463] Do some code optimization[EventmeshRebalanceImpl]
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #3788:
URL: https://github.com/apache/eventmesh/pull/3788#discussion_r1173242988
##########
eventmesh-trace-plugin/eventmesh-trace-zipkin/src/main/java/org/apache/eventmesh/trace/zipkin/ZipkinTraceService.java:
##########
@@ -144,12 +144,7 @@ public String get(Map<String, Object> carrier, String key) {
@Override
public void inject(Context context, Map<String, Object> map) {
- textMapPropagator.inject(context, map, new TextMapSetter<Map<String, Object>>() {
- @Override
- public void set(@Nullable Map<String, Object> carrier, String key, String value) {
- map.put(key, value);
- }
- });
+ textMapPropagator.inject(context, map, (carrier, key, value) -> map.put(key, value));
Review Comment:
Repeat fix here: pr #3786.
One issue corresponds to one pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3788: [ISSUE #3463] Do some code optimization[EventmeshRebalanceImpl]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3788:
URL: https://github.com/apache/eventmesh/pull/3788#issuecomment-1535609533
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3788?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3788](https://app.codecov.io/gh/apache/eventmesh/pull/3788?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ef49c2) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/9ad980f3921dd5aadb2de7b4b20a48b400f7fa30?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ad980f) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 3ef49c2 differs from pull request most recent head 69f0298. Consider uploading reports for the commit 69f0298 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3788 +/- ##
============================================
- Coverage 13.82% 13.80% -0.02%
+ Complexity 1292 1291 -1
============================================
Files 571 571
Lines 29089 29082 -7
Branches 2841 2829 -12
============================================
- Hits 4021 4015 -6
+ Misses 24696 24695 -1
Partials 372 372
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3788?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...l/tcp/client/rebalance/EventmeshRebalanceImpl.java](https://app.codecov.io/gh/apache/eventmesh/pull/3788?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9yZWJhbGFuY2UvRXZlbnRtZXNoUmViYWxhbmNlSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...che/eventmesh/trace/zipkin/ZipkinTraceService.java](https://app.codecov.io/gh/apache/eventmesh/pull/3788?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2Utemlwa2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvdHJhY2Uvemlwa2luL1ppcGtpblRyYWNlU2VydmljZS5qYXZh) | `56.57% <0.00%> (ø)` | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3788/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org