You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org> on 2018/06/13 20:41:08 UTC
[Impala-ASF-CR] IMPALA-4908: NULL floats don't compare equal to other NULL floats
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10707
Change subject: IMPALA-4908: NULL floats don't compare equal to other NULL floats
......................................................................
IMPALA-4908: NULL floats don't compare equal to other NULL floats
This change ensures that comparing two NULL floats with different
val fields returns true. Although this is undefined behavior, it
is now consistent with other types.
Along with the change, a unit test was added to ensure that
equality checking of floats returns results as expected.
Change-Id: Ie7310645e5752d8203be5abc22a6562a59b6e975
---
M be/src/udf/udf-test.cc
M be/src/udf/udf.h
2 files changed, 28 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/10707/1
--
To view, visit http://gerrit.cloudera.org:8080/10707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7310645e5752d8203be5abc22a6562a59b6e975
Gerrit-Change-Number: 10707
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
[Impala-ASF-CR] IMPALA-4908: NULL floats don't compare equal to other NULL floats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10707 )
Change subject: IMPALA-4908: NULL floats don't compare equal to other NULL floats
......................................................................
IMPALA-4908: NULL floats don't compare equal to other NULL floats
This change ensures that comparing two NULL floats with different
val fields returns true. Although this is undefined behavior, it
is now consistent with other types.
Along with the change, a unit test was added to ensure that
equality checking of floats returns results as expected.
Change-Id: Ie7310645e5752d8203be5abc22a6562a59b6e975
Reviewed-on: http://gerrit.cloudera.org:8080/10707
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/udf/udf-test.cc
M be/src/udf/udf.h
2 files changed, 28 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7310645e5752d8203be5abc22a6562a59b6e975
Gerrit-Change-Number: 10707
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4908: NULL floats don't compare equal to other NULL floats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10707 )
Change subject: IMPALA-4908: NULL floats don't compare equal to other NULL floats
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7310645e5752d8203be5abc22a6562a59b6e975
Gerrit-Change-Number: 10707
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jun 2018 21:05:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4908: NULL floats don't compare equal to other NULL floats
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10707 )
Change subject: IMPALA-4908: NULL floats don't compare equal to other NULL floats
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7310645e5752d8203be5abc22a6562a59b6e975
Gerrit-Change-Number: 10707
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jun 2018 21:05:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4908: NULL floats don't compare equal to other NULL floats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10707 )
Change subject: IMPALA-4908: NULL floats don't compare equal to other NULL floats
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2658/
--
To view, visit http://gerrit.cloudera.org:8080/10707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7310645e5752d8203be5abc22a6562a59b6e975
Gerrit-Change-Number: 10707
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jun 2018 21:05:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4908: NULL floats don't compare equal to other NULL floats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10707 )
Change subject: IMPALA-4908: NULL floats don't compare equal to other NULL floats
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7310645e5752d8203be5abc22a6562a59b6e975
Gerrit-Change-Number: 10707
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 00:33:54 +0000
Gerrit-HasComments: No