You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Robert Scholte <rf...@apache.org> on 2016/04/19 21:27:38 UTC
Re: svn commit: r1739979 - in /maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar: AbstractJarMojo.java JarMojo.java TestJarMojo.java
Hi,
Not sure if this is the right moment, but I'd like to make finalName
readonly for all packaging plugins.
The reason: for some new features I probably need to know the name of the
generated (main) artifact, preferably without having to analyze plugin
configuration. Instead, users should use the project.build.finalName to
set its value.
thanks,
Robert
On Tue, 19 Apr 2016 20:46:12 +0200, <kh...@apache.org> wrote:
> Author: khmarbaise
> Date: Tue Apr 19 18:46:11 2016
> New Revision: 1739979
>
> URL: http://svn.apache.org/viewvc?rev=1739979&view=rev
> Log:
> [MJAR-209] Remove param properties that doesn't make sense for CLI usage
> o Removed the following properties:
> - maven.jar.finalName
> - maven.jar.skipIfEmpty
> - maven.jar.classifier
> - maven.jar.testClassifier
>
> Modified:
> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>
> Modified:
> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
> URL:
> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
> ==============================================================================
> ---
> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
> (original)
> +++
> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
> Tue Apr 19 18:46:11 2016
> @@ -72,7 +72,7 @@ public abstract class AbstractJarMojo
> * Starting with <b>3.0.0</b> the property has been renamed from
> <code>jar.finalName</code> to
> * <code>maven.jar.finalName</code>.
> */
> - @Parameter( property = "maven.jar.finalName", defaultValue =
> "${project.build.finalName}" )
> + @Parameter( defaultValue = "${project.build.finalName}" )
> private String finalName;
> /**
> @@ -135,7 +135,7 @@ public abstract class AbstractJarMojo
> * Starting with <b>3.0.0</b> the property has been renamed from
> <code>jar.skipIfEmpty</code> to
> * <code>maven.jar.skipIfEmpty</code>.
> */
> - @Parameter( property = "maven.jar.skipIfEmpty", defaultValue =
> "false" )
> + @Parameter( defaultValue = "false" )
> private boolean skipIfEmpty;
> /**
>
> Modified:
> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
> URL:
> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
> ==============================================================================
> ---
> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
> (original)
> +++
> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
> Tue Apr 19 18:46:11 2016
> @@ -49,7 +49,7 @@ public class JarMojo
> * If not given this will create the main artifact which is the
> default behavior.
> * If you try to do that a second time without using a classifier
> the build will fail.
> */
> - @Parameter( property = "maven.jar.classifier" )
> + @Parameter
> private String classifier;
> protected String getClassifier()
>
> Modified:
> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
> URL:
> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
> ==============================================================================
> ---
> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
> (original)
> +++
> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
> Tue Apr 19 18:46:11 2016
> @@ -55,7 +55,7 @@ public class TestJarMojo
> /**
> * Classifier to used for {@code test-jar}.
> */
> - @Parameter( property = "maven.jar.testClassifier", defaultValue =
> "tests" )
> + @Parameter( defaultValue = "tests" )
> private String classifier;
> protected String getClassifier()
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1739979 - in /maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar:
AbstractJarMojo.java JarMojo.java TestJarMojo.java
Posted by Anders Hammar <an...@hammar.net>.
On Tue, Apr 19, 2016 at 9:27 PM, Robert Scholte <rf...@apache.org>
wrote:
> Hi,
>
> Not sure if this is the right moment, but I'd like to make finalName
> readonly for all packaging plugins.
> The reason: for some new features I probably need to know the name of the
> generated (main) artifact, preferably without having to analyze plugin
> configuration. Instead, users should use the project.build.finalName to set
> its value.
>
v3.0.0 is a very good moment to do this. Please create a ticket and
schedule it for v3.0.0!
/Anders
>
> thanks,
> Robert
>
>
> On Tue, 19 Apr 2016 20:46:12 +0200, <kh...@apache.org> wrote:
>
> Author: khmarbaise
>> Date: Tue Apr 19 18:46:11 2016
>> New Revision: 1739979
>>
>> URL: http://svn.apache.org/viewvc?rev=1739979&view=rev
>> Log:
>> [MJAR-209] Remove param properties that doesn't make sense for CLI usage
>> o Removed the following properties:
>> - maven.jar.finalName
>> - maven.jar.skipIfEmpty
>> - maven.jar.classifier
>> - maven.jar.testClassifier
>>
>> Modified:
>>
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>
>> Modified:
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>> URL:
>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>
>> ==============================================================================
>> ---
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>> (original)
>> +++
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>> Tue Apr 19 18:46:11 2016
>> @@ -72,7 +72,7 @@ public abstract class AbstractJarMojo
>> * Starting with <b>3.0.0</b> the property has been renamed from
>> <code>jar.finalName</code> to
>> * <code>maven.jar.finalName</code>.
>> */
>> - @Parameter( property = "maven.jar.finalName", defaultValue =
>> "${project.build.finalName}" )
>> + @Parameter( defaultValue = "${project.build.finalName}" )
>> private String finalName;
>> /**
>> @@ -135,7 +135,7 @@ public abstract class AbstractJarMojo
>> * Starting with <b>3.0.0</b> the property has been renamed from
>> <code>jar.skipIfEmpty</code> to
>> * <code>maven.jar.skipIfEmpty</code>.
>> */
>> - @Parameter( property = "maven.jar.skipIfEmpty", defaultValue =
>> "false" )
>> + @Parameter( defaultValue = "false" )
>> private boolean skipIfEmpty;
>> /**
>>
>> Modified:
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>> URL:
>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>
>> ==============================================================================
>> ---
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>> (original)
>> +++
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>> Tue Apr 19 18:46:11 2016
>> @@ -49,7 +49,7 @@ public class JarMojo
>> * If not given this will create the main artifact which is the
>> default behavior.
>> * If you try to do that a second time without using a classifier
>> the build will fail.
>> */
>> - @Parameter( property = "maven.jar.classifier" )
>> + @Parameter
>> private String classifier;
>> protected String getClassifier()
>>
>> Modified:
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>> URL:
>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>
>> ==============================================================================
>> ---
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>> (original)
>> +++
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>> Tue Apr 19 18:46:11 2016
>> @@ -55,7 +55,7 @@ public class TestJarMojo
>> /**
>> * Classifier to used for {@code test-jar}.
>> */
>> - @Parameter( property = "maven.jar.testClassifier", defaultValue =
>> "tests" )
>> + @Parameter( defaultValue = "tests" )
>> private String classifier;
>> protected String getClassifier()
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: svn commit: r1739979 - in /maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar: AbstractJarMojo.java JarMojo.java TestJarMojo.java
Posted by Robert Scholte <rf...@apache.org>.
On Tue, 19 Apr 2016 21:40:04 +0200, Karl Heinz Marbaise
<kh...@gmx.de> wrote:
> Hi Robert,
>
> On 4/19/16 9:27 PM, Robert Scholte wrote:
>> Hi,
>>
>> Not sure if this is the right moment,
>
> why not? 3.0.0 is a good moment or may be exactly the right time for
> such change....
>
> > but I'd like to make finalName
>> readonly for all packaging plugins.
>
> Ok...have created an appropriate issue for...MJAR-217
>
>
>> The reason: for some new features I probably need to know the name of
>> the generated (main) artifact, preferably without having to analyze
>> plugin configuration. Instead, users should use the
>> project.build.finalName to set its value.
>
> Can you give more details about those features ?
>
To keep it short: MavenProject.getClasspathElements() should be considered
a hack. Classpath is Java specific and a MavenProject should not be aware
of language specific features. With the first releases of jigsaw with its
modules it seemed like we had a serious issue here. This made me aware
that it would be much better if the name of the generated artifact was
always ${project.build.finalName}.
Same counts for example for the outputDirectories or the compiler plugin.
This way other plugins can simply build the classpath and or modulepath or
whatever purely based on the pom, not on how plugins manipulate the
MavenProject.
Hopefully this explains it a bit.
Robert
>
>>
>> thanks,
>> Robert
>>
>>
>> On Tue, 19 Apr 2016 20:46:12 +0200, <kh...@apache.org> wrote:
>>
>>> Author: khmarbaise
>>> Date: Tue Apr 19 18:46:11 2016
>>> New Revision: 1739979
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1739979&view=rev
>>> Log:
>>> [MJAR-209] Remove param properties that doesn't make sense for CLI
>>> usage
>>> o Removed the following properties:
>>> - maven.jar.finalName
>>> - maven.jar.skipIfEmpty
>>> - maven.jar.classifier
>>> - maven.jar.testClassifier
>>>
>>> Modified:
>>>
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>
>>>
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>
>>>
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>
>>>
>>> Modified:
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>
>>> URL:
>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>
>>> ==============================================================================
>>>
>>> ---
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>> (original)
>>> +++
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>> Tue Apr 19 18:46:11 2016
>>> @@ -72,7 +72,7 @@ public abstract class AbstractJarMojo
>>> * Starting with <b>3.0.0</b> the property has been renamed from
>>> <code>jar.finalName</code> to
>>> * <code>maven.jar.finalName</code>.
>>> */
>>> - @Parameter( property = "maven.jar.finalName", defaultValue =
>>> "${project.build.finalName}" )
>>> + @Parameter( defaultValue = "${project.build.finalName}" )
>>> private String finalName;
>>> /**
>>> @@ -135,7 +135,7 @@ public abstract class AbstractJarMojo
>>> * Starting with <b>3.0.0</b> the property has been renamed from
>>> <code>jar.skipIfEmpty</code> to
>>> * <code>maven.jar.skipIfEmpty</code>.
>>> */
>>> - @Parameter( property = "maven.jar.skipIfEmpty", defaultValue =
>>> "false" )
>>> + @Parameter( defaultValue = "false" )
>>> private boolean skipIfEmpty;
>>> /**
>>>
>>> Modified:
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>
>>> URL:
>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>
>>> ==============================================================================
>>>
>>> ---
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>> (original)
>>> +++
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>> Tue Apr 19 18:46:11 2016
>>> @@ -49,7 +49,7 @@ public class JarMojo
>>> * If not given this will create the main artifact which is the
>>> default behavior.
>>> * If you try to do that a second time without using a classifier
>>> the build will fail.
>>> */
>>> - @Parameter( property = "maven.jar.classifier" )
>>> + @Parameter
>>> private String classifier;
>>> protected String getClassifier()
>>>
>>> Modified:
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>
>>> URL:
>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>
>>> ==============================================================================
>>>
>>> ---
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>> (original)
>>> +++
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>> Tue Apr 19 18:46:11 2016
>>> @@ -55,7 +55,7 @@ public class TestJarMojo
>>> /**
>>> * Classifier to used for {@code test-jar}.
>>> */
>>> - @Parameter( property = "maven.jar.testClassifier", defaultValue =
>>> "tests" )
>>> + @Parameter( defaultValue = "tests" )
>>> private String classifier;
>>> protected String getClassifier()
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1739979 - in
/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar:
AbstractJarMojo.java JarMojo.java TestJarMojo.java
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi Robert,
On 4/19/16 9:27 PM, Robert Scholte wrote:
> Hi,
>
> Not sure if this is the right moment,
why not? 3.0.0 is a good moment or may be exactly the right time for
such change....
> but I'd like to make finalName
> readonly for all packaging plugins.
Ok...have created an appropriate issue for...MJAR-217
> The reason: for some new features I probably need to know the name of
> the generated (main) artifact, preferably without having to analyze
> plugin configuration. Instead, users should use the
> project.build.finalName to set its value.
Can you give more details about those features ?
>
> thanks,
> Robert
>
>
> On Tue, 19 Apr 2016 20:46:12 +0200, <kh...@apache.org> wrote:
>
>> Author: khmarbaise
>> Date: Tue Apr 19 18:46:11 2016
>> New Revision: 1739979
>>
>> URL: http://svn.apache.org/viewvc?rev=1739979&view=rev
>> Log:
>> [MJAR-209] Remove param properties that doesn't make sense for CLI usage
>> o Removed the following properties:
>> - maven.jar.finalName
>> - maven.jar.skipIfEmpty
>> - maven.jar.classifier
>> - maven.jar.testClassifier
>>
>> Modified:
>>
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>
>>
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>
>>
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>
>>
>> Modified:
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>
>> URL:
>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>
>> ==============================================================================
>>
>> ---
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>> (original)
>> +++
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>> Tue Apr 19 18:46:11 2016
>> @@ -72,7 +72,7 @@ public abstract class AbstractJarMojo
>> * Starting with <b>3.0.0</b> the property has been renamed from
>> <code>jar.finalName</code> to
>> * <code>maven.jar.finalName</code>.
>> */
>> - @Parameter( property = "maven.jar.finalName", defaultValue =
>> "${project.build.finalName}" )
>> + @Parameter( defaultValue = "${project.build.finalName}" )
>> private String finalName;
>> /**
>> @@ -135,7 +135,7 @@ public abstract class AbstractJarMojo
>> * Starting with <b>3.0.0</b> the property has been renamed from
>> <code>jar.skipIfEmpty</code> to
>> * <code>maven.jar.skipIfEmpty</code>.
>> */
>> - @Parameter( property = "maven.jar.skipIfEmpty", defaultValue =
>> "false" )
>> + @Parameter( defaultValue = "false" )
>> private boolean skipIfEmpty;
>> /**
>>
>> Modified:
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>
>> URL:
>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>
>> ==============================================================================
>>
>> ---
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>> (original)
>> +++
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>> Tue Apr 19 18:46:11 2016
>> @@ -49,7 +49,7 @@ public class JarMojo
>> * If not given this will create the main artifact which is the
>> default behavior.
>> * If you try to do that a second time without using a classifier
>> the build will fail.
>> */
>> - @Parameter( property = "maven.jar.classifier" )
>> + @Parameter
>> private String classifier;
>> protected String getClassifier()
>>
>> Modified:
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>
>> URL:
>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>
>> ==============================================================================
>>
>> ---
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>> (original)
>> +++
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>> Tue Apr 19 18:46:11 2016
>> @@ -55,7 +55,7 @@ public class TestJarMojo
>> /**
>> * Classifier to used for {@code test-jar}.
>> */
>> - @Parameter( property = "maven.jar.testClassifier", defaultValue =
>> "tests" )
>> + @Parameter( defaultValue = "tests" )
>> private String classifier;
>> protected String getClassifier()
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1739979 - in /maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar:
AbstractJarMojo.java JarMojo.java TestJarMojo.java
Posted by Anders Hammar <an...@hammar.net>.
+1
v3.0.0 is an excellent opportunity to do this I think!
/Anders
On Wed, Apr 20, 2016 at 9:48 AM, Robert Scholte <rf...@apache.org>
wrote:
> https://issues.apache.org/jira/browse/MJAR-183 should also be good to do
> now.
> that is: *copy* the lifecycle from core to the plugin.
> IIRC it was Igor who told me this was safe to do, Maven has a clear
> strategy how to resolve lifecycle handlers, having definitions in both
> Maven and the plugin shouldn't be an issue.
>
> I don't have time to test this within the next couple of days, unless we
> take some extra time to go through such issues (since this is the 3.0.0
> version)
>
> Robert
>
> On Tue, 19 Apr 2016 21:27:38 +0200, Robert Scholte <rf...@apache.org>
> wrote:
>
> Hi,
>>
>> Not sure if this is the right moment, but I'd like to make finalName
>> readonly for all packaging plugins.
>> The reason: for some new features I probably need to know the name of the
>> generated (main) artifact, preferably without having to analyze plugin
>> configuration. Instead, users should use the project.build.finalName to set
>> its value.
>>
>> thanks,
>> Robert
>>
>>
>> On Tue, 19 Apr 2016 20:46:12 +0200, <kh...@apache.org> wrote:
>>
>> Author: khmarbaise
>>> Date: Tue Apr 19 18:46:11 2016
>>> New Revision: 1739979
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1739979&view=rev
>>> Log:
>>> [MJAR-209] Remove param properties that doesn't make sense for CLI usage
>>> o Removed the following properties:
>>> - maven.jar.finalName
>>> - maven.jar.skipIfEmpty
>>> - maven.jar.classifier
>>> - maven.jar.testClassifier
>>>
>>> Modified:
>>>
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>
>>> Modified:
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>> URL:
>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>> (original)
>>> +++
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>> Tue Apr 19 18:46:11 2016
>>> @@ -72,7 +72,7 @@ public abstract class AbstractJarMojo
>>> * Starting with <b>3.0.0</b> the property has been renamed from
>>> <code>jar.finalName</code> to
>>> * <code>maven.jar.finalName</code>.
>>> */
>>> - @Parameter( property = "maven.jar.finalName", defaultValue =
>>> "${project.build.finalName}" )
>>> + @Parameter( defaultValue = "${project.build.finalName}" )
>>> private String finalName;
>>> /**
>>> @@ -135,7 +135,7 @@ public abstract class AbstractJarMojo
>>> * Starting with <b>3.0.0</b> the property has been renamed from
>>> <code>jar.skipIfEmpty</code> to
>>> * <code>maven.jar.skipIfEmpty</code>.
>>> */
>>> - @Parameter( property = "maven.jar.skipIfEmpty", defaultValue =
>>> "false" )
>>> + @Parameter( defaultValue = "false" )
>>> private boolean skipIfEmpty;
>>> /**
>>>
>>> Modified:
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>> URL:
>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>> (original)
>>> +++
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>> Tue Apr 19 18:46:11 2016
>>> @@ -49,7 +49,7 @@ public class JarMojo
>>> * If not given this will create the main artifact which is the
>>> default behavior.
>>> * If you try to do that a second time without using a classifier
>>> the build will fail.
>>> */
>>> - @Parameter( property = "maven.jar.classifier" )
>>> + @Parameter
>>> private String classifier;
>>> protected String getClassifier()
>>>
>>> Modified:
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>> URL:
>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>> (original)
>>> +++
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>> Tue Apr 19 18:46:11 2016
>>> @@ -55,7 +55,7 @@ public class TestJarMojo
>>> /**
>>> * Classifier to used for {@code test-jar}.
>>> */
>>> - @Parameter( property = "maven.jar.testClassifier", defaultValue =
>>> "tests" )
>>> + @Parameter( defaultValue = "tests" )
>>> private String classifier;
>>> protected String getClassifier()
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: svn commit: r1739979 - in /maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar: AbstractJarMojo.java JarMojo.java TestJarMojo.java
Posted by Robert Scholte <rf...@apache.org>.
Yes, yes and yes :)
On Fri, 22 Apr 2016 19:11:37 +0200, Karl Heinz Marbaise
<kh...@gmx.de> wrote:
> Hi Robert,
> On 4/20/16 11:51 PM, Robert Scholte wrote:
>> Hi Karl-Heinz,
>>
>> the current situation is that if you haven't defined plugin versions,
>> the version as defined in Maven will be used. So if I use a different
>> version of Maven, other versions of the plugins might kick in with a
>> different result.
>
> Which brought use to best practice to always define plugin
> versions...(via pluginManagement etc. parent pom etc.)..
>
>
>> By moving it to the "packaging" plugin, at least the same versions of
>> plugins will be used, no matter the version of Maven.
>> This way there's no such thing as "custom" packaging plugin anymore,
>> they are all treated the same.
>>
>> So if the packaging type is jar, the maven-jar-plugin will decide which
>> versions of resources-, compiler- and other plugins will be used. These
>> will be the defaults, it is still better to define the versions of these
>> plugins within every pom.
>
> So in other words we "only" move the definition of the bindings into the
> plugin instead of having them in Maven core...
>
>>
>>
>> bq. > maven-install-plugin will define install phase for jar life cycle
>>> maven-jar-plugin will define the package phase for jar life cycle ..
>>
>> Only the latter. The maven-jar-plugin defines the lifecycle and which
>> plugins arebound to the phases.
>> Otherwise there are multiple definitions of the build-lifecycle.
>>
>> Hervé also said something interesting: by moving lifecycles to the
>> corresponding plugin, the plugin should be specified with version +
>> extension=true (as required for custom lifecycles). Maven doesn't isn't
>> aware of the lifecycles anymore, which is not developer-friendly. So we
>> still need a mapping from packaging to plugin, and it must be
>> extendable.
>>
>> Anyhow, we need to copy these things first to the packaging-plugins.
>> Once these plugins contain the lifecycle mapping we can start adjusting
>> Maven.
>
> So this is a preparation step and just having it in the maven-jar-plugin
> (for example) but all others can use the maven-jar-plugin as before
> without the need to use extensions=true etc.. but we are prepared...
>
> So for convenience it would be nice not the need to define the
> maven-jar-plugin's etc. via extensions..but i think this is a different
> thing to dicuss...
>
>
>
>>
>> thanks,
>> Robert
>>
>> On Wed, 20 Apr 2016 20:11:58 +0200, Karl Heinz Marbaise
>> <kh...@gmx.de> wrote:
>>
>>> Hi Robert,
>>>
>>> On 4/20/16 9:48 AM, Robert Scholte wrote:
>>>> https://issues.apache.org/jira/browse/MJAR-183 should also be good to
>>>> do
>>>> now.
>>>> that is: *copy* the lifecycle from core to the plugin.
>>>> IIRC it was Igor who told me this was safe to do, Maven has a clear
>>>> strategy how to resolve lifecycle handlers, having definitions in both
>>>> Maven and the plugin shouldn't be an issue.
>>>>
>>>> I don't have time to test this within the next couple of days, unless
>>>> we
>>>> take some extra time to go through such issues (since this is the
>>>> 3.0.0
>>>> version)
>>>
>>> If i correctly understand this means:
>>>
>>> <component>
>>> <role>org.apache.maven.artifact.handler.ArtifactHandler</role>
>>> <role-hint>jar</role-hint>
>>> <implementation>org.apache.maven.artifact.handler.DefaultArtifactHandler</implementation>
>>>
>>> <configuration>
>>> <type>jar</type>
>>> <language>java</language>
>>> <addedToClasspath>true</addedToClasspath>
>>> </configuration>
>>> </component>
>>>
>>>
>>> and the following in the artifacts-handler.xml in
>>> src/main/resources/META-INF/plexus/ ....
>>>
>>> <component>
>>> <role>org.apache.maven.lifecycle.mapping.LifecycleMapping</role>
>>> <role-hint>jar</role-hint>
>>> <implementation>org.apache.maven.lifecycle.mapping.DefaultLifecycleMapping</implementation>
>>>
>>> <configuration>
>>> <lifecycles>
>>> <lifecycle>
>>> <id>default</id>
>>> <!-- START SNIPPET: jar-lifecycle -->
>>> <phases>
>>> <package>
>>> org.apache.maven.plugins:maven-jar-plugin:${project.version}:jar
>>> </package>
>>> </phases>
>>> <!-- END SNIPPET: jar-lifecycle -->
>>> </lifecycle>
>>> </lifecycles>
>>> </configuration>
>>> </component>
>>>
>>>
>>> But one point i don't understand is of this....for example
>>> if the whole life cycle should be defined by having several plugins
>>> participate into for example the jar life cycle...but the question is:
>>>
>>> Do i need to define the whole life cycle with all plugins within the
>>> maven-jar-plugin or should the appropriate plugin only define it's
>>> part of the life cycle ?
>>>
>>> Is there a kind of merge for this life cycle mapping if two or more
>>> plugins define parts of the above ...for example:
>>>
>>> maven-install-plugin will define install phase for jar life cycle
>>> maven-jar-plugin will define the package phase for jar life cycle ..>
>>>
>>> Any ideas / Explanations ?
>>>
>>>
>>> Kind regards
>>> Karl Heinz Marbaise
>>>
>>>
>>>
>>>
>>>
>>>>
>>>> Robert
>>>>
>>>> On Tue, 19 Apr 2016 21:27:38 +0200, Robert Scholte
>>>> <rf...@apache.org> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Not sure if this is the right moment, but I'd like to make finalName
>>>>> readonly for all packaging plugins.
>>>>> The reason: for some new features I probably need to know the name of
>>>>> the generated (main) artifact, preferably without having to analyze
>>>>> plugin configuration. Instead, users should use the
>>>>> project.build.finalName to set its value.
>>>>>
>>>>> thanks,
>>>>> Robert
>>>>>
>>>>>
>>>>> On Tue, 19 Apr 2016 20:46:12 +0200, <kh...@apache.org> wrote:
>>>>>
>>>>>> Author: khmarbaise
>>>>>> Date: Tue Apr 19 18:46:11 2016
>>>>>> New Revision: 1739979
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=1739979&view=rev
>>>>>> Log:
>>>>>> [MJAR-209] Remove param properties that doesn't make sense for CLI
>>>>>> usage
>>>>>> o Removed the following properties:
>>>>>> - maven.jar.finalName
>>>>>> - maven.jar.skipIfEmpty
>>>>>> - maven.jar.classifier
>>>>>> - maven.jar.testClassifier
>>>>>>
>>>>>> Modified:
>>>>>>
>>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>>>>
>>>>>>
>>>>>>
>>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>>>>
>>>>>>
>>>>>>
>>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>>>>
>>>>>>
>>>>>>
>>>>>> Modified:
>>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>>>>
>>>>>>
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>>>>
>>>>>>
>>>>>> ==============================================================================
>>>>>>
>>>>>>
>>>>>> ---
>>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>>>>
>>>>>> (original)
>>>>>> +++
>>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>>>>
>>>>>> Tue Apr 19 18:46:11 2016
>>>>>> @@ -72,7 +72,7 @@ public abstract class AbstractJarMojo
>>>>>> * Starting with <b>3.0.0</b> the property has been renamed
>>>>>> from
>>>>>> <code>jar.finalName</code> to
>>>>>> * <code>maven.jar.finalName</code>.
>>>>>> */
>>>>>> - @Parameter( property = "maven.jar.finalName", defaultValue =
>>>>>> "${project.build.finalName}" )
>>>>>> + @Parameter( defaultValue = "${project.build.finalName}" )
>>>>>> private String finalName;
>>>>>> /**
>>>>>> @@ -135,7 +135,7 @@ public abstract class AbstractJarMojo
>>>>>> * Starting with <b>3.0.0</b> the property has been renamed
>>>>>> from
>>>>>> <code>jar.skipIfEmpty</code> to
>>>>>> * <code>maven.jar.skipIfEmpty</code>.
>>>>>> */
>>>>>> - @Parameter( property = "maven.jar.skipIfEmpty", defaultValue =
>>>>>> "false" )
>>>>>> + @Parameter( defaultValue = "false" )
>>>>>> private boolean skipIfEmpty;
>>>>>> /**
>>>>>>
>>>>>> Modified:
>>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>>>>
>>>>>>
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>>>>
>>>>>>
>>>>>> ==============================================================================
>>>>>>
>>>>>>
>>>>>> ---
>>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>>>>
>>>>>> (original)
>>>>>> +++
>>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>>>>
>>>>>> Tue Apr 19 18:46:11 2016
>>>>>> @@ -49,7 +49,7 @@ public class JarMojo
>>>>>> * If not given this will create the main artifact which is the
>>>>>> default behavior.
>>>>>> * If you try to do that a second time without using a
>>>>>> classifier the build will fail.
>>>>>> */
>>>>>> - @Parameter( property = "maven.jar.classifier" )
>>>>>> + @Parameter
>>>>>> private String classifier;
>>>>>> protected String getClassifier()
>>>>>>
>>>>>> Modified:
>>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>>>>
>>>>>>
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>>>>
>>>>>>
>>>>>> ==============================================================================
>>>>>>
>>>>>>
>>>>>> ---
>>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>>>>
>>>>>> (original)
>>>>>> +++
>>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>>>>
>>>>>> Tue Apr 19 18:46:11 2016
>>>>>> @@ -55,7 +55,7 @@ public class TestJarMojo
>>>>>> /**
>>>>>> * Classifier to used for {@code test-jar}.
>>>>>> */
>>>>>> - @Parameter( property = "maven.jar.testClassifier", defaultValue
>>>>>> = "tests" )
>>>>>> + @Parameter( defaultValue = "tests" )
>>>>>> private String classifier;
>>>>>> protected String getClassifier()
>>>>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1739979 - in
/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar:
AbstractJarMojo.java JarMojo.java TestJarMojo.java
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi Robert,
On 4/20/16 11:51 PM, Robert Scholte wrote:
> Hi Karl-Heinz,
>
> the current situation is that if you haven't defined plugin versions,
> the version as defined in Maven will be used. So if I use a different
> version of Maven, other versions of the plugins might kick in with a
> different result.
Which brought use to best practice to always define plugin
versions...(via pluginManagement etc. parent pom etc.)..
> By moving it to the "packaging" plugin, at least the same versions of
> plugins will be used, no matter the version of Maven.
> This way there's no such thing as "custom" packaging plugin anymore,
> they are all treated the same.
>
> So if the packaging type is jar, the maven-jar-plugin will decide which
> versions of resources-, compiler- and other plugins will be used. These
> will be the defaults, it is still better to define the versions of these
> plugins within every pom.
So in other words we "only" move the definition of the bindings into the
plugin instead of having them in Maven core...
>
>
> bq. > maven-install-plugin will define install phase for jar life cycle
>> maven-jar-plugin will define the package phase for jar life cycle ..
>
> Only the latter. The maven-jar-plugin defines the lifecycle and which
> plugins arebound to the phases.
> Otherwise there are multiple definitions of the build-lifecycle.
>
> Hervé also said something interesting: by moving lifecycles to the
> corresponding plugin, the plugin should be specified with version +
> extension=true (as required for custom lifecycles). Maven doesn't isn't
> aware of the lifecycles anymore, which is not developer-friendly. So we
> still need a mapping from packaging to plugin, and it must be extendable.
>
> Anyhow, we need to copy these things first to the packaging-plugins.
> Once these plugins contain the lifecycle mapping we can start adjusting
> Maven.
So this is a preparation step and just having it in the maven-jar-plugin
(for example) but all others can use the maven-jar-plugin as before
without the need to use extensions=true etc.. but we are prepared...
So for convenience it would be nice not the need to define the
maven-jar-plugin's etc. via extensions..but i think this is a different
thing to dicuss...
>
> thanks,
> Robert
>
> On Wed, 20 Apr 2016 20:11:58 +0200, Karl Heinz Marbaise
> <kh...@gmx.de> wrote:
>
>> Hi Robert,
>>
>> On 4/20/16 9:48 AM, Robert Scholte wrote:
>>> https://issues.apache.org/jira/browse/MJAR-183 should also be good to do
>>> now.
>>> that is: *copy* the lifecycle from core to the plugin.
>>> IIRC it was Igor who told me this was safe to do, Maven has a clear
>>> strategy how to resolve lifecycle handlers, having definitions in both
>>> Maven and the plugin shouldn't be an issue.
>>>
>>> I don't have time to test this within the next couple of days, unless we
>>> take some extra time to go through such issues (since this is the 3.0.0
>>> version)
>>
>> If i correctly understand this means:
>>
>> <component>
>> <role>org.apache.maven.artifact.handler.ArtifactHandler</role>
>> <role-hint>jar</role-hint>
>> <implementation>org.apache.maven.artifact.handler.DefaultArtifactHandler</implementation>
>>
>> <configuration>
>> <type>jar</type>
>> <language>java</language>
>> <addedToClasspath>true</addedToClasspath>
>> </configuration>
>> </component>
>>
>>
>> and the following in the artifacts-handler.xml in
>> src/main/resources/META-INF/plexus/ ....
>>
>> <component>
>> <role>org.apache.maven.lifecycle.mapping.LifecycleMapping</role>
>> <role-hint>jar</role-hint>
>> <implementation>org.apache.maven.lifecycle.mapping.DefaultLifecycleMapping</implementation>
>>
>> <configuration>
>> <lifecycles>
>> <lifecycle>
>> <id>default</id>
>> <!-- START SNIPPET: jar-lifecycle -->
>> <phases>
>> <package>
>> org.apache.maven.plugins:maven-jar-plugin:${project.version}:jar
>> </package>
>> </phases>
>> <!-- END SNIPPET: jar-lifecycle -->
>> </lifecycle>
>> </lifecycles>
>> </configuration>
>> </component>
>>
>>
>> But one point i don't understand is of this....for example
>> if the whole life cycle should be defined by having several plugins
>> participate into for example the jar life cycle...but the question is:
>>
>> Do i need to define the whole life cycle with all plugins within the
>> maven-jar-plugin or should the appropriate plugin only define it's
>> part of the life cycle ?
>>
>> Is there a kind of merge for this life cycle mapping if two or more
>> plugins define parts of the above ...for example:
>>
>> maven-install-plugin will define install phase for jar life cycle
>> maven-jar-plugin will define the package phase for jar life cycle ..>
>>
>> Any ideas / Explanations ?
>>
>>
>> Kind regards
>> Karl Heinz Marbaise
>>
>>
>>
>>
>>
>>>
>>> Robert
>>>
>>> On Tue, 19 Apr 2016 21:27:38 +0200, Robert Scholte
>>> <rf...@apache.org> wrote:
>>>
>>>> Hi,
>>>>
>>>> Not sure if this is the right moment, but I'd like to make finalName
>>>> readonly for all packaging plugins.
>>>> The reason: for some new features I probably need to know the name of
>>>> the generated (main) artifact, preferably without having to analyze
>>>> plugin configuration. Instead, users should use the
>>>> project.build.finalName to set its value.
>>>>
>>>> thanks,
>>>> Robert
>>>>
>>>>
>>>> On Tue, 19 Apr 2016 20:46:12 +0200, <kh...@apache.org> wrote:
>>>>
>>>>> Author: khmarbaise
>>>>> Date: Tue Apr 19 18:46:11 2016
>>>>> New Revision: 1739979
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1739979&view=rev
>>>>> Log:
>>>>> [MJAR-209] Remove param properties that doesn't make sense for CLI
>>>>> usage
>>>>> o Removed the following properties:
>>>>> - maven.jar.finalName
>>>>> - maven.jar.skipIfEmpty
>>>>> - maven.jar.classifier
>>>>> - maven.jar.testClassifier
>>>>>
>>>>> Modified:
>>>>>
>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>>>
>>>>>
>>>>>
>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>>>
>>>>>
>>>>>
>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>>>
>>>>>
>>>>>
>>>>> Modified:
>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>>>
>>>>>
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>>>
>>>>>
>>>>> ==============================================================================
>>>>>
>>>>>
>>>>> ---
>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>>>
>>>>> (original)
>>>>> +++
>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>>>
>>>>> Tue Apr 19 18:46:11 2016
>>>>> @@ -72,7 +72,7 @@ public abstract class AbstractJarMojo
>>>>> * Starting with <b>3.0.0</b> the property has been renamed from
>>>>> <code>jar.finalName</code> to
>>>>> * <code>maven.jar.finalName</code>.
>>>>> */
>>>>> - @Parameter( property = "maven.jar.finalName", defaultValue =
>>>>> "${project.build.finalName}" )
>>>>> + @Parameter( defaultValue = "${project.build.finalName}" )
>>>>> private String finalName;
>>>>> /**
>>>>> @@ -135,7 +135,7 @@ public abstract class AbstractJarMojo
>>>>> * Starting with <b>3.0.0</b> the property has been renamed from
>>>>> <code>jar.skipIfEmpty</code> to
>>>>> * <code>maven.jar.skipIfEmpty</code>.
>>>>> */
>>>>> - @Parameter( property = "maven.jar.skipIfEmpty", defaultValue =
>>>>> "false" )
>>>>> + @Parameter( defaultValue = "false" )
>>>>> private boolean skipIfEmpty;
>>>>> /**
>>>>>
>>>>> Modified:
>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>>>
>>>>>
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>>>
>>>>>
>>>>> ==============================================================================
>>>>>
>>>>>
>>>>> ---
>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>>>
>>>>> (original)
>>>>> +++
>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>>>
>>>>> Tue Apr 19 18:46:11 2016
>>>>> @@ -49,7 +49,7 @@ public class JarMojo
>>>>> * If not given this will create the main artifact which is the
>>>>> default behavior.
>>>>> * If you try to do that a second time without using a
>>>>> classifier the build will fail.
>>>>> */
>>>>> - @Parameter( property = "maven.jar.classifier" )
>>>>> + @Parameter
>>>>> private String classifier;
>>>>> protected String getClassifier()
>>>>>
>>>>> Modified:
>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>>>
>>>>>
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>>>
>>>>>
>>>>> ==============================================================================
>>>>>
>>>>>
>>>>> ---
>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>>>
>>>>> (original)
>>>>> +++
>>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>>>
>>>>> Tue Apr 19 18:46:11 2016
>>>>> @@ -55,7 +55,7 @@ public class TestJarMojo
>>>>> /**
>>>>> * Classifier to used for {@code test-jar}.
>>>>> */
>>>>> - @Parameter( property = "maven.jar.testClassifier", defaultValue
>>>>> = "tests" )
>>>>> + @Parameter( defaultValue = "tests" )
>>>>> private String classifier;
>>>>> protected String getClassifier()
>>>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1739979 - in /maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar: AbstractJarMojo.java JarMojo.java TestJarMojo.java
Posted by Robert Scholte <rf...@apache.org>.
Hi Karl-Heinz,
the current situation is that if you haven't defined plugin versions, the
version as defined in Maven will be used. So if I use a different version
of Maven, other versions of the plugins might kick in with a different
result.
By moving it to the "packaging" plugin, at least the same versions of
plugins will be used, no matter the version of Maven.
This way there's no such thing as "custom" packaging plugin anymore, they
are all treated the same.
So if the packaging type is jar, the maven-jar-plugin will decide which
versions of resources-, compiler- and other plugins will be used. These
will be the defaults, it is still better to define the versions of these
plugins within every pom.
bq. > maven-install-plugin will define install phase for jar life cycle
> maven-jar-plugin will define the package phase for jar life cycle ..
Only the latter. The maven-jar-plugin defines the lifecycle and which
plugins arebound to the phases.
Otherwise there are multiple definitions of the build-lifecycle.
Hervé also said something interesting: by moving lifecycles to the
corresponding plugin, the plugin should be specified with version +
extension=true (as required for custom lifecycles). Maven doesn't isn't
aware of the lifecycles anymore, which is not developer-friendly. So we
still need a mapping from packaging to plugin, and it must be extendable.
Anyhow, we need to copy these things first to the packaging-plugins. Once
these plugins contain the lifecycle mapping we can start adjusting Maven.
thanks,
Robert
On Wed, 20 Apr 2016 20:11:58 +0200, Karl Heinz Marbaise
<kh...@gmx.de> wrote:
> Hi Robert,
>
> On 4/20/16 9:48 AM, Robert Scholte wrote:
>> https://issues.apache.org/jira/browse/MJAR-183 should also be good to do
>> now.
>> that is: *copy* the lifecycle from core to the plugin.
>> IIRC it was Igor who told me this was safe to do, Maven has a clear
>> strategy how to resolve lifecycle handlers, having definitions in both
>> Maven and the plugin shouldn't be an issue.
>>
>> I don't have time to test this within the next couple of days, unless we
>> take some extra time to go through such issues (since this is the 3.0.0
>> version)
>
> If i correctly understand this means:
>
> <component>
> <role>org.apache.maven.artifact.handler.ArtifactHandler</role>
> <role-hint>jar</role-hint>
>
> <implementation>org.apache.maven.artifact.handler.DefaultArtifactHandler</implementation>
> <configuration>
> <type>jar</type>
> <language>java</language>
> <addedToClasspath>true</addedToClasspath>
> </configuration>
> </component>
>
>
> and the following in the artifacts-handler.xml in
> src/main/resources/META-INF/plexus/ ....
>
> <component>
> <role>org.apache.maven.lifecycle.mapping.LifecycleMapping</role>
> <role-hint>jar</role-hint>
>
> <implementation>org.apache.maven.lifecycle.mapping.DefaultLifecycleMapping</implementation>
> <configuration>
> <lifecycles>
> <lifecycle>
> <id>default</id>
> <!-- START SNIPPET: jar-lifecycle -->
> <phases>
> <package>
> org.apache.maven.plugins:maven-jar-plugin:${project.version}:jar
> </package>
> </phases>
> <!-- END SNIPPET: jar-lifecycle -->
> </lifecycle>
> </lifecycles>
> </configuration>
> </component>
>
>
> But one point i don't understand is of this....for example
> if the whole life cycle should be defined by having several plugins
> participate into for example the jar life cycle...but the question is:
>
> Do i need to define the whole life cycle with all plugins within the
> maven-jar-plugin or should the appropriate plugin only define it's part
> of the life cycle ?
>
> Is there a kind of merge for this life cycle mapping if two or more
> plugins define parts of the above ...for example:
>
> maven-install-plugin will define install phase for jar life cycle
> maven-jar-plugin will define the package phase for jar life cycle ..>
>
> Any ideas / Explanations ?
>
>
> Kind regards
> Karl Heinz Marbaise
>
>
>
>
>
>>
>> Robert
>>
>> On Tue, 19 Apr 2016 21:27:38 +0200, Robert Scholte
>> <rf...@apache.org> wrote:
>>
>>> Hi,
>>>
>>> Not sure if this is the right moment, but I'd like to make finalName
>>> readonly for all packaging plugins.
>>> The reason: for some new features I probably need to know the name of
>>> the generated (main) artifact, preferably without having to analyze
>>> plugin configuration. Instead, users should use the
>>> project.build.finalName to set its value.
>>>
>>> thanks,
>>> Robert
>>>
>>>
>>> On Tue, 19 Apr 2016 20:46:12 +0200, <kh...@apache.org> wrote:
>>>
>>>> Author: khmarbaise
>>>> Date: Tue Apr 19 18:46:11 2016
>>>> New Revision: 1739979
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1739979&view=rev
>>>> Log:
>>>> [MJAR-209] Remove param properties that doesn't make sense for CLI
>>>> usage
>>>> o Removed the following properties:
>>>> - maven.jar.finalName
>>>> - maven.jar.skipIfEmpty
>>>> - maven.jar.classifier
>>>> - maven.jar.testClassifier
>>>>
>>>> Modified:
>>>>
>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>>
>>>>
>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>>
>>>>
>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>>
>>>>
>>>> Modified:
>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>>
>>>> URL:
>>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>>
>>>> ==============================================================================
>>>>
>>>> ---
>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>> (original)
>>>> +++
>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>> Tue Apr 19 18:46:11 2016
>>>> @@ -72,7 +72,7 @@ public abstract class AbstractJarMojo
>>>> * Starting with <b>3.0.0</b> the property has been renamed from
>>>> <code>jar.finalName</code> to
>>>> * <code>maven.jar.finalName</code>.
>>>> */
>>>> - @Parameter( property = "maven.jar.finalName", defaultValue =
>>>> "${project.build.finalName}" )
>>>> + @Parameter( defaultValue = "${project.build.finalName}" )
>>>> private String finalName;
>>>> /**
>>>> @@ -135,7 +135,7 @@ public abstract class AbstractJarMojo
>>>> * Starting with <b>3.0.0</b> the property has been renamed from
>>>> <code>jar.skipIfEmpty</code> to
>>>> * <code>maven.jar.skipIfEmpty</code>.
>>>> */
>>>> - @Parameter( property = "maven.jar.skipIfEmpty", defaultValue =
>>>> "false" )
>>>> + @Parameter( defaultValue = "false" )
>>>> private boolean skipIfEmpty;
>>>> /**
>>>>
>>>> Modified:
>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>>
>>>> URL:
>>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>>
>>>> ==============================================================================
>>>>
>>>> ---
>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>> (original)
>>>> +++
>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>> Tue Apr 19 18:46:11 2016
>>>> @@ -49,7 +49,7 @@ public class JarMojo
>>>> * If not given this will create the main artifact which is the
>>>> default behavior.
>>>> * If you try to do that a second time without using a
>>>> classifier the build will fail.
>>>> */
>>>> - @Parameter( property = "maven.jar.classifier" )
>>>> + @Parameter
>>>> private String classifier;
>>>> protected String getClassifier()
>>>>
>>>> Modified:
>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>>
>>>> URL:
>>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>>
>>>> ==============================================================================
>>>>
>>>> ---
>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>> (original)
>>>> +++
>>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>> Tue Apr 19 18:46:11 2016
>>>> @@ -55,7 +55,7 @@ public class TestJarMojo
>>>> /**
>>>> * Classifier to used for {@code test-jar}.
>>>> */
>>>> - @Parameter( property = "maven.jar.testClassifier", defaultValue
>>>> = "tests" )
>>>> + @Parameter( defaultValue = "tests" )
>>>> private String classifier;
>>>> protected String getClassifier()
>>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1739979 - in
/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar:
AbstractJarMojo.java JarMojo.java TestJarMojo.java
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi Robert,
On 4/20/16 9:48 AM, Robert Scholte wrote:
> https://issues.apache.org/jira/browse/MJAR-183 should also be good to do
> now.
> that is: *copy* the lifecycle from core to the plugin.
> IIRC it was Igor who told me this was safe to do, Maven has a clear
> strategy how to resolve lifecycle handlers, having definitions in both
> Maven and the plugin shouldn't be an issue.
>
> I don't have time to test this within the next couple of days, unless we
> take some extra time to go through such issues (since this is the 3.0.0
> version)
If i correctly understand this means:
<component>
<role>org.apache.maven.artifact.handler.ArtifactHandler</role>
<role-hint>jar</role-hint>
<implementation>org.apache.maven.artifact.handler.DefaultArtifactHandler</implementation>
<configuration>
<type>jar</type>
<language>java</language>
<addedToClasspath>true</addedToClasspath>
</configuration>
</component>
and the following in the artifacts-handler.xml in
src/main/resources/META-INF/plexus/ ....
<component>
<role>org.apache.maven.lifecycle.mapping.LifecycleMapping</role>
<role-hint>jar</role-hint>
<implementation>org.apache.maven.lifecycle.mapping.DefaultLifecycleMapping</implementation>
<configuration>
<lifecycles>
<lifecycle>
<id>default</id>
<!-- START SNIPPET: jar-lifecycle -->
<phases>
<package>
org.apache.maven.plugins:maven-jar-plugin:${project.version}:jar
</package>
</phases>
<!-- END SNIPPET: jar-lifecycle -->
</lifecycle>
</lifecycles>
</configuration>
</component>
But one point i don't understand is of this....for example
if the whole life cycle should be defined by having several plugins
participate into for example the jar life cycle...but the question is:
Do i need to define the whole life cycle with all plugins within the
maven-jar-plugin or should the appropriate plugin only define it's part
of the life cycle ?
Is there a kind of merge for this life cycle mapping if two or more
plugins define parts of the above ...for example:
maven-install-plugin will define install phase for jar life cycle
maven-jar-plugin will define the package phase for jar life cycle ..
Any ideas / Explanations ?
Kind regards
Karl Heinz Marbaise
>
> Robert
>
> On Tue, 19 Apr 2016 21:27:38 +0200, Robert Scholte
> <rf...@apache.org> wrote:
>
>> Hi,
>>
>> Not sure if this is the right moment, but I'd like to make finalName
>> readonly for all packaging plugins.
>> The reason: for some new features I probably need to know the name of
>> the generated (main) artifact, preferably without having to analyze
>> plugin configuration. Instead, users should use the
>> project.build.finalName to set its value.
>>
>> thanks,
>> Robert
>>
>>
>> On Tue, 19 Apr 2016 20:46:12 +0200, <kh...@apache.org> wrote:
>>
>>> Author: khmarbaise
>>> Date: Tue Apr 19 18:46:11 2016
>>> New Revision: 1739979
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1739979&view=rev
>>> Log:
>>> [MJAR-209] Remove param properties that doesn't make sense for CLI usage
>>> o Removed the following properties:
>>> - maven.jar.finalName
>>> - maven.jar.skipIfEmpty
>>> - maven.jar.classifier
>>> - maven.jar.testClassifier
>>>
>>> Modified:
>>>
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>
>>>
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>
>>>
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>
>>>
>>> Modified:
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>>
>>> URL:
>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>
>>> ==============================================================================
>>>
>>> ---
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>> (original)
>>> +++
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>>> Tue Apr 19 18:46:11 2016
>>> @@ -72,7 +72,7 @@ public abstract class AbstractJarMojo
>>> * Starting with <b>3.0.0</b> the property has been renamed from
>>> <code>jar.finalName</code> to
>>> * <code>maven.jar.finalName</code>.
>>> */
>>> - @Parameter( property = "maven.jar.finalName", defaultValue =
>>> "${project.build.finalName}" )
>>> + @Parameter( defaultValue = "${project.build.finalName}" )
>>> private String finalName;
>>> /**
>>> @@ -135,7 +135,7 @@ public abstract class AbstractJarMojo
>>> * Starting with <b>3.0.0</b> the property has been renamed from
>>> <code>jar.skipIfEmpty</code> to
>>> * <code>maven.jar.skipIfEmpty</code>.
>>> */
>>> - @Parameter( property = "maven.jar.skipIfEmpty", defaultValue =
>>> "false" )
>>> + @Parameter( defaultValue = "false" )
>>> private boolean skipIfEmpty;
>>> /**
>>>
>>> Modified:
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>>
>>> URL:
>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>
>>> ==============================================================================
>>>
>>> ---
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>> (original)
>>> +++
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>>> Tue Apr 19 18:46:11 2016
>>> @@ -49,7 +49,7 @@ public class JarMojo
>>> * If not given this will create the main artifact which is the
>>> default behavior.
>>> * If you try to do that a second time without using a
>>> classifier the build will fail.
>>> */
>>> - @Parameter( property = "maven.jar.classifier" )
>>> + @Parameter
>>> private String classifier;
>>> protected String getClassifier()
>>>
>>> Modified:
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>>
>>> URL:
>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>>>
>>> ==============================================================================
>>>
>>> ---
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>> (original)
>>> +++
>>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>> Tue Apr 19 18:46:11 2016
>>> @@ -55,7 +55,7 @@ public class TestJarMojo
>>> /**
>>> * Classifier to used for {@code test-jar}.
>>> */
>>> - @Parameter( property = "maven.jar.testClassifier", defaultValue
>>> = "tests" )
>>> + @Parameter( defaultValue = "tests" )
>>> private String classifier;
>>> protected String getClassifier()
>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1739979 - in /maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar: AbstractJarMojo.java JarMojo.java TestJarMojo.java
Posted by Robert Scholte <rf...@apache.org>.
https://issues.apache.org/jira/browse/MJAR-183 should also be good to do
now.
that is: *copy* the lifecycle from core to the plugin.
IIRC it was Igor who told me this was safe to do, Maven has a clear
strategy how to resolve lifecycle handlers, having definitions in both
Maven and the plugin shouldn't be an issue.
I don't have time to test this within the next couple of days, unless we
take some extra time to go through such issues (since this is the 3.0.0
version)
Robert
On Tue, 19 Apr 2016 21:27:38 +0200, Robert Scholte <rf...@apache.org>
wrote:
> Hi,
>
> Not sure if this is the right moment, but I'd like to make finalName
> readonly for all packaging plugins.
> The reason: for some new features I probably need to know the name of
> the generated (main) artifact, preferably without having to analyze
> plugin configuration. Instead, users should use the
> project.build.finalName to set its value.
>
> thanks,
> Robert
>
>
> On Tue, 19 Apr 2016 20:46:12 +0200, <kh...@apache.org> wrote:
>
>> Author: khmarbaise
>> Date: Tue Apr 19 18:46:11 2016
>> New Revision: 1739979
>>
>> URL: http://svn.apache.org/viewvc?rev=1739979&view=rev
>> Log:
>> [MJAR-209] Remove param properties that doesn't make sense for CLI usage
>> o Removed the following properties:
>> - maven.jar.finalName
>> - maven.jar.skipIfEmpty
>> - maven.jar.classifier
>> - maven.jar.testClassifier
>>
>> Modified:
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>>
>> Modified:
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>> URL:
>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>> ==============================================================================
>> ---
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>> (original)
>> +++
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
>> Tue Apr 19 18:46:11 2016
>> @@ -72,7 +72,7 @@ public abstract class AbstractJarMojo
>> * Starting with <b>3.0.0</b> the property has been renamed from
>> <code>jar.finalName</code> to
>> * <code>maven.jar.finalName</code>.
>> */
>> - @Parameter( property = "maven.jar.finalName", defaultValue =
>> "${project.build.finalName}" )
>> + @Parameter( defaultValue = "${project.build.finalName}" )
>> private String finalName;
>> /**
>> @@ -135,7 +135,7 @@ public abstract class AbstractJarMojo
>> * Starting with <b>3.0.0</b> the property has been renamed from
>> <code>jar.skipIfEmpty</code> to
>> * <code>maven.jar.skipIfEmpty</code>.
>> */
>> - @Parameter( property = "maven.jar.skipIfEmpty", defaultValue =
>> "false" )
>> + @Parameter( defaultValue = "false" )
>> private boolean skipIfEmpty;
>> /**
>>
>> Modified:
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>> URL:
>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>> ==============================================================================
>> ---
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>> (original)
>> +++
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/JarMojo.java
>> Tue Apr 19 18:46:11 2016
>> @@ -49,7 +49,7 @@ public class JarMojo
>> * If not given this will create the main artifact which is the
>> default behavior.
>> * If you try to do that a second time without using a classifier
>> the build will fail.
>> */
>> - @Parameter( property = "maven.jar.classifier" )
>> + @Parameter
>> private String classifier;
>> protected String getClassifier()
>>
>> Modified:
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>> URL:
>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java?rev=1739979&r1=1739978&r2=1739979&view=diff
>> ==============================================================================
>> ---
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>> (original)
>> +++
>> maven/plugins/trunk/maven-jar-plugin/src/main/java/org/apache/maven/plugins/jar/TestJarMojo.java
>> Tue Apr 19 18:46:11 2016
>> @@ -55,7 +55,7 @@ public class TestJarMojo
>> /**
>> * Classifier to used for {@code test-jar}.
>> */
>> - @Parameter( property = "maven.jar.testClassifier", defaultValue =
>> "tests" )
>> + @Parameter( defaultValue = "tests" )
>> private String classifier;
>> protected String getClassifier()
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org