[GitHub] [skywalking-infra-e2e] lujiajing1126 commented on pull request #101: support pull images in kind mod (#10397)

["lujiajing1126 (via GitHub)" <gi...@apache.org>]

lujiajing1126 commented on PR #101:
URL: https://github.com/apache/skywalking-infra-e2e/pull/101#issuecomment-1434818076

   > I have some curious, if it's just working on pulling docker images from remote before loading them into `KinD` cluster, so why don't we just check whether the image already exists in the local machine or not? If not exist, then we pull it. In this way, we don't need a new configuration. BTW, I think it usually duplicates with the `import-images` configuration.
   
   I agree. Seem the current impl does not check the existence in the local registry.
   
   I've checked locally, but failed to make use of the local images. It may break the E2E cases in the main repo.
   
   @ethan256 could you pls make another check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org