You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/02/26 02:53:35 UTC
[GitHub] [calcite] GavinRay97 opened a new pull request #2733: [CALCITE-4739] Support Postgres JSON_OBJECT syntax
GavinRay97 opened a new pull request #2733:
URL: https://github.com/apache/calcite/pull/2733
https://issues.apache.org/jira/browse/CALCITE-4739
To properly test this, I'd like to integrate Testcontainers and add tests which start an ephemeral PG container
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xy2953396112 commented on pull request #2733: [CALCITE-4739] Support Postgres JSON_OBJECT syntax
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on pull request #2733:
URL: https://github.com/apache/calcite/pull/2733#issuecomment-1066519412
Add a unit testοΌ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] GavinRay97 commented on pull request #2733: [CALCITE-4739] Support Postgres JSON_OBJECT syntax
Posted by GitBox <gi...@apache.org>.
GavinRay97 commented on pull request #2733:
URL: https://github.com/apache/calcite/pull/2733#issuecomment-1066825261
I might close this, FWIW it's not useful to do more work/fixes on JSON functionality until the bug where JSON objects are improperly escaped gets fixed
Because any query which uses more than one level of JSON depth comes back malformed π
https://issues.apache.org/jira/browse/CALCITE-4989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] GavinRay97 edited a comment on pull request #2733: [CALCITE-4739] Support Postgres JSON_OBJECT syntax
Posted by GitBox <gi...@apache.org>.
GavinRay97 edited a comment on pull request #2733:
URL: https://github.com/apache/calcite/pull/2733#issuecomment-1066825261
I might close this, FWIW it's not useful to do more work/fixes on JSON functionality until the bug where JSON objects are improperly escaped gets fixed
Because any query which uses more than one level of JSON depth comes back malformed π
https://issues.apache.org/jira/browse/CALCITE-4989
This one is hard to fix, because to properly handle this you would need to somehow look at the overall query, and see if there are nested JSON calls. I don't know enough about Calcite to be able to implement this (or maybe it's not possible)
Essentially you need to keep a "stack"/context of how many levels of JSON calls you are deep in a SQL query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] GavinRay97 edited a comment on pull request #2733: [CALCITE-4739] Support Postgres JSON_OBJECT syntax
Posted by GitBox <gi...@apache.org>.
GavinRay97 edited a comment on pull request #2733:
URL: https://github.com/apache/calcite/pull/2733#issuecomment-1066825261
I might close this, FWIW it's not useful to do more work/fixes on JSON functionality until the bug where JSON objects are improperly escaped gets fixed
Because any query which uses more than one level of JSON depth comes back malformed π
https://issues.apache.org/jira/browse/CALCITE-4989
This one is hard to fix, because to properly handle this you would need to somehow look at the overall query, and see if there are nested JSON calls. I don't know enough about Calcite to be able to implement this (or maybe it's not possible)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org