You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/07/19 06:33:41 UTC

[GitHub] [incubator-inlong] TszKitLo40 opened a new pull request #557: [INLONG-755]Go SDK Consumer Result

TszKitLo40 opened a new pull request #557:
URL: https://github.com/apache/incubator-inlong/pull/557


   Signed-off-by: Zijie Lu <ws...@gmail.com>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] TszKitLo40 commented on pull request #557: [INLONG-755]Go SDK Consumer Result

Posted by GitBox <gi...@apache.org>.
TszKitLo40 commented on pull request #557:
URL: https://github.com/apache/incubator-inlong/pull/557#issuecomment-882279579


   @charlely @gosonzhang PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] codecov-commenter commented on pull request #557: [INLONG-755]Go SDK Consumer Result

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #557:
URL: https://github.com/apache/incubator-inlong/pull/557#issuecomment-882281279


   # [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/557?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#557](https://codecov.io/gh/apache/incubator-inlong/pull/557?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d9c80a4) into [INLONG-25](https://codecov.io/gh/apache/incubator-inlong/commit/7b94fb831a402a86c1f9a874abea10bf5adb042d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b94fb8) will **increase** coverage by `0.04%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-inlong/pull/557/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-inlong/pull/557?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff               @@
   ##             INLONG-25    #557      +/-   ##
   ==============================================
   + Coverage         7.47%   7.51%   +0.04%     
   - Complexity         477     479       +2     
   ==============================================
     Files              267     267              
     Lines            29500   29500              
     Branches          4843    4843              
   ==============================================
   + Hits              2204    2216      +12     
   + Misses           26822   26810      -12     
     Partials           474     474              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/557?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../producer/qltystats/DefaultBrokerRcvQltyStats.java](https://codecov.io/gh/apache/incubator-inlong/pull/557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL2NsaWVudC9wcm9kdWNlci9xbHR5c3RhdHMvRGVmYXVsdEJyb2tlclJjdlFsdHlTdGF0cy5qYXZh) | `45.70% <0.00%> (+1.17%)` | :arrow_up: |
   | [.../java/org/apache/flume/sink/tubemq/TubemqSink.java](https://codecov.io/gh/apache/incubator-inlong/pull/557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLWNvbm5lY3RvcnMvdHViZW1xLWNvbm5lY3Rvci1mbHVtZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZmx1bWUvc2luay90dWJlbXEvVHViZW1xU2luay5qYXZh) | `55.42% <0.00%> (+4.00%)` | :arrow_up: |
   | [.../client/producer/qltystats/BrokerStatsItemSet.java](https://codecov.io/gh/apache/incubator-inlong/pull/557/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL2NsaWVudC9wcm9kdWNlci9xbHR5c3RhdHMvQnJva2VyU3RhdHNJdGVtU2V0LmphdmE=) | `72.09% <0.00%> (+4.65%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/557?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/557?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b94fb8...d9c80a4](https://codecov.io/gh/apache/incubator-inlong/pull/557?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] gosonzhang merged pull request #557: [INLONG-755]Go SDK Consumer Result

Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #557:
URL: https://github.com/apache/incubator-inlong/pull/557


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] charlely commented on a change in pull request #557: [INLONG-755]Go SDK Consumer Result

Posted by GitBox <gi...@apache.org>.
charlely commented on a change in pull request #557:
URL: https://github.com/apache/incubator-inlong/pull/557#discussion_r672061392



##########
File path: tubemq-client-twins/tubemq-client-go/client/consumer_impl.go
##########
@@ -383,7 +383,7 @@ func (c *consumer) processRebalanceEvent() {
 }
 
 func (c *consumer) disconnect2Broker(event *metadata.ConsumerEvent) {
-	log.Tracef("[disconnect2Broker] connect event begin, client id=%s", c.clientID)
+	log.Tracef("[disconnect2Broker] connect event begin, client=%s", c.clientID)

Review comment:
       This is disconnect function, but this is concet event.

##########
File path: tubemq-client-twins/tubemq-client-go/client/consumer_impl.go
##########
@@ -393,7 +393,7 @@ func (c *consumer) disconnect2Broker(event *metadata.ConsumerEvent) {
 		}
 	}
 	event.SetEventStatus(metadata.Disconnect)
-	log.Tracef("[disconnect2Broker] connect event finished, client id=%s", c.clientID)
+	log.Tracef("[disconnect2Broker] connect event finished, client=%s", c.clientID)

Review comment:
       dito




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] gosonzhang merged pull request #557: [INLONG-755]Go SDK Consumer Result

Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #557:
URL: https://github.com/apache/incubator-inlong/pull/557


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org