You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/18 18:43:27 UTC
[GitHub] [pulsar] srkukarni opened a new pull request #7843: Add More producer knobs
srkukarni opened a new pull request #7843:
URL: https://github.com/apache/pulsar/pull/7843
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
This pr adds more Producer Config knobs to FunctionConfig and SourceConfig.
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] srkukarni commented on pull request #7843: Add More producer knobs
Posted by GitBox <gi...@apache.org>.
srkukarni commented on pull request #7843:
URL: https://github.com/apache/pulsar/pull/7843#issuecomment-678362795
Looks like otherwise python based functions don't come up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on pull request #7843: Add More producer knobs
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on pull request #7843:
URL: https://github.com/apache/pulsar/pull/7843#issuecomment-679297763
@srkukarni if we are going to add configs that aren't support in Python or GO, we should either return a error to the user if a user tries to set one of these configs or document it well some where
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on pull request #7843: Add More producer knobs
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on pull request #7843:
URL: https://github.com/apache/pulsar/pull/7843#issuecomment-677999446
@srkukarni why are we generating the new protobuf code for python when we are not adding the support for the new configs in python functions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7843: Add More producer knobs
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7843:
URL: https://github.com/apache/pulsar/pull/7843#issuecomment-721697506
@srkukarni Could you please take a look at the last comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on a change in pull request #7843: Add More producer knobs
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #7843:
URL: https://github.com/apache/pulsar/pull/7843#discussion_r478543501
##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/functions/ProducerConfig.java
##########
@@ -36,4 +36,8 @@
private Integer maxPendingMessages;
private Integer maxPendingMessagesAcrossPartitions;
private Boolean useThreadLocalProducers;
+ private Boolean disableBatching;
+ private Integer batchingMaxPublishDelay;
Review comment:
```suggestion
private Integer batchingMaxPublishDelayMs;
```
##########
File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSink.java
##########
@@ -110,6 +108,22 @@ protected PulsarSinkProcessorBase(Schema schema) {
if (pulsarSinkConfig.getProducerSpec().getMaxPendingMessagesAcrossPartitions() != 0) {
builder.maxPendingMessagesAcrossPartitions(pulsarSinkConfig.getProducerSpec().getMaxPendingMessagesAcrossPartitions());
}
+ if (!pulsarSinkConfig.getProducerSpec().getDisableBatching()) {
+ builder.enableBatching(true);
Review comment:
The batching is enabled by default in the builder. So I don't think this change is able to disable batching.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7843: Add More producer knobs
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7843:
URL: https://github.com/apache/pulsar/pull/7843#issuecomment-727163837
move to 2.8.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #7843: Add More producer knobs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7843:
URL: https://github.com/apache/pulsar/pull/7843#issuecomment-1058899469
@srkukarni:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org