You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Aihua Xu (Jira)" <ji...@apache.org> on 2020/11/03 03:54:00 UTC
[jira] [Assigned] (HDFS-15467) ObserverReadProxyProvider should
skip logging first failover from each proxy
[ https://issues.apache.org/jira/browse/HDFS-15467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aihua Xu reassigned HDFS-15467:
-------------------------------
Assignee: Aihua Xu
> ObserverReadProxyProvider should skip logging first failover from each proxy
> ----------------------------------------------------------------------------
>
> Key: HDFS-15467
> URL: https://issues.apache.org/jira/browse/HDFS-15467
> Project: Hadoop HDFS
> Issue Type: Task
> Reporter: Hanisha Koneru
> Assignee: Aihua Xu
> Priority: Major
>
> After HADOOP-17116, \{{RetryInvocationHandler}} skips logging the first failover INFO message from each proxy. But {{ObserverReadProxyProvider}} uses {{combinedProxy}} object which combines all proxies into one and assigns {{combinedInfo}} as the ProxyInfo.
> {noformat}
> ObserverReadProxyProvider# Lines 197-207:
> for (int i = 0; i < nameNodeProxies.size(); i++) {
> if (i > 0) {
> combinedInfo.append(",");
> }
> combinedInfo.append(nameNodeProxies.get(i).proxyInfo);
> }
> combinedInfo.append(']');
> T wrappedProxy = (T) Proxy.newProxyInstance(
> ObserverReadInvocationHandler.class.getClassLoader(),
> new Class<?>[] {xface}, new ObserverReadInvocationHandler());
> combinedProxy = new ProxyInfo<>(wrappedProxy, combinedInfo.toString()){noformat}
> {{RetryInvocationHandler}} depends on the {{ProxyInfo}} to differentiate between proxies while checking if failover from that proxy happened before. And since combined proxy has only 1 proxy, HADOOP-17116 doesn't work on {{ObserverReadProxyProvider.}}It would need to handled separately.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org