Re: Review Request 14406: Review Request: JSON RPC servlet does not support CORS properly

[Ryan Baxter <rb...@gmail.com>]

> On Sept. 30, 2013, 9:21 p.m., Henry Saputra wrote:
> > Is this a complete patch? I am seeing "com.thetransactioncompany.cors.CORSFilter" in the web.xml changes as part of the diff

Looks like the patch for the pom.xml isn't right.


- Ryan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14406/#review26513
-----------------------------------------------------------


On Sept. 30, 2013, 6:02 p.m., Mike Pawlowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14406/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2013, 6:02 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/SHINDIG-1927
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SHINDIG-1927
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Attached a patch to implement full CORS support in Apache Shindig via the open source CORS servlet filter:
> 
> Name: CORS Filter
> Version: 1.7.1
> Homepage: http://software.dzhuvinov.com/cors-filter.html
> License(s): Apache License, Version 2.0 (License link is broken)
> Downloaded From: http://search.maven.org/#browse%7C540685910
> Notes: N/A
> 
> Name: Java Property Utility 
> Version: 1.9
> Homepage: http://software.dzhuvinov.com/cors-filter-installation.html
> License(s): Apache License, Version 2.0 (License link is broken)
> Downloaded From: http://search.maven.org/#browse%7C-89813813
> Notes: Required dependency for "CORS Filter"
> 
> See JIRA issue for details: https://issues.apache.org/jira/browse/SHINDIG-1927
> 
> Please note that this patch relies on the patch attached to the following JIRA issue:
> Remove partial implementation of CORS support
> https://issues.apache.org/jira/browse/SHINDIG-1934
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/pom.xml 1526722 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml 1526722 
> 
> Diff: https://reviews.apache.org/r/14406/diff/
> 
> 
> Testing
> -------
> 
> * Build was successful (except for a few unrelated build hiccups)
> * Manual testing was successful
>   => Test environment: 
>         - (I) Shindig server deployed as a stand alone app hosted on its own domain; 
>         - (II) Common container utilized by another app hosted on its own domain
>   => Cross domain POST HTTP request was successful
>       - e.g. http://localhost:9082/rpc?st=ownerId%3AviewerId%3Aappid%3Ashindig%3Aurl%3A0%3Adefault
> 
> 
> Thanks,
> 
> Mike Pawlowski
> 
>