You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/09/28 18:17:37 UTC

[GitHub] [hadoop-ozone] nandakumar131 commented on pull request #1414: HDDS-4231. Background Service blocks on task results.

nandakumar131 commented on pull request #1414:
URL: https://github.com/apache/hadoop-ozone/pull/1414#issuecomment-700200428


   Overall the patch looks good to me.
   
   A minor suggestion, feel free to ignore it.
   Instead of having a generic reference in `BackgroundTaskQueue` (which actually represents the type of result returned by the task in the queue, not the item in the queue), the `BackgroundTask<T>` can be modified to `BackgroundTask<BackgroundTaskResult>`. This will be more explicit.
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org