You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:17:02 UTC
[GitHub] [httpcomponents-core] carterkozak opened a new pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
carterkozak opened a new pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak commented on a change in pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
carterkozak commented on a change in pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#discussion_r461660914
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnection.java
##########
@@ -157,8 +156,8 @@ public void sendRequestEntity(final ClassicHttpRequest request) throws HttpExcep
try (final OutputStream outStream = createContentOutputStream(
len, this.outbuffer, new OutputStream() {
- final boolean ssl = socketHolder.getSocket() instanceof SSLSocket;
final InputStream socketInputStream = socketHolder.getInputStream();
+ final boolean earlyResponseCheckRequiresRead = !(socketInputStream instanceof FileInputStream);
Review comment:
I agree, unfortunately I'm not aware of a better way. In the worst case if the InputStream is wrapped we will fall back to the read-with-1ms-timeout approach that we're confident works correctly everywhere, but on older (LTS) JREs we may incur a the performance penalty. Since this uses the result of Socket.getInputStream directly in the cases I've tested, it does preserve the existing behavior where that works correctly.
This also fixes the issue when a custom jsse provider is applied (Conscrypt, for example with `setUseEngineSocketByDefault(true)`) even on older java versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-670033739
>
>
> > @ok2c What platform? I did not have any of these with Zulu and OpenJDK on Windows and FreeBSD.
>
> Ubuntu Linux 2018.04 LTS
Can you please share the failures?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669950146
@ok2c What platform? I did not have any of these with Zulu and OpenJDK on Windows and FreeBSD.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-670037432
```
org.junit.runners.model.TestTimedOutException: test timed out after 5000 milliseconds
at java.base@14.0.2/sun.nio.ch.Net.poll(Native Method)
at java.base@14.0.2/sun.nio.ch.NioSocketImpl.park(NioSocketImpl.java:181)
at java.base@14.0.2/sun.nio.ch.NioSocketImpl.park(NioSocketImpl.java:190)
at java.base@14.0.2/sun.nio.ch.NioSocketImpl.implWrite(NioSocketImpl.java:415)
at java.base@14.0.2/sun.nio.ch.NioSocketImpl.write(NioSocketImpl.java:440)
at java.base@14.0.2/sun.nio.ch.NioSocketImpl$2.write(NioSocketImpl.java:826)
at java.base@14.0.2/java.net.Socket$SocketOutputStream.write(Socket.java:1052)
at app//org.apache.hc.core5.http.impl.io.DefaultBHttpClientConnection$1.write(DefaultBHttpClientConnection.java:227)
at app//org.apache.hc.core5.http.impl.io.SessionOutputBufferImpl.flushBuffer(SessionOutputBufferImpl.java:117)
at app//org.apache.hc.core5.http.impl.io.SessionOutputBufferImpl.write(SessionOutputBufferImpl.java:150)
at app//org.apache.hc.core5.http.impl.io.ChunkedOutputStream.flushCacheWithAppend(ChunkedOutputStream.java:125)
at app//org.apache.hc.core5.http.impl.io.ChunkedOutputStream.write(ChunkedOutputStream.java:204)
at app//org.apache.hc.core5.http.io.entity.InputStreamEntity.writeTo(InputStreamEntity.java:96)
at app//org.apache.hc.core5.http.impl.io.DefaultBHttpClientConnection.sendRequestEntity(DefaultBHttpClientConnection.java:248)
at app//org.apache.hc.core5.http.impl.io.HttpRequestExecutor.execute(HttpRequestExecutor.java:164)
at app//org.apache.hc.core5.http.impl.bootstrap.HttpRequester.execute(HttpRequester.java:202)
at app//org.apache.hc.core5.http.impl.bootstrap.HttpRequester.execute(HttpRequester.java:342)
at app//org.apache.hc.core5.http.impl.bootstrap.HttpRequester.execute(HttpRequester.java:434)
at app//org.apache.hc.core5.testing.classic.MonitoringResponseOutOfOrderStrategyIntegrationTest.testResponseOutOfOrderWithDefaultStrategy(MonitoringResponseOutOfOrderStrategyIntegrationTest.java:172)
at java.base@14.0.2/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base@14.0.2/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base@14.0.2/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base@14.0.2/java.lang.reflect.Method.invoke(Method.java:564)
at app//org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at app//org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at app//org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at app//org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at app//org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
at app//org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
at java.base@14.0.2/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base@14.0.2/java.lang.Thread.run(Thread.java:832)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669898728
@carterkozak @michael-o Please help me understand the problem. I am seeing intermittent failures of `MonitoringResponseOutOfOrderStrategyIntegrationTest` on Oracle Java 13.0.2 and 14.0.2 but this is more likely due to flakiness of the integration test itself rather than a problem with the underlying JRE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-670042424
I think #214 resolves the test flake (it does on my reproducer anyhow). It seems the timing changed for `InputStream.available()` to report data between jre12 and 13. I was wrong about HTTPCORE-640: available does still work, but doesn't report available data as quickly as far as I can tell.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669139317
That's odd. I don't expect any change in behavior using TLS, however plain http response detection hasn't worked for me on linux on 13+. I'm setting up a Windows instance to do some testing.
Can you describe the test configuration? How large is the response that tomcat sends?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669152479
Here you go: https://home.apache.org/~michaelo/issues/early-response/try-6/20b1cc8fd8e1050bbd3957b21697138e074dd24d/
Windows 10: My work laptop, connected via VPN, server is physically 10 km away.
FreeBSD: Both test and target service reside on the same physical machine, but with the difference that the service itself is in a jail, JAR has been run on the jailhost.
I don't see the behavior you have observed. Please don't get confused by the writing, I have added a few sysouts to see more information. The code itself remained untouched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-670517054
Closing this because #214 has merged and I have closed the HTTPCORE-640 ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-670046860
> Does it work when you increase the timeout?
No, the problem is that we're able to write a chunk to the socket output stream after `available()` has returned zero. The send buffer is full and blocking waiting for the server to read bytes, however the server has already rejected the request and started to send a response. At this point he client is still trying to send request bytes, and isn't consuming the servers response, so the exchange will end with a timeout.
> How often does it occur?
I am able to reproduce the failure every time using a fast linux system and jdk14.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669142919
The test setup is basically a loop which uploads a ZIP file (around 7 MB) to a Tomcat instance. The target URL is auth protected and Tomcat detects that really quick, therefore closes the connection. In an optional case, only few hundred kilobytes are transfered before HttpClient detects the premature end of transfer.
Tomcat in return responds with 401, `WWW-Authenticate: Negotiate` and the usual HTML error page:
```
<!doctype html><html lang="en"><head><title>HTTP Status 401 – Unauthorized</title><style type="text/css">body {font-family:Tahoma,Arial,sans-serif;} h1, h2, h3, b {color:white;background-color:#525D76;} h1 {font-size:22px;} h2 {font-size:16px;} h3 {font-size:14px;} p {font-size:12px;} a {color:black;} .line {height:1px;background-color:#525D76;border:none;}</style></head><body><h1>HTTP Status 401 – Unauthorized</h1></body></html>
```
I am using two connectors, one for plain, one for TLS. Both use APR via libtcnative. TLS uses OpenSSL via libtcntative too. I can provide logfiles if you like.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o edited a comment on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
michael-o edited a comment on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669142919
The test setup is basically a loop which uploads a ZIP file (around 7 MB) to a Tomcat 8.5.5x instance. The target URL is auth protected and Tomcat detects that really quick, therefore closes the connection. In an optional case, only few hundred kilobytes are transfered before HttpClient detects the premature end of transfer.
Tomcat in return responds with 401, `WWW-Authenticate: Negotiate` and the usual HTML error page:
```
<!doctype html><html lang="en"><head><title>HTTP Status 401 – Unauthorized</title><style type="text/css">body {font-family:Tahoma,Arial,sans-serif;} h1, h2, h3, b {color:white;background-color:#525D76;} h1 {font-size:22px;} h2 {font-size:16px;} h3 {font-size:14px;} p {font-size:12px;} a {color:black;} .line {height:1px;background-color:#525D76;border:none;}</style></head><body><h1>HTTP Status 401 – Unauthorized</h1></body></html>
```
I am using two connectors, one for plain, one for TLS. Both use APR via libtcnative. TLS uses OpenSSL via libtcntative too. I can provide logfiles if you like.
After 50 failures of auth, I send an authenticated request which succeeds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669143416
I'd appreciate the logs if you don't mind sharing them :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669069746
I am looking into this right now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669901514
Sorry, I didn't have a lot of time yesterday to debug this, I will figure it out today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-670040228
Does it work when you increase the timeout? How often does it occur?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-670053931
@ok2c When you have a moment, would you mind verifying the patch I've provided in #214?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669077627
Just tried off 1ca04d66a w/o your change first on Windows 10 with Zulu 13.0.4 commercial version. The backend is running Apache Tomcat 8.5.x on OpenJDK 8 on FreeBSD 12-STABLE. I was neither able to detect a change in behavior for both HTTP and HTTPS via proxy and VPN. Shall I retry on non-Windows? I can provide logs is required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak closed pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
carterkozak closed pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#discussion_r461643228
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnection.java
##########
@@ -157,8 +156,8 @@ public void sendRequestEntity(final ClassicHttpRequest request) throws HttpExcep
try (final OutputStream outStream = createContentOutputStream(
len, this.outbuffer, new OutputStream() {
- final boolean ssl = socketHolder.getSocket() instanceof SSLSocket;
final InputStream socketInputStream = socketHolder.getInputStream();
+ final boolean earlyResponseCheckRequiresRead = !(socketInputStream instanceof FileInputStream);
Review comment:
This really feels like a brittle approach on implementation details. Isn't there a better way for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak commented on a change in pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
carterkozak commented on a change in pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#discussion_r465043949
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnection.java
##########
@@ -157,8 +156,8 @@ public void sendRequestEntity(final ClassicHttpRequest request) throws HttpExcep
try (final OutputStream outStream = createContentOutputStream(
len, this.outbuffer, new OutputStream() {
- final boolean ssl = socketHolder.getSocket() instanceof SSLSocket;
final InputStream socketInputStream = socketHolder.getInputStream();
+ final boolean earlyResponseCheckRequiresRead = !(socketInputStream instanceof FileInputStream);
Review comment:
Hmm, this will fall back to the slow implementation when LoggingSocketHolder is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-670031635
> @ok2c What platform? I did not have any of these with Zulu and OpenJDK on Windows and FreeBSD.
Ubuntu Linux 2018.04 LTS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669091237
Moved the same code to anther box with 14.0.2+12-1 on FreeBSD 12-STABLE with the same backend on OpenSSL 1.1.1g, TLS 1.3 is negotiated. What now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org