You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Artem Harutyunyan <ar...@mesosphere.io> on 2015/10/18 04:43:59 UTC
Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468
Repository: mesos
Description
-------
Added '--parent' option and made apply-review.sh call apply-reviews.py.
Diffs
-----
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103080
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38705, 38883, 39410, 39420]
All tests passed.
- Mesos ReviewBot
On Oct. 18, 2015, 10:33 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2015, 10:33 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103082
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 十月 18, 2015, 10:33 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated 十月 18, 2015, 10:33 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103388
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38705, 38883, 39410, 39420]
All tests passed.
- Mesos ReviewBot
On Oct. 21, 2015, 6:04 a.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 6:04 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
> On Oct. 22, 2015, 11:48 p.m., Marco Massenzio wrote:
> > Looks good - I'd still be happier with "Better Bash" :) would you mind "fixing" apply-review.sh?
> >
> > Thanks!
Done.
- Artem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103729
-----------------------------------------------------------
On Oct. 22, 2015, 11:58 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 11:58 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103729
-----------------------------------------------------------
Ship it!
Looks good - I'd still be happier with "Better Bash" :) would you mind "fixing" apply-review.sh?
Thanks!
- Marco Massenzio
On Oct. 23, 2015, 6:19 a.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 6:19 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103742
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38705, 38883, 39410, 39420]
All tests passed.
- Mesos ReviewBot
On Oct. 23, 2015, 6:58 a.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 6:58 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review104549
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38705, 38883, 39410, 39420]
All tests passed.
- Mesos ReviewBot
On Oct. 30, 2015, 8:56 a.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2015, 8:56 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review105662
-----------------------------------------------------------
Bad patch!
Reviews applied: [38705, 38883, 39410, 39420]
Failed command: ./support/apply-review.sh -n -r 39420
Error:
2015-11-09 09:03:57 URL:https://reviews.apache.org/r/39420/diff/raw/ [4921/4921] -> "39420.patch" [1]
error: patch failed: support/apply-review.sh:1
error: support/apply-review.sh: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Nov. 9, 2015, 8:30 a.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 8:30 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--chain' option to apply-reviews.py.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review105941
-----------------------------------------------------------
Ship it!
support/apply-reviews.py (line 320)
<https://reviews.apache.org/r/39420/#comment164641>
not always right? want to update this comment?
support/apply-reviews.py (line 321)
<https://reviews.apache.org/r/39420/#comment164640>
pull this comment inside?
- Vinod Kone
On Nov. 10, 2015, 8:03 a.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 8:03 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3859
> https://issues.apache.org/jira/browse/MESOS-3859
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--chain' option to apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - With and without '-c'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--chain' option to apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Nov. 14, 2015, 9:04 a.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Bugs: MESOS-3859
https://issues.apache.org/jira/browse/MESOS-3859
Repository: mesos
Description
-------
Added '--chain' option to apply-reviews.py.
Diffs (updated)
-----
support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- With and without '-c'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--chain' option to apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Nov. 12, 2015, 10:04 a.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Bugs: MESOS-3859
https://issues.apache.org/jira/browse/MESOS-3859
Repository: mesos
Description
-------
Added '--chain' option to apply-reviews.py.
Diffs (updated)
-----
support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- With and without '-c'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--chain' option to apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Nov. 12, 2015, 2:52 a.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-3859
https://issues.apache.org/jira/browse/MESOS-3859
Repository: mesos
Description
-------
Added '--chain' option to apply-reviews.py.
Diffs (updated)
-----
support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- With and without '-c'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--chain' option to apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Nov. 11, 2015, 2:08 a.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Bugs: MESOS-3859
https://issues.apache.org/jira/browse/MESOS-3859
Repository: mesos
Description
-------
Added '--chain' option to apply-reviews.py.
Diffs (updated)
-----
support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- With and without '-c'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--chain' option to apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Nov. 10, 2015, 12:03 a.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Summary (updated)
-----------------
Added '--chain' option to apply-reviews.py.
Bugs: MESOS-3859
https://issues.apache.org/jira/browse/MESOS-3859
Repository: mesos
Description
-------
Added '--chain' option to apply-reviews.py.
Diffs
-----
support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- With and without '-c'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Nov. 9, 2015, 11:57 p.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Bugs: MESOS-3859
https://issues.apache.org/jira/browse/MESOS-3859
Repository: mesos
Description
-------
Added '--chain' option to apply-reviews.py.
Diffs
-----
support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
Diff: https://reviews.apache.org/r/39420/diff/
Testing (updated)
-------
Tested with python 2.7.
- With and without '-c'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Nov. 9, 2015, 11:56 p.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Changes
-------
Addressed comments.
Bugs: MESOS-3859
https://issues.apache.org/jira/browse/MESOS-3859
Repository: mesos
Description (updated)
-------
Added '--chain' option to apply-reviews.py.
Diffs (updated)
-----
support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
Diff: https://reviews.apache.org/r/39420/diff/
Testing (updated)
-------
Tested with python 2.7.
- with and without '-c'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--chain' option to apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
> On Nov. 9, 2015, 2:09 p.m., Vinod Kone wrote:
> > Can you split this into 2 reviews? one adding --parent option and the other updating apply-review.sh to use apply-reviews.py?
Done.
- Artem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review105755
-----------------------------------------------------------
On Nov. 10, 2015, 12:03 a.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 12:03 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3859
> https://issues.apache.org/jira/browse/MESOS-3859
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--chain' option to apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - With and without '-c'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review105755
-----------------------------------------------------------
Can you split this into 2 reviews? one adding --parent option and the other updating apply-review.sh to use apply-reviews.py?
- Vinod Kone
On Nov. 9, 2015, 3:31 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 3:31 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3859
> https://issues.apache.org/jira/browse/MESOS-3859
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review105685
-----------------------------------------------------------
Bad patch!
Reviews applied: [38705, 38883, 39410]
Failed command: ./support/apply-review.sh -n -r 39410
Error:
2015-11-09 15:41:06 URL:https://reviews.apache.org/r/39410/diff/raw/ [13112/13112] -> "39410.patch" [1]
error: support/apply-reviews.py: does not exist in index
Failed to apply patch
- Mesos ReviewBot
On Nov. 9, 2015, 3:31 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 3:31 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3859
> https://issues.apache.org/jira/browse/MESOS-3859
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Nov. 9, 2015, 7:31 a.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Bugs: MESOS-3859
https://issues.apache.org/jira/browse/MESOS-3859
Repository: mesos
Description
-------
Added '--parent' option and made apply-review.sh call apply-reviews.py.
Diffs
-----
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Nov. 9, 2015, 7:31 a.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468
Repository: mesos
Description
-------
Added '--parent' option and made apply-review.sh call apply-reviews.py.
Diffs (updated)
-----
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review105664
-----------------------------------------------------------
Bad patch!
Reviews applied: [38705, 38883, 39410, 39420]
Failed command: ./support/apply-review.sh -n -r 39420
Error:
2015-11-09 11:14:00 URL:https://reviews.apache.org/r/39420/diff/raw/ [4921/4921] -> "39420.patch" [1]
error: patch failed: support/apply-review.sh:1
error: support/apply-review.sh: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Nov. 9, 2015, 10:58 a.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 10:58 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Nov. 9, 2015, 2:58 a.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468
Repository: mesos
Description
-------
Added '--parent' option and made apply-review.sh call apply-reviews.py.
Diffs (updated)
-----
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Nov. 9, 2015, 12:30 a.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468
Repository: mesos
Description
-------
Added '--parent' option and made apply-review.sh call apply-reviews.py.
Diffs (updated)
-----
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review105179
-----------------------------------------------------------
Bad patch!
Reviews applied: [38705, 38883]
Failed command: ./support/apply-review.sh -n -r 38883
Error:
2015-11-05 00:02:53 URL:https://reviews.apache.org/r/38883/diff/raw/ [7705/7705] -> "38883.patch" [1]
error: patch failed: support/apply-reviews.py:1
error: support/apply-reviews.py: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Nov. 4, 2015, 11:01 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 11:01 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 3:01 p.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468
Repository: mesos
Description
-------
Added '--parent' option and made apply-review.sh call apply-reviews.py.
Diffs (updated)
-----
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 2:45 p.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468
Repository: mesos
Description
-------
Added '--parent' option and made apply-review.sh call apply-reviews.py.
Diffs (updated)
-----
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Oct. 30, 2015, 1:56 a.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468
Repository: mesos
Description
-------
Added '--parent' option and made apply-review.sh call apply-reviews.py.
Diffs (updated)
-----
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Oct. 28, 2015, 3:10 p.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468
Repository: mesos
Description
-------
Added '--parent' option and made apply-review.sh call apply-reviews.py.
Diffs (updated)
-----
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103779
-----------------------------------------------------------
Ship it!
Thanks for the "Better Bash" :)
- Marco Massenzio
On Oct. 23, 2015, 6:58 a.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 6:58 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Oct. 22, 2015, 11:58 p.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Changes
-------
More readable apply-review.sh.
Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468
Repository: mesos
Description
-------
Added '--parent' option and made apply-review.sh call apply-reviews.py.
Diffs (updated)
-----
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Oct. 22, 2015, 11:19 p.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468
Repository: mesos
Description
-------
Added '--parent' option and made apply-review.sh call apply-reviews.py.
Diffs (updated)
-----
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Oct. 20, 2015, 11:04 p.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468
Repository: mesos
Description
-------
Added '--parent' option and made apply-review.sh call apply-reviews.py.
Diffs (updated)
-----
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
> On Oct. 20, 2015, 2:55 p.m., Marco Massenzio wrote:
> > support/apply-review.sh, line 3
> > <https://reviews.apache.org/r/39420/diff/3/?file=1101523#file1101523line3>
> >
> > I really dislike this style of conditional running stuff in bash (it also violates Google's style, but that's another story :) )
> > ```
> > if [[ ! -f "support/apply-reviews.py" ]]; then
> > echo "..."
> > exit 1
> > fi
> >
> > python ./support/apply-reviews.py "$@"
> > ```
I asked this during one of the community syncs and folks thought that we should preserve `apply-review.sh` for at least a couple of releases. The [-f ..] here is just a guard to make sure that the script is ran from the root of the source tree.
- Artem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103312
-----------------------------------------------------------
On Oct. 20, 2015, 11:04 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2015, 11:04 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103312
-----------------------------------------------------------
Ship it!
I guess you want to retain apply-reviews.sh for backward compatibility; however, it can be entirely retired by making apply-reviews.py executable (`chmod a+x`) and adding a shebang at the top:
```
#!/usr/bin/env python
```
support/apply-review.sh (line 3)
<https://reviews.apache.org/r/39420/#comment161291>
I really dislike this style of conditional running stuff in bash (it also violates Google's style, but that's another story :) )
```
if [[ ! -f "support/apply-reviews.py" ]]; then
echo "..."
exit 1
fi
python ./support/apply-reviews.py "$@"
```
support/apply-reviews.py (lines 267 - 272)
<https://reviews.apache.org/r/39420/#comment161292>
did you introduce leading tabs?
(it may very well be a RB artifact, difficult to tell)
- Marco Massenzio
On Oct. 20, 2015, 7:45 a.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2015, 7:45 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103234
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38705, 38883, 39410, 39420]
All tests passed.
- Mesos ReviewBot
On Oct. 20, 2015, 7:45 a.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2015, 7:45 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Oct. 20, 2015, 12:45 a.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468
Repository: mesos
Description
-------
Added '--parent' option and made apply-review.sh call apply-reviews.py.
Diffs (updated)
-----
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
-----------------------------------------------------------
(Updated Oct. 18, 2015, 3:33 p.m.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
Changes
-------
space/tab cleanup.
Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468
Repository: mesos
Description
-------
Added '--parent' option and made apply-review.sh call apply-reviews.py.
Diffs (updated)
-----
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
-------
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103049
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38705, 38883, 39410, 39420]
All tests passed.
- Mesos ReviewBot
On Oct. 18, 2015, 2:43 a.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2015, 2:43 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
> On Oct. 18, 2015, 7:14 a.m., Guangya Liu wrote:
> > Why not make this as a default option? I think that we need to apply the whole chain of patch for development, thoughts? Thanks.
It will break the verification script that ASF Jenkins currently uses.
- Artem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103056
-----------------------------------------------------------
On Oct. 17, 2015, 7:43 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2015, 7:43 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
> On Oct. 18, 2015, 7:14 a.m., Guangya Liu wrote:
> > support/apply-reviews.py, lines 272-274
> > <https://reviews.apache.org/r/39420/diff/1/?file=1100573#file1100573line272>
> >
> > Tab or blank space? If Tab, we should switch to blank space
Thanks for spotting this! My editor was sneaking tabs in this whole time. I went back and cleaned previous reviews as well.
- Artem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103056
-----------------------------------------------------------
On Oct. 18, 2015, 3:33 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2015, 3:33 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 39420: Added '--parent' option and made
apply-review.sh call apply-reviews.py.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103056
-----------------------------------------------------------
Why not make this as a default option? I think that we need to apply the whole chain of patch for development, thoughts? Thanks.
support/apply-reviews.py (lines 271 - 273)
<https://reviews.apache.org/r/39420/#comment160903>
Tab or blank space? If Tab, we should switch to blank space
- Guangya Liu
On 十月 18, 2015, 2:43 a.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
>
> (Updated 十月 18, 2015, 2:43 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
> support/apply-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39420/diff/
>
>
> Testing
> -------
>
> Tested with python 2.7.
>
> - with and without '-p'.
> - Tested reviews with and without parents.
>
>
> Thanks,
>
> Artem Harutyunyan
>
>