You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/02 23:27:44 UTC
[GitHub] [spark] maropu commented on a change in pull request #29608: [SPARK-32762][SQL][TEST] Enhance the verification of ExpressionsSchemaSuite to sql-expression-schema.md
maropu commented on a change in pull request #29608:
URL: https://github.com/apache/spark/pull/29608#discussion_r482597152
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##########
@@ -152,23 +152,37 @@ class ExpressionsSchemaSuite extends QueryTest with SharedSparkSession {
val outputSize = outputs.size
val headerSize = header.size
- val expectedOutputs: Seq[QueryOutput] = {
+ val (expectedMissingExamples, expectedOutputs) = {
val expectedGoldenOutput = fileToString(resultFile)
val lines = expectedGoldenOutput.split("\n")
val expectedSize = lines.size
assert(expectedSize == outputSize + headerSize,
s"Expected $expectedSize blocks in result file but got " +
- s"${outputSize + headerSize}. Try regenerate the result files.")
+ s"${outputSize + headerSize}. Try regenerating the result files.")
- Seq.tabulate(outputSize) { i =>
+ val numberOfQueries = lines(2).split(":")(1).trim.toInt
+ val numberOfMissingExample = lines(3).split(":")(1).trim.toInt
Review comment:
nit: `Example` -> `Examples`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org