You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Krisztian Kasa <kk...@hortonworks.com> on 2019/07/02 09:08:00 UTC
Review Request 70988: HIVE-21941
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70988/
-----------------------------------------------------------
Review request for hive, Laszlo Bodor, Zoltan Haindrich, and Miklos Gergely.
Bugs: HIVE-21941
https://issues.apache.org/jira/browse/HIVE-21941
Repository: hive-git
Description
-------
Use checkstyle ruleset in Pre Upgrade Tool project
Diffs
-----
upgrade-acid/pom.xml 39f36dbe66
Diff: https://reviews.apache.org/r/70988/diff/1/
Testing
-------
```
mvn checkstyle:checkstyle
less target/checkstyle-result.xml
```
```
...
<error line="360" severity="warning" message="Line is longer than 120 characters (found 126)." source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/>
...
```
Thanks,
Krisztian Kasa
Re: Review Request 70988: HIVE-21941
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70988/#review216307
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On July 2, 2019, 9:08 a.m., Krisztian Kasa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70988/
> -----------------------------------------------------------
>
> (Updated July 2, 2019, 9:08 a.m.)
>
>
> Review request for hive, Laszlo Bodor, Zoltan Haindrich, and Miklos Gergely.
>
>
> Bugs: HIVE-21941
> https://issues.apache.org/jira/browse/HIVE-21941
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Use checkstyle ruleset in Pre Upgrade Tool project
>
>
> Diffs
> -----
>
> upgrade-acid/pom.xml 39f36dbe66
>
>
> Diff: https://reviews.apache.org/r/70988/diff/1/
>
>
> Testing
> -------
>
> ```
> mvn checkstyle:checkstyle
> less target/checkstyle-result.xml
> ```
> ```
> ...
> <error line="360" severity="warning" message="Line is longer than 120 characters (found 126)." source="com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck"/>
> ...
> ```
>
>
> Thanks,
>
> Krisztian Kasa
>
>