You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/07 21:51:29 UTC
[GitHub] [beam] ibzib commented on a change in pull request #16158: [BEAM-13294] Widen key schema for all keys before use
ibzib commented on a change in pull request #16158:
URL: https://github.com/apache/beam/pull/16158#discussion_r764382517
##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/transforms/JoinTest.java
##########
@@ -176,6 +182,68 @@ public void testInnerJoinDifferentKeys() {
pipeline.run();
}
+ @Test
+ @Category(NeedsRunner.class)
+ public void testInnerJoinDifferentKeysNullable2() {
+ List<Row> pc1Rows =
+ Lists.newArrayList(
Review comment:
Nit: prefer `ImmutableList.of(...)`.
##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/transforms/JoinTest.java
##########
@@ -176,6 +182,68 @@ public void testInnerJoinDifferentKeys() {
pipeline.run();
}
+ @Test
+ @Category(NeedsRunner.class)
+ public void testInnerJoinDifferentKeysNullable2() {
+ List<Row> pc1Rows =
+ Lists.newArrayList(
+ Row.withSchema(CG_SCHEMA_1).addValues("user1", 1, "us").build(),
+ Row.withSchema(CG_SCHEMA_1).addValues("user1", 2, "us").build(),
+ Row.withSchema(CG_SCHEMA_1).addValues("user1", 3, "il").build(),
+ Row.withSchema(CG_SCHEMA_1).addValues("user1", 4, "il").build(),
+ Row.withSchema(CG_SCHEMA_1).addValues("user2", 5, "fr").build(),
+ Row.withSchema(CG_SCHEMA_1).addValues("user2", 6, "fr").build(),
+ Row.withSchema(CG_SCHEMA_1).addValues("user2", 7, "ar").build(),
+ Row.withSchema(CG_SCHEMA_1).addValues("user2", 8, "ar").build(),
+ Row.withSchema(CG_SCHEMA_1).addValues("user3", 8, "ar").build());
+ List<Row> pc2Rows =
+ Lists.newArrayList(
+ Row.withSchema(CG_SCHEMA_2N).addValues("user1", 9, "us").build(),
Review comment:
Should we test rows with null values as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org