You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2020/11/17 07:33:48 UTC

[GitHub] [royale-asjs] yishayw opened a new issue #937: Skin Not Being Sized Correctly

yishayw opened a new issue #937:
URL: https://github.com/apache/royale-asjs/issues/937


   In this application
   
   ```
   <?xml version="1.0" encoding="utf-8"?>
   <s:Application 
   	xmlns:fx="http://ns.adobe.com/mxml/2009"
   	xmlns:s="library://ns.apache.org/royale/spark"
   	xmlns:comp="components.*"
   	width="100%"
   	height="100%"
   	>
   	<comp:CollapsiblePanel/>
   </s:Application>
   
   ```
   
   where Collapsible Panel is
   
   ```
   <?xml version="1.0" encoding="utf-8"?>
   <s:SkinnableContainer 
   	xmlns:fx="http://ns.adobe.com/mxml/2009"
   	xmlns:s="library://ns.apache.org/royale/spark"
   	skinClass="components.CollapsiblePanelSkin"
   	width="100%"
   	>
   </s:SkinnableContainer>
   
   ```
   
   And CollapsiblePanelSkin is
   
   ```
   <?xml version="1.0" encoding="utf-8"?>
   <s:SparkSkin
   	xmlns:fx="http://ns.adobe.com/mxml/2009"
   	xmlns:s="library://ns.apache.org/royale/spark"
   	>
   	<fx:Metadata>
   		[HostComponent("components.CollapsiblePanel")]
   	</fx:Metadata>
   	<s:Button left="0" right="0" height="24" />
   	<s:Group id="contentGroup" width="100%" height="100%"/>
   </s:SparkSkin>
   
   ```
   
   The button should be spread to the width of the screen (as it does in Flex). Instead, it's got a 70px width.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] estanglerbm commented on issue #937: Skin Not Being Sized Correctly

Posted by GitBox <gi...@apache.org>.
estanglerbm commented on issue #937:
URL: https://github.com/apache/royale-asjs/issues/937#issuecomment-946484776


   Actually, already works in develop.  (PR #1135 changes the implementation, though, to try to make things better in other situations, too.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] estanglerbm commented on issue #937: Skin Not Being Sized Correctly

Posted by GitBox <gi...@apache.org>.
estanglerbm commented on issue #937:
URL: https://github.com/apache/royale-asjs/issues/937#issuecomment-886187243


   This seems to be fixed, at least with PR #1135 and other previous PRs (don't know which one fixed it;  probably commit d195814211ad3ada0f00be42cce0491419f8d032).  PR #1135 is specifically designed to resize skins in all cases (it uses "displayView" to be either contentView or skin, and resizes that appropriately).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] yishayw commented on issue #937: Skin Not Being Sized Correctly

Posted by GitBox <gi...@apache.org>.
yishayw commented on issue #937:
URL: https://github.com/apache/royale-asjs/issues/937#issuecomment-945699121


   Works in ChildResize


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] yishayw commented on issue #937: Skin Not Being Sized Correctly

Posted by GitBox <gi...@apache.org>.
yishayw commented on issue #937:
URL: https://github.com/apache/royale-asjs/issues/937#issuecomment-728749700


   In main app replacing
   
   	`<comp:CollapsiblePanel/>`
   
   With
   
   	`<comp:CollapsiblePanel height="100%"/>`
   
   Fixes the problem.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org