You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/24 09:51:32 UTC
[GitHub] [dolphinscheduler] KEN-LJQ opened a new issue, #13272: [Bug] [Master] resume failure processInstance state remain failure
KEN-LJQ opened a new issue, #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Workflow process instance resume from failure state, and all task run success actully, but task instance and process intance remain failure. And when you click resume again, all switch to success.
Checking task log, the task has submit and run success when resume.
Checking database table `t_ds_task_instance`. There two record, old one state is failure, and new one is success. Which make sense.
Since task is success, why ds judge it faliure and show failure on ui. Digging the ui http query, we found that it query both two record and return it, because of the `flag`.
And I don't know what happen, thx for help.
### What you expected to happen
both task instance and process instance should change to success
### How to reproduce
1. create a workflow with task which suppose to run fail, and configure retry 3 times
2. run workflow. task instance state should be failure and waiting to retry, and process instance stay running
3. click stop. task instance state should be failure and process instance state should be stoped
4. modify task make it will run success
5. click resume
6. task has submit and run. but when it finish, both task and process instance state change to failure
7. click resume again
8. both task and process change to success
### Anything else
we are on v2.0.7
### Version
2.0.x
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] KEN-LJQ commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
KEN-LJQ commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1384793428
@SbloodyS @JinyLeeChina let me test it according my step again, what is your version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] KEN-LJQ commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
KEN-LJQ commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1364502641
kind of associate with this issue https://github.com/apache/dolphinscheduler/issues/10673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] KEN-LJQ commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
KEN-LJQ commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1384764409
Hi, @JinyLeeChina thanks for your replay. And yes, two record is right, but I has a question about is that normal this task and process judge as failure just because there's a failure record? But the truth is new one is success, should we judge this task as success?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1384792251
Hi @KEN-LJQ , I tested according to your steps, but the result of step 6 is different from yours. My result is task instance success and process instance fail, and task and process instance should be success
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] KEN-LJQ commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
KEN-LJQ commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1384876485
@JinyLeeChina I try with 2.0.8-prepare, still can reproduce, may be you missing config retry?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1384761581
Hi @KEN-LJQ , modify the task in step 4, the task version add 1, and then click resume, the running task is not initial task. I think task_instance has two record, old one state is failure, and new one is success, that is normal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1384781145
Hi @KEN-LJQ , In step 4 `modify task make it will run success`, did you update the definition of process instance 33? If not, then resume the process instance will result in the same failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1364500457
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1384762273
<img width="775" alt="image" src="https://user-images.githubusercontent.com/42576980/212797237-3a73d07a-7f14-4e7a-a118-925fb5e46b53.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] KEN-LJQ commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
KEN-LJQ commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1384782240
@SbloodyS , yes, I modify it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1385471635
> Maybe I missing some steps, I will test it again later to figure out why. But as your results,process instance becomes failures suppose to be wrong result?
Yes, I will confirm the cause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1364500430
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Workflow process instance resume from failure state, and all task run success actully, but task instance and process intance remain failure. And when you click resume again, all switch to success.
Checking task log, the task has submit and run success when resume.
Checking database table `t_ds_task_instance`. There two record, old one state is failure, and new one is success. Which make sense.
Since task is success, why ds judge it faliure and show failure on ui. Digging the ui http query, we found that it query both two record and return it, because of the `flag`.
And I don't know what happen, thx for help.
### What you expected to happen
both task instance and process instance should change to success
### How to reproduce
1. create a workflow with task which suppose to run fail, and configure retry 3 times
2. run workflow. task instance state should be failure and waiting to retry, and process instance stay running
3. click stop. task instance state should be failure and process instance state should be stoped
4. modify task make it will run success
5. click resume
6. task has submit and run. but when it finish, both task and process instance state change to failure
7. click resume again
8. both task and process change to success
### Anything else
we are on v2.0.7
### Version
2.0.x
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina closed issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
JinyLeeChina closed issue #13272: [Bug] [Master] resume failure processInstance state remain failure
URL: https://github.com/apache/dolphinscheduler/issues/13272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1385381681
No, I config retry, however, it cannot reproduce the failure of process and task instances. The result is that the process instance fails and the task instance succeeds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1386742816
> Maybe I missing some steps, I will test it again later to figure out why. But as your results,process instance becomes failures suppose to be wrong result?
I submit a PR to fix it, @KEN-LJQ @SbloodyS please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1384787251
I can not reproduce this issue according to your steps with shell task in the 2.0.5-release. Are there any important steps missing? @KEN-LJQ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1384795954
I tested it use 2.0.7 and 2.0.8-prepare, I suggest you use the 2.0.8-prepare to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] KEN-LJQ commented on issue #13272: [Bug] [Master] resume failure processInstance state remain failure
Posted by GitBox <gi...@apache.org>.
KEN-LJQ commented on issue #13272:
URL: https://github.com/apache/dolphinscheduler/issues/13272#issuecomment-1385398427
Maybe I missing some steps, I will test it again later to figure out why. But as your results,process instance becomes failures suppose to be wrong result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org