You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by zs...@apache.org on 2008/12/09 00:24:19 UTC

svn commit: r724550 - in /hadoop/hive/trunk: ./ ql/src/java/org/apache/hadoop/hive/ql/parse/ ql/src/test/queries/clientnegative/ ql/src/test/results/clientnegative/ ql/src/test/results/compiler/errors/

Author: zshao
Date: Mon Dec  8 15:24:17 2008
New Revision: 724550

URL: http://svn.apache.org/viewvc?rev=724550&view=rev
Log:
HIVE-95. Improve cli error messages by lowering backtracking to 1. (Pete Wyckoff through zshao)

Added:
    hadoop/hive/trunk/ql/src/test/queries/clientnegative/invalid_create_tbl2.q
    hadoop/hive/trunk/ql/src/test/results/clientnegative/invalid_create_tbl2.q.out
Modified:
    hadoop/hive/trunk/CHANGES.txt
    hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
    hadoop/hive/trunk/ql/src/test/results/compiler/errors/wrong_distinct2.q.out

Modified: hadoop/hive/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/CHANGES.txt?rev=724550&r1=724549&r2=724550&view=diff
==============================================================================
--- hadoop/hive/trunk/CHANGES.txt (original)
+++ hadoop/hive/trunk/CHANGES.txt Mon Dec  8 15:24:17 2008
@@ -20,6 +20,9 @@
 
   IMPROVEMENTS
 
+    HIVE-95. Improve cli error messages by lowering backtracking to 1.
+    (Pete Wyckoff through zshao)
+
     HIVE-102. Refactor DDLTask. (Johan Oskarsson through zshao)
 
     HIVE-85. New compression options for Hive. (Joydeep Sarma through zshao)

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g?rev=724550&r1=724549&r2=724550&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g Mon Dec  8 15:24:17 2008
@@ -5,6 +5,7 @@
 output=AST;
 ASTLabelType=CommonTree;
 backtrack=true;
+k=1;
 }
  
 tokens {

Added: hadoop/hive/trunk/ql/src/test/queries/clientnegative/invalid_create_tbl2.q
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/test/queries/clientnegative/invalid_create_tbl2.q?rev=724550&view=auto
==============================================================================
--- hadoop/hive/trunk/ql/src/test/queries/clientnegative/invalid_create_tbl2.q (added)
+++ hadoop/hive/trunk/ql/src/test/queries/clientnegative/invalid_create_tbl2.q Mon Dec  8 15:24:17 2008
@@ -0,0 +1,3 @@
+create tabl tmp_zshao_22 (id int, name strin;
+
+

Added: hadoop/hive/trunk/ql/src/test/results/clientnegative/invalid_create_tbl2.q.out
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/test/results/clientnegative/invalid_create_tbl2.q.out?rev=724550&view=auto
==============================================================================
--- hadoop/hive/trunk/ql/src/test/results/clientnegative/invalid_create_tbl2.q.out (added)
+++ hadoop/hive/trunk/ql/src/test/results/clientnegative/invalid_create_tbl2.q.out Mon Dec  8 15:24:17 2008
@@ -0,0 +1,2 @@
+FAILED: Parse Error: line 1:7 mismatched input 'tabl' expecting KW_TEMPORARY
+

Modified: hadoop/hive/trunk/ql/src/test/results/compiler/errors/wrong_distinct2.q.out
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/test/results/compiler/errors/wrong_distinct2.q.out?rev=724550&r1=724549&r2=724550&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/test/results/compiler/errors/wrong_distinct2.q.out (original)
+++ hadoop/hive/trunk/ql/src/test/results/compiler/errors/wrong_distinct2.q.out Mon Dec  8 15:24:17 2008
@@ -1 +1 @@
-Parse Error: line 2:45 cannot recognize input 'DISTINCT'
+Parse Error: line 2:29 cannot recognize input 'SELECT'