changing collections exceptions

[Noel Grandin <no...@gmail.com>]

Hi

I like nice descriptive text in my stack traces, the more the merrier.
Very useful when debugging log files.

I'd like to update the various IllegalStateExceptions in pivot/core to
be more descriptive about the problematic parameters.

Any objections?

-- Noel.

Re: changing collections exceptions

[Todd Volkert <tv...@gmail.com>]

I lean on the side of more descriptive error messages - at this point, our
code base is large enough that the impact it would have on jar sizes should
be a drop in the bucket.

-T

On Fri, Nov 13, 2009 at 4:07 AM, Greg Brown <gk...@mac.com> wrote:

> >I like nice descriptive text in my stack traces, the more the merrier.
> >Very useful when debugging log files.
> >
> >I'd like to update the various IllegalStateExceptions in pivot/core to
> >be more descriptive about the problematic parameters.
> >
> >Any objections?
>
> Yes and no. While more descriptive error messages can be more helpful, they
> can also increase overall JAR size. Use your best judgement to determine
> when more or less detail might be appropriate.
>
>

Re: changing collections exceptions

[Greg Brown <gk...@mac.com>]

>I like nice descriptive text in my stack traces, the more the merrier.
>Very useful when debugging log files.
>
>I'd like to update the various IllegalStateExceptions in pivot/core to
>be more descriptive about the problematic parameters.
>
>Any objections?

Yes and no. While more descriptive error messages can be more helpful, they can also increase overall JAR size. Use your best judgement to determine when more or less detail might be appropriate.

Re: changing collections exceptions

[Sandro Martini <sa...@gmail.com>]

Hi Noel,

> I like nice descriptive text in my stack traces, the more the merrier.
> Very useful when debugging log files.
I agree with you, and in mine usually I add also some values that
generates the exception, like "The given value of ... is wrong"

> Any objections?
>From me, no.

Bye