[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

[GitBox <gi...@apache.org>]

uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r804516322



##########
File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java
##########
@@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir) throws IOException {
    * An IO operation with a single input.
    *
    * @see java.util.function.Consumer
+   * @deprecated was replaced by {@link org.apache.lucene.util.IOConsumer}.
    */
   @FunctionalInterface
+  @Deprecated(forRemoval = true, since = "9.1")
   public interface IOConsumer<T> {

Review comment:
       Hi this is not fully backwards compatible.
   
   I'd just declare this as:
   ```java
   public interface IOConsumer<T> extends org.apache.lucene.IOConsumer {}
   ```
   
   This allows users to pass instances of this deprecated interface to above methods, as those implementations are assignment-compatible.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org