[GitHub] [jmeter] milamberspace commented on a diff in pull request #5812: Bug #5807 - Fix an ArrayIndexOutOfBoundsException on HTTP parameters …

["milamberspace (via GitHub)" <gi...@apache.org>]

milamberspace commented on code in PR #5812:
URL: https://github.com/apache/jmeter/pull/5812#discussion_r1174554483


##########
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java:
##########
@@ -316,9 +322,10 @@ public static Map<String, String[]> getQueryMap(String query) {
                 System.arraycopy(known, 0, tmp, 0, known.length);
                 known = tmp;
             }
-            map.put(name, known);
+            if (validNameAndValue) {

Review Comment:
   No sure, "known" variable is define at line 315, and test if null just after.
   the block 
              " if (validNameAndValue) {
                   map.put(name, known);
               }"
   seems at the good place (line 325)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org