You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/02/06 02:26:25 UTC

Re: Review Request 43258: Modified agent to get container status from containerizer.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43258/
-----------------------------------------------------------

(Updated Feb. 6, 2016, 1:26 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4490
    https://issues.apache.org/jira/browse/MESOS-4490


Repository: mesos


Description
-------

Modified agent to get container status from containerizer.


Diffs (updated)
-----

  src/slave/slave.hpp 632640293f14fb97aea6d7dd2c462c1f604638fb 
  src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f 

Diff: https://reviews.apache.org/r/43258/diff/


Testing
-------

make and make check


Thanks,

Avinash sridharan

Re: Review Request 43258: Modified agent to get container status from containerizer.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43258/#review118125
-----------------------------------------------------------




src/slave/slave.cpp (lines 3228 - 3234)
<https://reviews.apache.org/r/43258/#comment179368>

    I think that the current format is right, why update?
    
    If you want to update, it should be the following, but I think there is no need to update here.
        _statusUpdate(
            None(), <<<<<
            update,
            pid,
            executor->id,
            executor->containerId,
            executor->checkpoint);


- Guangya Liu


On 二月 6, 2016, 1:26 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43258/
> -----------------------------------------------------------
> 
> (Updated 二月 6, 2016, 1:26 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4490
>     https://issues.apache.org/jira/browse/MESOS-4490
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modified agent to get container status from containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 632640293f14fb97aea6d7dd2c462c1f604638fb 
>   src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f 
> 
> Diff: https://reviews.apache.org/r/43258/diff/
> 
> 
> Testing
> -------
> 
> make and make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>