[GitHub] [cassandra] dcapwell commented on a change in pull request #1301: Cassandra 17116

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #1301:
URL: https://github.com/apache/cassandra/pull/1301#discussion_r796906632



##########
File path: src/java/org/apache/cassandra/net/AsyncStreamingInputPlus.java
##########
@@ -115,7 +115,8 @@ protected void reBuffer() throws ClosedChannelException, InputTimeoutException
         if (queue.isEmpty())
             channel.read();
 
-        currentBuf.release();
+        if (currentBuf != null)

Review comment:
       > is there any case where we don't immediately call close()
   
   don't know
   
   > and not throwing a runtime exception if that happens is actually the opposite of what we want...
   
   fail, keeping it NPE does help




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org