[GitHub] [fluo] kpm1985 commented on issue #1088: Use LeaderLatch to determine if oracle exists

[GitBox <gi...@apache.org>]

kpm1985 commented on issue #1088: Use LeaderLatch to determine if oracle exists
URL: https://github.com/apache/fluo/pull/1088#issuecomment-596143707
 
 
   Hello,
   
   Ive been out for a while with health issues sapping energy but saw this.
   
   Keith should remember a very similar race condition we tracked to Curator.
   
   When we changed the recipe it fixed the race condition. It should be
   documented on GitHub.
   
   
   
   
   
   On Fri, Mar 6, 2020, 7:01 PM Keith Turner <no...@github.com> wrote:
   
   > *@keith-turner* commented on this pull request.
   > ------------------------------
   >
   > In
   > modules/core/src/main/java/org/apache/fluo/core/client/FluoAdminImpl.java
   > <https://github.com/apache/fluo/pull/1088#discussion_r389191104>:
   >
   > >    }
   >
   >    public boolean oracleExists() {
   >      return oracleExists(getAppCurator());
   >    }
   >
   > -  public int numOracles() {
   > -    CuratorFramework curator = getAppCurator();
   > -    if (oracleExists(curator)) {
   > -      try {
   > +  public static int numOracles(CuratorFramework curator) {
   > +    int numOracles = 0;
   > +    try {
   > +      if (curator.checkExists().forPath(ZookeeperPath.ORACLE_SERVER) != null) {
   >
   > @jkosh44 <https://github.com/jkosh44> I would be happy to open an issue
   > for numWorkers unless you are interested in doing that
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/fluo/pull/1088?email_source=notifications&email_token=AHED4LFZ7JFLRWDNPMEE2J3RGGA2VA5CNFSM4LB5OYW2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCYMDF4Q#discussion_r389191104>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AHED4LGI2RPTAHTAP5UVDFTRGGA2VANCNFSM4LB5OYWQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services