You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/03/10 00:42:14 UTC
[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6338
Change subject: IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links
......................................................................
IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links
This change primarily sets up the infrastructure in the
keydefs file to allow shortening and genericizing
cross-doc links within the Impala library.
Many links to CDH-related pages such as cdh_*.xml
and cm_*.xml will be replaced by generic plain text.
Most of that will be in the next phase.
For phase 1, you can verify that things are working by
viewing the HTML output pages:
impala_new_features.html
impala_perf_hdfs_caching.html
and doublechecking that at the spots where formerly was a link to
a CDH page describing HDFS caching, now there is only the plain text
phrase: "see the documentation for HDFS caching".
Blanking out all the Cloudera doc links (in the next
phase) will remove many instances of www.cloudera.com
that appear both in the doc source and in the HTML output.
Change-Id: I8ddb3d7f0a398e70a0f741410bc6b1a309bd1686
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_new_features.xml
M docs/topics/impala_perf_hdfs_caching.xml
3 files changed, 377 insertions(+), 126 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/6338/1
--
To view, visit http://gerrit.cloudera.org:8080/6338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ddb3d7f0a398e70a0f741410bc6b1a309bd1686
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links
......................................................................
IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links
This change primarily sets up the infrastructure in the
keydefs file to allow shortening and genericizing
cross-doc links within the Impala library.
Many links to CDH-related pages such as cdh_*.xml
and cm_*.xml will be replaced by generic plain text.
Most of that will be in the next phase.
For phase 1, you can verify that things are working by
viewing the HTML output pages:
impala_new_features.html
impala_perf_hdfs_caching.html
and doublechecking that at the spots where formerly was a link to
a CDH page describing HDFS caching, now there is only the plain text
phrase: "see the documentation for HDFS caching".
Blanking out all the Cloudera doc links (in the next
phase) will remove many instances of www.cloudera.com
that appear both in the doc source and in the HTML output.
Change-Id: I8ddb3d7f0a398e70a0f741410bc6b1a309bd1686
Reviewed-on: http://gerrit.cloudera.org:8080/6338
Reviewed-by: Laurel Hale <la...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_new_features.xml
M docs/topics/impala_perf_hdfs_caching.xml
3 files changed, 377 insertions(+), 126 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Laurel Hale: Looks good to me, but someone else must approve
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ddb3d7f0a398e70a0f741410bc6b1a309bd1686
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ddb3d7f0a398e70a0f741410bc6b1a309bd1686
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links
......................................................................
Patch Set 1: Code-Review+1
Builds cleanly and the cdh_ig_hdfs_caching token replaces beautifully in the built content. Looks good.
--
To view, visit http://gerrit.cloudera.org:8080/6338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ddb3d7f0a398e70a0f741410bc6b1a309bd1686
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ddb3d7f0a398e70a0f741410bc6b1a309bd1686
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Phase 1 of genericizing cloudera.com links
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/67/
--
To view, visit http://gerrit.cloudera.org:8080/6338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ddb3d7f0a398e70a0f741410bc6b1a309bd1686
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No