You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/18 10:49:33 UTC

[GitHub] [airflow] turbaszek commented on issue #12439: The operator GCS to BigQuery fails to download the schema because download is called with the wrong order of parameters.

turbaszek commented on issue #12439:
URL: https://github.com/apache/airflow/issues/12439#issuecomment-729598036


   > 3\. Change the signature of download method in the [gcs_hook](https://github.com/apache/airflow/blob/master/airflow/providers/google/cloud/hooks/gcs.py#L353-L361)  to be `def download(self, bucket_name, object_name, filename)` rather than `def dowload(self, object_name, bucket_name, filename)`
   
   I agree, however this will be breaking change


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org