You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Oleg Gorobets (JIRA)" <ji...@apache.org> on 2007/10/17 14:28:39 UTC

[jira] Created: (WW-2261) Add inheritance for SkipValidation annotation

Add inheritance for SkipValidation annotation
---------------------------------------------

                 Key: WW-2261
                 URL: https://issues.apache.org/struts/browse/WW-2261
             Project: Struts 2
          Issue Type: Improvement
          Components: Validation
    Affects Versions: 2.0.8
            Reporter: Oleg Gorobets


Add @Inherited annotation to allow to build effective action structure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WW-2261) Add inheritance for SkipValidation annotation

Posted by "Brad Cupit (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43604#action_43604 ] 

bradcupit edited comment on WW-2261 at 4/10/08 1:10 PM:
---------------------------------------------------------

I think the fix for this bug won't actually do anything.

The SkipValidation annotation can only be applied to methods, and the Inherited annotation only works when applied to annotations for classes.

>From the Inherited annotation's javadocs:
Note that this meta-annotation type has no effect if the annotated
type is used to annotate anything other than a class.

Meaning, if the annotation being marked as @Inherited (in this case, SkipValidation) is used on anything other than a class, it has no effect, but the compiler will enforce that SkipValidation only be used on methods (due to it's target type).

Therefore, adding @Inheritable to SkipValidation won't actually do anything.

I think perhaps WW-2587 would accomplish what the original submitter wants.

      was (Author: bradcupit):
    I think the fix for this bug won't actually do anything.

The SkipValidation annotation can only be applied to methods, and the Inherited annotation only works when applied to annotations for classes.

>From the Inherited annotation's javadocs:
Note that this meta-annotation type has no effect if the annotated
type is used to annotate anything other than a class.

Meaning, if the annotation being marked as @Inherited (in this case, SkipValidation) is used on anything other than a class, it has no effect, but the compiler will enforce that SkipValidation only be used on methods (due to it's target type).

Therefore, adding @Inheritable to SkipValidation won't actually do anything.

I think perhaps WW-2587 would accomplish what the user wants.
  
> Add inheritance for SkipValidation annotation
> ---------------------------------------------
>
>                 Key: WW-2261
>                 URL: https://issues.apache.org/struts/browse/WW-2261
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - CodeBehind
>    Affects Versions: 2.0.8
>            Reporter: Oleg Gorobets
>             Fix For: 2.1.4
>
>
> Add @Inherited annotation to allow to build effective action structure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WW-2261) Add inheritance for SkipValidation annotation

Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Musachy Barroso resolved WW-2261.
---------------------------------

    Resolution: Duplicate

> Add inheritance for SkipValidation annotation
> ---------------------------------------------
>
>                 Key: WW-2261
>                 URL: https://issues.apache.org/struts/browse/WW-2261
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - CodeBehind
>    Affects Versions: 2.0.8
>            Reporter: Oleg Gorobets
>             Fix For: 2.1.4
>
>
> Add @Inherited annotation to allow to build effective action structure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2261) Add inheritance for SkipValidation annotation

Posted by "Brad Cupit (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43604#action_43604 ] 

Brad Cupit commented on WW-2261:
--------------------------------

I think the fix for this bug won't actually do anything.

The SkipValidation annotation can only be applied to methods, and the Inherited annotation only works when applied to annotations for classes.

>From the Inherited annotation's javadocs:
Note that this meta-annotation type has no effect if the annotated
type is used to annotate anything other than a class.

Meaning, if the annotation being marked as @Inherited (in this case, SkipValidation) is used on anything other than a class, it has no effect, but the compiler will enforce that SkipValidation only be used on methods (due to it's target type).

Therefore, adding @Inheritable to SkipValidation won't actually do anything.

I think perhaps WW-2587 would accomplish what the user wants.

> Add inheritance for SkipValidation annotation
> ---------------------------------------------
>
>                 Key: WW-2261
>                 URL: https://issues.apache.org/struts/browse/WW-2261
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - CodeBehind
>    Affects Versions: 2.0.8
>            Reporter: Oleg Gorobets
>             Fix For: 2.1.4
>
>
> Add @Inherited annotation to allow to build effective action structure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.