You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/05 13:27:37 UTC
[GitHub] [druid] bolkedebruin opened a new pull request #9621: Add context
to AuthenticationResult [WIP]
bolkedebruin opened a new pull request #9621: Add context to AuthenticationResult [WIP]
URL: https://github.com/apache/druid/pull/9621
### Description
Looking for feedback.
Proper authorization needs to be context aware. Context like IP Address, Proxy addresses etc. This PR adds context obtained from the servlet request and adds this to the authenticationResult.
Note:
* At the moment I tried to stay away from adjusting AuthenticationResult as much as possible. Hence, it requires the "authenticator" to call enrichContext. Maybe we should consider doing the enrichment in AuthenticationResult
##### Key changed/added classes in this PR
* AuthenticationContextEnricher
cc @jon-wei @Fokko
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] lgtm-com[bot] commented on issue #9621: Add context to
AuthenticationResult [WIP]
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #9621: Add context to AuthenticationResult [WIP]
URL: https://github.com/apache/druid/pull/9621#issuecomment-609426018
This pull request **introduces 3 alerts** when merging 66ac801e348fe30fbfd703f7c1be9ae7bb8e99e8 into 2d999669333fc7bd344e5bec0d74f0fbcd916272 - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-bf524bddaea0cdb6f68a02cfab280b289fefd436)
**new alerts:**
* 2 for Dereferenced variable is always null
* 1 for Dereferenced variable may be null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org