[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1208: MINIFICPP-1678 Create PutUDP processor

[GitBox <gi...@apache.org>]

adamdebreceni commented on a change in pull request #1208:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1208#discussion_r779437831



##########
File path: libminifi/include/core/ProcessContext.h
##########
@@ -113,10 +113,13 @@ class ProcessContext : public controller::ControllerServiceLookup, public core::
   }
 
   template<typename T>
-  bool getProperty(const std::string &name, T &value) const {
+  std::enable_if_t<!std::is_convertible_v<T&, FlowFile&>, bool> getProperty(const std::string &name, T &value) const {

Review comment:
       I assume this changed to disambiguate it from the newly added overload, but since `Property`  and `std::string` are not interconvertible it is not necessary (even if they were `T` would be resolved to `std::shared_ptr<FlowFile>` and satisfy the non-convertible condition)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org