You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "vvcephei (via GitHub)" <gi...@apache.org> on 2023/05/05 16:09:15 UTC

[GitHub] [kafka] vvcephei commented on a diff in pull request #13633: KAFKA-14839: Exclude protected variable from JavaDocs

vvcephei commented on code in PR #13633:
URL: https://github.com/apache/kafka/pull/13633#discussion_r1186269574


##########
build.gradle:
##########
@@ -2057,6 +2057,7 @@ project(':streams') {
   srcJar.dependsOn 'processMessages'
 
   javadoc {
+    options.memberLevel = JavadocMemberLevel.PUBLIC  // Document only public members/API

Review Comment:
   I'd be +1 on expanding the scope to the whole project. If something needs to be publicly documented, it should probably be made public.
   
   FWIW, I'm also ok with merging as-is, and following up with a proposal to apply it to the whole repo.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org