You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/07 07:25:59 UTC

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6002: fs/poll: change format for type pollevent_t

anchao opened a new pull request, #6002:
URL: https://github.com/apache/incubator-nuttx/pull/6002

   
   ## Summary
   
   [fs/poll: change format for type pollevent_t](https://github.com/apache/incubator-nuttx/commit/acd5a378245ee214becdbe79b1cb3360d0379acc)
   
   complete the following commits:
   
   commit d87cf8d4ca5fe69c71c131015a7b64b68c917593
   Author: Jiuzhu Dong <do...@xiaomi.com>
   Date:   Fri Apr 1 20:59:55 2022 +0800
   
       fs/poll: change format for type pollevent_t
   
       Signed-off-by: Jiuzhu Dong <do...@xiaomi.com>
   
   commit d535943a69f03033b077cb95cce162bb28b40b56
   Author: Jiuzhu Dong <do...@xiaomi.com>
   Date:   Fri Apr 1 17:49:10 2022 +0800
   
       fs/epoll: change type of eventset from uint8_t to uint32_t
   
       to support EPOLLONESHOT and so on.
   
       Signed-off-by: Jiuzhu Dong <do...@xiaomi.com>
   
   Signed-off-by: chao.an <an...@xiaomi.com>
   
   
   ## Impact
   ```
   
   In file included from sensors/sensor.c:33:
   sensors/sensor.c: In function 'sensor_pollnotify':
   Error: sensors/sensor.c:170:22: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'pollevent_t' {aka 'long unsigned int'} [-Werror=format=]
     170 |               sninfo("Report events: %02x\n", fd->revents);
         |                      ^~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~
         |                                                 |
         |                                                 pollevent_t {aka long unsigned int}
   sensors/sensor.c:170:41: note: format string is defined here
     170 |               sninfo("Report events: %02x\n", fd->revents);
         |                                      ~~~^
         |                                         |
         |                                         unsigned int
         |                                      %02lx
   ```
   
   ## Testing
   
   ci check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6002: fs/poll: change format for type pollevent_t

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6002:
URL: https://github.com/apache/incubator-nuttx/pull/6002


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6002: fs/poll: change format for type pollevent_t

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6002:
URL: https://github.com/apache/incubator-nuttx/pull/6002#issuecomment-1091291797

   Let's merge it to unblock ci.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] anchao commented on pull request #6002: fs/poll: change format for type pollevent_t

Posted by GitBox <gi...@apache.org>.
anchao commented on PR #6002:
URL: https://github.com/apache/incubator-nuttx/pull/6002#issuecomment-1091267786

   Depends on:
   https://github.com/apache/incubator-nuttx-apps/pull/1127


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org