You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Fine <ab...@brightroll.com> on 2015/09/29 03:17:44 UTC
Review Request 38836: SQOOP-2549
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38836/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2549
https://issues.apache.org/jira/browse/SQOOP-2549
Repository: sqoop-sqoop2
Description
-------
Allow connector developers to mask certain keys in Maps when sending them back to clients
Diffs
-----
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 21739da
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java eb42da3
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 282a024
common/src/main/java/org/apache/sqoop/model/Input.java 883abe6
common/src/main/java/org/apache/sqoop/model/MMapInput.java f2c1ed7
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java ab4f258
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 7052841
common/src/test/java/org/apache/sqoop/model/TestMConfig.java f18b069
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java d0847fe
common/src/test/java/org/apache/sqoop/model/TestMJob.java e0ffdc2
common/src/test/java/org/apache/sqoop/model/TestMMapInput.java 118277e
docs/src/site/sphinx/ConnectorDevelopment.rst b35c521
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 46b5272
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java e41fe38
repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/MySqlTestCase.java 0bb3c63
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 389ccec
Diff: https://reviews.apache.org/r/38836/diff/
Testing
-------
yes
Thanks,
Abraham Fine
Re: Review Request 38836: SQOOP-2549
Posted by Abraham Fine <ab...@brightroll.com>.
> On Sept. 29, 2015, 3:12 a.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/model/MMapInput.java, line 35
> > <https://reviews.apache.org/r/38836/diff/1/?file=1086361#file1086361line35>
> >
> > For normal sensitive values we're using empty string or type's default (like 0 for integers, ...). I'm wondering whether we should do the same for map keys to stay consistent - what do you think?
For now I will replace this with the emtpy string. I will file a JIRA to reevaluate if this makes sense given String values in a map could be empty and there could be ambiguity here.
> On Sept. 29, 2015, 3:12 a.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java, line 38
> > <https://reviews.apache.org/r/38836/diff/1/?file=1086357#file1086357line38>
> >
> > Let's use shorter and dash separated "sensitive-pattern" key here to be in the line with other JSON keys that we're using?
agreed
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38836/#review100918
-----------------------------------------------------------
On Sept. 29, 2015, 1:17 a.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38836/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 1:17 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2549
> https://issues.apache.org/jira/browse/SQOOP-2549
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Allow connector developers to mask certain keys in Maps when sending them back to clients
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 21739da
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java eb42da3
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 282a024
> common/src/main/java/org/apache/sqoop/model/Input.java 883abe6
> common/src/main/java/org/apache/sqoop/model/MMapInput.java f2c1ed7
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java ab4f258
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 7052841
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java f18b069
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java d0847fe
> common/src/test/java/org/apache/sqoop/model/TestMJob.java e0ffdc2
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java 118277e
> docs/src/site/sphinx/ConnectorDevelopment.rst b35c521
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 46b5272
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java e41fe38
> repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/MySqlTestCase.java 0bb3c63
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 389ccec
>
> Diff: https://reviews.apache.org/r/38836/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Abraham Fine
>
>
Re: Review Request 38836: SQOOP-2549
Posted by Jarek Cecho <ja...@apache.org>.
> On Sept. 29, 2015, 3:12 a.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/model/MMapInput.java, line 35
> > <https://reviews.apache.org/r/38836/diff/1/?file=1086361#file1086361line35>
> >
> > For normal sensitive values we're using empty string or type's default (like 0 for integers, ...). I'm wondering whether we should do the same for map keys to stay consistent - what do you think?
>
> Abraham Fine wrote:
> For now I will replace this with the emtpy string. I will file a JIRA to reevaluate if this makes sense given String values in a map could be empty and there could be ambiguity here.
Makes complete sense to me Abe. Please create the follow up JIRA.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38836/#review100918
-----------------------------------------------------------
On Sept. 29, 2015, 1:17 a.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38836/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 1:17 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2549
> https://issues.apache.org/jira/browse/SQOOP-2549
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Allow connector developers to mask certain keys in Maps when sending them back to clients
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 21739da
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java eb42da3
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 282a024
> common/src/main/java/org/apache/sqoop/model/Input.java 883abe6
> common/src/main/java/org/apache/sqoop/model/MMapInput.java f2c1ed7
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java ab4f258
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 7052841
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java f18b069
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java d0847fe
> common/src/test/java/org/apache/sqoop/model/TestMJob.java e0ffdc2
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java 118277e
> docs/src/site/sphinx/ConnectorDevelopment.rst b35c521
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 46b5272
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java e41fe38
> repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/MySqlTestCase.java 0bb3c63
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 389ccec
>
> Diff: https://reviews.apache.org/r/38836/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Abraham Fine
>
>
Re: Review Request 38836: SQOOP-2549
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38836/#review100918
-----------------------------------------------------------
Thank you for the patch Abe!
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java (line 38)
<https://reviews.apache.org/r/38836/#comment158180>
Let's use shorter and dash separated "sensitive-pattern" key here to be in the line with other JSON keys that we're using?
common/src/main/java/org/apache/sqoop/model/MMapInput.java (line 35)
<https://reviews.apache.org/r/38836/#comment158186>
For normal sensitive values we're using empty string or type's default (like 0 for integers, ...). I'm wondering whether we should do the same for map keys to stay consistent - what do you think?
Jarcec
- Jarek Cecho
On Sept. 29, 2015, 1:17 a.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38836/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 1:17 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2549
> https://issues.apache.org/jira/browse/SQOOP-2549
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Allow connector developers to mask certain keys in Maps when sending them back to clients
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 21739da
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java eb42da3
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 282a024
> common/src/main/java/org/apache/sqoop/model/Input.java 883abe6
> common/src/main/java/org/apache/sqoop/model/MMapInput.java f2c1ed7
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java ab4f258
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 7052841
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java f18b069
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java d0847fe
> common/src/test/java/org/apache/sqoop/model/TestMJob.java e0ffdc2
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java 118277e
> docs/src/site/sphinx/ConnectorDevelopment.rst b35c521
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 46b5272
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java e41fe38
> repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/MySqlTestCase.java 0bb3c63
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 389ccec
>
> Diff: https://reviews.apache.org/r/38836/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Abraham Fine
>
>
Re: Review Request 38836: SQOOP-2549
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38836/#review100985
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Sept. 29, 2015, 1:17 a.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38836/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 1:17 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2549
> https://issues.apache.org/jira/browse/SQOOP-2549
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Allow connector developers to mask certain keys in Maps when sending them back to clients
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java 21739da
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java eb42da3
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 282a024
> common/src/main/java/org/apache/sqoop/model/Input.java 883abe6
> common/src/main/java/org/apache/sqoop/model/MMapInput.java f2c1ed7
> common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java ab4f258
> common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 7052841
> common/src/test/java/org/apache/sqoop/model/TestMConfig.java f18b069
> common/src/test/java/org/apache/sqoop/model/TestMConfigList.java d0847fe
> common/src/test/java/org/apache/sqoop/model/TestMJob.java e0ffdc2
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java 118277e
> docs/src/site/sphinx/ConnectorDevelopment.rst b35c521
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 46b5272
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java e41fe38
> repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/MySqlTestCase.java 0bb3c63
> repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java 389ccec
>
> Diff: https://reviews.apache.org/r/38836/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Abraham Fine
>
>