[jira] Commented: (ZOOKEEPER-230) Improvements to FLE

["Mahadev konar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650663#action_12650663 ] 

Mahadev konar commented on ZOOKEEPER-230:
-----------------------------------------

flavio,

- Currently, if a server is on leader election and doesn't receive a notification for some amount of time t, then it sends a new set of notifications if at least one server has delivered a message from the previous set. With this patch, the amount of time a server waits for a notification before sending a new set increases exponentially;

i dont unserstand the reason behind this. do we generate too many messages for the leader election notification? I think the traffic generated should be small. Also this does not seem to have a limit on exponential backoff. It will increase to insanely large amounts in case of network partition right?



> Improvements to FLE
> -------------------
>
>                 Key: ZOOKEEPER-230
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-230
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: leaderElection
>    Affects Versions: 3.0.0
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Flavio Paiva Junqueira
>             Fix For: 3.1.0
>
>         Attachments: ZOOKEEPER-230.patch
>
>
> I'm about to attach a patch that implements the following modifications:
> . Currently, if a server is on leader election and doesn't receive a notification for some amount of time t, then it sends a new set of notifications if at least one server has delivered a message from the previous set. With this patch, the amount of time a server waits for a notification before sending a new set increases exponentially;
> . I have separated connecting to servers and queuing new notification messages. Before they were all in the same message. The advantage is that now I can tell to an instance of QuorumCnxManager to try to connect to other servers without generating new notification messages;
> . I have changed the logging level of several messages on QuorumCnxManager. They were "warn", but they should really be either "info" or "debug". I've changed them to info.
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.