You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/06/26 11:53:50 UTC
[GitHub] [systemds] j143 opened a new pull request #1325: Pypi publish script
j143 opened a new pull request #1325:
URL: https://github.com/apache/systemds/pull/1325
minimize variables, add further documentation and check for the artifacts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 edited a comment on pull request #1325: Pypi publish script
Posted by GitBox <gi...@apache.org>.
j143 edited a comment on pull request #1325:
URL: https://github.com/apache/systemds/pull/1325#issuecomment-868991300
Should we use `cd`?
The `pushd` and `popd` may work like, which is a built-in function.
```sh
pushd ()
{
dirname=$1
DIR_STACK="$dirname ${DIR_STACK:-$PWD' '}"
cd ${dirname:?"missing directory name."}
echo "$DIR_STACK"
}
popd ()
{
DIR_STACK=${DIR_STACK#* }
cd ${DIR_STACK%% *}
echo "$PWD"
}
```
source: https://www.oreilly.com/library/view/learning-the-bash/1565923472/ch04s05.html
Does this spawn a subshell?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 edited a comment on pull request #1325: Pypi publish script
Posted by GitBox <gi...@apache.org>.
j143 edited a comment on pull request #1325:
URL: https://github.com/apache/systemds/pull/1325#issuecomment-868991300
Should we use `cd`?
The `pushd` and `popd` may work like, which is a built-in function.
```sh
pushd ()
{
dirname=$1
DIR_STACK="$dirname ${DIR_STACK:-$PWD' '}"
cd ${dirname:?"missing directory name."}
echo "$DIR_STACK"
}
popd ()
{
DIR_STACK=${DIR_STACK#* }
cd ${DIR_STACK%% *}
echo "$PWD"
}
```
Does this spawn a subshell?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] phaniarnab commented on pull request #1325: Pypi publish script
Posted by GitBox <gi...@apache.org>.
phaniarnab commented on pull request #1325:
URL: https://github.com/apache/systemds/pull/1325#issuecomment-869048610
> Should we use `cd`?
>
> The `pushd` and `popd` may work like, which is a built-in function.
>
> ```shell
> pushd ()
> {
> dirname=$1
> DIR_STACK="$dirname ${DIR_STACK:-$PWD' '}"
> cd ${dirname:?"missing directory name."}
> echo "$DIR_STACK"
> }
>
> popd ()
> {
> DIR_STACK=${DIR_STACK#* }
> cd ${DIR_STACK%% *}
> echo "$PWD"
> }
> ```
>
> source: https://www.oreilly.com/library/view/learning-the-bash/1565923472/ch04s05.html
>
> Does this spawn a subshell?
Yes. Directory stack makes sense when working with multiple directories.
For our use case, you can save the `pwd` in a local variable, use `cd` to enter your target folder, and later apply something like `cd $pwd` to get back to your original location if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] phaniarnab commented on pull request #1325: Pypi publish script
Posted by GitBox <gi...@apache.org>.
phaniarnab commented on pull request #1325:
URL: https://github.com/apache/systemds/pull/1325#issuecomment-868991071
I have reservations for use of pushd and popd. I'd avoid using sub-shell unless absolutely necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 merged pull request #1325: Pypi publish script
Posted by GitBox <gi...@apache.org>.
j143 merged pull request #1325:
URL: https://github.com/apache/systemds/pull/1325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 merged pull request #1325: Pypi publish script
Posted by GitBox <gi...@apache.org>.
j143 merged pull request #1325:
URL: https://github.com/apache/systemds/pull/1325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 commented on pull request #1325: Pypi publish script
Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #1325:
URL: https://github.com/apache/systemds/pull/1325#issuecomment-868991300
Should we use `cd`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org