You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by necosta <gi...@git.apache.org> on 2017/09/24 21:15:58 UTC
[GitHub] zeppelin pull request #2596: [ZEPPELIN-2949] Allow custom Spark UI URL
GitHub user necosta opened a pull request:
https://github.com/apache/zeppelin/pull/2596
[ZEPPELIN-2949] Allow custom Spark UI URL
### What is this PR for?
Allow an override of default Spark logic in building the URL path and redirect the Zeppelin user directly to a configured reverse proxy path
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2949
### How should this be tested?
* Set "zeppelin.spark.uiWebUrl" to http://localhost/spark-reverse-proxy-path
* Run Spark code
* Open Spark UI
* Expected to be redirected to http://localhost/spark-reverse-proxy-path
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin zeppelin2949
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2596.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2596
----
commit f86fe3735fc072dde74d081c94775e93bf42821c
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-09-24T20:58:29Z
[ZEPPELIN-2949] Allow custom Spark UI URL
----
---
[GitHub] zeppelin pull request #2596: [ZEPPELIN-2949] Allow custom Spark UI URL
Posted by necosta <gi...@git.apache.org>.
Github user necosta closed the pull request at:
https://github.com/apache/zeppelin/pull/2596
---
[GitHub] zeppelin pull request #2596: [ZEPPELIN-2949] Allow custom Spark UI URL
Posted by necosta <gi...@git.apache.org>.
GitHub user necosta reopened a pull request:
https://github.com/apache/zeppelin/pull/2596
[ZEPPELIN-2949] Allow custom Spark UI URL
### What is this PR for?
Allow an override of default Spark logic in building the URL path and redirect the Zeppelin user directly to a configured reverse proxy path
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2949
### How should this be tested?
* Set "zeppelin.spark.uiWebUrl" to http://localhost/spark-reverse-proxy-path
* Run Spark code
* Open Spark UI
* Expected to be redirected to http://localhost/spark-reverse-proxy-path
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin zeppelin2949
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2596.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2596
----
commit 0a56299c55d7161d6d1c8385a50b6e4bf366d404
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-09-24T20:58:29Z
[ZEPPELIN-2949] Allow custom Spark UI URL
commit 826bad4a0d9f61d68bd27641dfbbf42ef2430148
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-09-25T11:51:38Z
[ZEPPELIN-2949] Updated documentation
commit 118339fc9c282011e838c63d479842d76e5c77b0
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-10-11T12:51:36Z
[ZEPPELIN-2949] Updated documentation
commit 2ae8f2d064988e0e243cf6952101c5344ade0d03
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-10-19T09:21:54Z
[ZEPPELIN-2949] Last amendments
----
---
[GitHub] zeppelin pull request #2596: [ZEPPELIN-2949] Allow custom Spark UI URL
Posted by necosta <gi...@git.apache.org>.
GitHub user necosta reopened a pull request:
https://github.com/apache/zeppelin/pull/2596
[ZEPPELIN-2949] Allow custom Spark UI URL
### What is this PR for?
Allow an override of default Spark logic in building the URL path and redirect the Zeppelin user directly to a configured reverse proxy path
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2949
### How should this be tested?
* Set "zeppelin.spark.uiWebUrl" to http://localhost/spark-reverse-proxy-path
* Run Spark code
* Open Spark UI
* Expected to be redirected to http://localhost/spark-reverse-proxy-path
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin zeppelin2949
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2596.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2596
----
commit 0a56299c55d7161d6d1c8385a50b6e4bf366d404
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-09-24T20:58:29Z
[ZEPPELIN-2949] Allow custom Spark UI URL
commit 826bad4a0d9f61d68bd27641dfbbf42ef2430148
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-09-25T11:51:38Z
[ZEPPELIN-2949] Updated documentation
commit 118339fc9c282011e838c63d479842d76e5c77b0
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-10-11T12:51:36Z
[ZEPPELIN-2949] Updated documentation
----
---
[GitHub] zeppelin issue #2596: [ZEPPELIN-2949] Allow custom Spark UI URL
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2596
Thanks @felixcheung and apologies for the delay on this.
Rebased on top of latest master and updated documentation.
Can you have another look?
Thanks
---
[GitHub] zeppelin issue #2596: [ZEPPELIN-2949] Allow custom Spark UI URL
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2596
merging if no more comment
---
[GitHub] zeppelin issue #2596: [ZEPPELIN-2949] Allow custom Spark UI URL
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2596
Not sure what we can do to have the tests passing:
https://travis-ci.org/nokia/zeppelin/jobs/279484561
https://travis-ci.org/nokia/zeppelin/jobs/279484562
Any suggestions?
---
[GitHub] zeppelin pull request #2596: [ZEPPELIN-2949] Allow custom Spark UI URL
Posted by necosta <gi...@git.apache.org>.
Github user necosta closed the pull request at:
https://github.com/apache/zeppelin/pull/2596
---
[GitHub] zeppelin pull request #2596: [ZEPPELIN-2949] Allow custom Spark UI URL
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2596
---
[GitHub] zeppelin issue #2596: [ZEPPELIN-2949] Allow custom Spark UI URL
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2596
Thanks @felixcheung. Test looks unrelated but I'll double check.
Added one commit for documentation
Not sure how much we want to document on how to work with Spark behind reverse proxy but I can add that by setting properties:
* spark.ui.enabled=true
* spark.ui.reverseProxy=false (disables '/proxy/applicationId' web url path)
* spark.ui.proxyBase=/reverseProxyUniqueKey
* zeppelin.spark.uiWebUrl=http://{hostName}/reverseProxyUniqueKey
https://issues.apache.org/jira/browse/SPARK-20044 is preventing us from using a path prefix and it is assumed we are routing from spark port to reverseProxyUniqueKey
---