You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/07/03 11:22:01 UTC

[GitHub] [maven-assembly-plugin] pzygielo commented on a change in pull request #28: replace deprecated assertThat method

pzygielo commented on a change in pull request #28:
URL: https://github.com/apache/maven-assembly-plugin/pull/28#discussion_r449531474



##########
File path: src/test/java/org/apache/maven/plugins/assembly/utils/FilterUtilsTest.java
##########
@@ -183,21 +184,18 @@ public void testFilterProjects_ShouldNotRemoveProjectNotIncludedAndNotExcluded()
     @Test
     public void testTransitiveScopes()
     {
-        Assert.assertThat( FilterUtils.newScopeFilter( "compile" ).getIncluded(),
-                           Matchers.containsInAnyOrder( "compile", "provided", "system" ) );
+        assertThat( FilterUtils.newScopeFilter( "compile" ).getIncluded(),

Review comment:
       Perhaps unused `import org.junit.Assert;` at line 42/43 could be removed then?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org