You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by pu239ppy <gi...@git.apache.org> on 2018/09/07 15:22:28 UTC

[GitHub] phoenix pull request #344: PHOENIX-4688 Kerberize python phoenixdb -- Phoeni...

GitHub user pu239ppy opened a pull request:

    https://github.com/apache/phoenix/pull/344

    PHOENIX-4688 Kerberize python phoenixdb -- Phoenix 5

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pu239ppy/phoenix PHOENIX-4688.master.5

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #344
    
----
commit 0a094bfba3c1776c222103cbc53f022744e23617
Author: Lev Bronshtein <lb...@...>
Date:   2018-08-29T21:19:51Z

    add phonixdb gssapi on master

----


---

[GitHub] phoenix issue #344: PHOENIX-4688 Kerberize python phoenixdb -- Phoenix 5

Posted by Reidddddd <gi...@git.apache.org>.
Github user Reidddddd commented on the issue:

    https://github.com/apache/phoenix/pull/344
  
    Python version has to >= 3.6.5? 
    @joshelser @pu239ppy 


---

[GitHub] phoenix issue #344: PHOENIX-4688 Kerberize python phoenixdb -- Phoenix 5

Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:

    https://github.com/apache/phoenix/pull/344
  
    ```
    2018-09-27 14:05:06,308 ERROR [main] end2end.SecureQueryServerPhoenixDBIT(358): + python /Users/jelser/projects/phoenix.git/phoenix-queryserver/./src/it/bin/test_phoenixdb.py 50023
    2018-09-27 14:05:06,309 ERROR [main] end2end.SecureQueryServerPhoenixDBIT(358): /Users/jelser/projects/phoenix.git/phoenix-queryserver/./src/it/bin/test_phoenixdb.sh: line 60:  7582 Illegal instruction: 4  python $PYTHON_SCRIPT $PQS_PORT
    ```
    
    We're back to this junk again. @pu239ppy what version of Python are you running for which this is working?


---

[GitHub] phoenix issue #344: PHOENIX-4688 Kerberize python phoenixdb -- Phoenix 5

Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:

    https://github.com/apache/phoenix/pull/344
  
    > Hi @joshelser , did you finally managed to test it out successfully?
    
    No, sadly. I didn't get the last variant working. Pulling down this version and trying again.


---

[GitHub] phoenix issue #344: PHOENIX-4688 Kerberize python phoenixdb -- Phoenix 5

Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:

    https://github.com/apache/phoenix/pull/344
  
    Ok, with python 3.6.5, downgrading to pykerberos to 1.1.14 (in requests-kerberos), and updating test_phoenixdb.py for python3 print syntax, it works!!! 


---

[GitHub] phoenix issue #344: PHOENIX-4688 Kerberize python phoenixdb -- Phoenix 5

Posted by akhmadMizkat <gi...@git.apache.org>.
Github user akhmadMizkat commented on the issue:

    https://github.com/apache/phoenix/pull/344
  
    Awesome guys. This is a very good improvement for the phoenixdb library.


---

[GitHub] phoenix pull request #344: PHOENIX-4688 Kerberize python phoenixdb -- Phoeni...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/phoenix/pull/344


---

[GitHub] phoenix issue #344: PHOENIX-4688 Kerberize python phoenixdb -- Phoenix 5

Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:

    https://github.com/apache/phoenix/pull/344
  
    Oops, forgot one more thing. I changed the integration test that had heimdal syntax because, even though I have OSX, I have MIT Kerberos installed.
    
    Although, now that I think about it, do we need to generate a specific krb5.conf based on OS at all? The embedded KDC is provided by Kerby from Apache Directory -- it's not Heimdal or MIT Kerberos. That can be cleaned up completely.
    
    @pu239ppy let me know. I can send a pull request to your branch if you're ready to just be done with these changes. I want to poke around some more at Python versions that work locally.


---

[GitHub] phoenix issue #344: PHOENIX-4688 Kerberize python phoenixdb -- Phoenix 5

Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:

    https://github.com/apache/phoenix/pull/344
  
    This looks awesome, @pu239ppy. Testing it out.


---

[GitHub] phoenix issue #344: PHOENIX-4688 Kerberize python phoenixdb -- Phoenix 5

Posted by akhmadMizkat <gi...@git.apache.org>.
Github user akhmadMizkat commented on the issue:

    https://github.com/apache/phoenix/pull/344
  
    @pu239ppy thank you for the clarification. Hope they can accept your PR on the requests-kerberos. Really looking forward for that.


---

[GitHub] phoenix issue #344: PHOENIX-4688 Kerberize python phoenixdb -- Phoenix 5

Posted by pu239ppy <gi...@git.apache.org>.
Github user pu239ppy commented on the issue:

    https://github.com/apache/phoenix/pull/344
  
    @akhmadMizkat this solution currently does not work, please see latest commentary on PHOENIX-4688 for description.  There are existing solutions to remediate this, however I was hoping not to distibute a patched version of requests-kerberos


---

[GitHub] phoenix issue #344: PHOENIX-4688 Kerberize python phoenixdb -- Phoenix 5

Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:

    https://github.com/apache/phoenix/pull/344
  
    Switched to Python 3.6.5 and now hitting https://github.com/02strich/pykerberos/issues/37


---

[GitHub] phoenix issue #344: PHOENIX-4688 Kerberize python phoenixdb -- Phoenix 5

Posted by akhmadMizkat <gi...@git.apache.org>.
Github user akhmadMizkat commented on the issue:

    https://github.com/apache/phoenix/pull/344
  
    > This looks awesome, @pu239ppy. Testing it out.
    
    Hi @joshelser , did you finally managed to test it out successfully?


---

[GitHub] phoenix issue #344: PHOENIX-4688 Kerberize python phoenixdb -- Phoenix 5

Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:

    https://github.com/apache/phoenix/pull/344
  
    Hey @Reidddddd -- likely other version of Python will work too, we just only tested using 3.6.5


---