[GitHub] [airflow] dstandish commented on pull request #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

[GitBox <gi...@apache.org>]

dstandish commented on pull request #6850:
URL: https://github.com/apache/airflow/pull/6850#issuecomment-829515009


   TLDR it seems like we should be able to remove that interdependency by putting this line behind an `if TYPING` guard:
   https://github.com/apache/airflow/blob/master/airflow/providers/microsoft/mssql/operators/mssql.py#L23
   
   @eladkal for background, the original thought was that we would deprecate support for pymssql and switch to pyodbc since the pymssql project, at the time, had been abandoned, and they pushed out an intentionally broken 3.0 release.
   
   So I added an odbc hook, and using the method `Connection.get_hook`, updated MsSqlOperator so that it would use the hook you chose based on your connection's `conn_type`.
   
   But later, I think the pymssql project was resurrected, and at some point airflow decided to un-deprecate pymssql as the client for mssql.
   
   I can create a PR for the tying issue in MsSqlOperator
   
   if you have other issues you could use help with link me and i can take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org