You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datalab.apache.org by ol...@apache.org on 2022/03/11 11:37:06 UTC
[incubator-datalab] branch gcp-jupyter-highgpu-template-1 updated: removed notebooks from addGpuType
This is an automated email from the ASF dual-hosted git repository.
olehmykolaishyn pushed a commit to branch gcp-jupyter-highgpu-template-1
in repository https://gitbox.apache.org/repos/asf/incubator-datalab.git
The following commit(s) were added to refs/heads/gcp-jupyter-highgpu-template-1 by this push:
new 6fd15df removed notebooks from addGpuType
6fd15df is described below
commit 6fd15df39dc13ed002af533016c9504b40a11411
Author: oleh_mykolaishyn <ow...@gmail.com>
AuthorDate: Fri Mar 11 13:36:50 2022 +0200
removed notebooks from addGpuType
---
.../create-environment/create-environment.component.html | 4 ----
.../create-environment/create-environment.component.ts | 10 +++++-----
2 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/create-environment/create-environment.component.html b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/create-environment/create-environment.component.html
index 0b2a4e9..b39d955 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/create-environment/create-environment.component.html
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/create-environment/create-environment.component.html
@@ -253,8 +253,6 @@
<ng-template
[ngIf]="selectedCloud === 'gcp'
&& (currentTemplate?.image === 'docker.datalab-jupyter'
- || currentTemplate?.image === 'docker.datalab-jupyter-gpu'
- || currentTemplate?.image === 'docker.datalab-jupyter-gpu-conda'
|| currentTemplate?.image === 'docker.datalab-deeplearning'
|| currentTemplate?.image === 'docker.datalab-tensor')"
>
@@ -272,8 +270,6 @@
<ng-template
[ngIf]="this.additionalParams.gpu ||
currentTemplate?.image === 'docker.datalab-deeplearning' ||
- currentTemplate?.image === 'docker.datalab-jupyter-gpu' ||
- currentTemplate?.image === 'docker.datalab-jupyter-gpu-conda' ||
currentTemplate?.image === 'docker.datalab-tensor'"
>
<!---<div *ngIf="currentTemplate?.image !== 'docker.datalab-jupyter-gpu'" class="control-group"> --->
diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/create-environment/create-environment.component.ts b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/create-environment/create-environment.component.ts
index 1f6b5f7..93bdffb 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/create-environment/create-environment.component.ts
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/create-environment/create-environment.component.ts
@@ -176,14 +176,14 @@ export class ExploratoryEnvironmentCreateComponent implements OnInit {
if (this.selectedCloud === 'gcp' &&
(template?.image === 'docker.datalab-jupyter' ||
- template?.image === 'docker.datalab-jupyter-gpu' ||
- template?.image === 'docker.datalab-jupyter-gpu-conda' ||
+/** template?.image === 'docker.datalab-jupyter-gpu' || */
+/** template?.image === 'docker.datalab-jupyter-gpu-conda' || */
template?.image === 'docker.datalab-deeplearning' ||
template?.image === 'docker.datalab-tensor')) {
this.gpuTypes = template?.computationGPU ? HelpUtils.sortGpuTypes(template.computationGPU) : [];
- if(template?.image === 'docker.datalab-tensor' || template?.image === 'docker.datalab-jupyter-gpu-conda'|| template?.image === 'docker.datalab-jupyter-gpu' || template?.image === 'docker.datalab-deeplearning') {
+ if(template?.image === 'docker.datalab-tensor' /**|| template?.image === 'docker.datalab-jupyter-gpu-conda'|| template?.image === 'docker.datalab-jupyter-gpu' */|| template?.image === 'docker.datalab-deeplearning') {
this.addGpuFields();
}
}
@@ -193,8 +193,8 @@ export class ExploratoryEnvironmentCreateComponent implements OnInit {
if (template.exploratory_environment_versions[0].template_name.toLowerCase().indexOf('tensorflow') === -1
&& template.exploratory_environment_versions[0].template_name.toLowerCase().indexOf('deeplearning') === -1
- && template.exploratory_environment_versions[0].template_name.toLowerCase().indexOf('jupyter-gpu') === -1
- && template.exploratory_environment_versions[0].template_name.toLowerCase().indexOf('jupyter-gpu-conda') === -1
+/** && template.exploratory_environment_versions[0].template_name.toLowerCase().indexOf('jupyter-gpu') === -1
+ && template.exploratory_environment_versions[0].template_name.toLowerCase().indexOf('jupyter-gpu-conda') === -1 */
&& template.exploratory_environment_versions[0].template_name.toLowerCase().indexOf('deep learning') === -1
&& template.exploratory_environment_versions[0].template_name.toLowerCase().indexOf('data science') === -1
) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datalab.apache.org
For additional commands, e-mail: commits-help@datalab.apache.org