You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/03 09:29:39 UTC

[GitHub] [iceberg] pvary commented on pull request #1842: Hive: Refactor Hive Iceberg schema conversions to a single file

pvary commented on pull request #1842:
URL: https://github.com/apache/iceberg/pull/1842#issuecomment-737779561


   > The change lgtm. What do you think the proposal of https://issues.apache.org/jira/browse/IMPALA-10368, i.e. make NOT NULL fields required and vice versa?
   
   Good point, as with the column comments, I think it would be a good candidate to get into the next PR(s)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org