You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openmeetings.apache.org by "Andun Sameera Liyanagunawardana (JIRA)" <ji...@apache.org> on 2013/04/06 22:35:15 UTC

[jira] [Comment Edited] (OPENMEETINGS-603) Conference Room Types List doesn't display textual content - Book Conference Room Option Selected while Sending an Email

    [ https://issues.apache.org/jira/browse/OPENMEETINGS-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624485#comment-13624485 ] 

Andun Sameera Liyanagunawardana edited comment on OPENMEETINGS-603 at 4/6/13 8:33 PM:
--------------------------------------------------------------------------------------

I have put a debug log inside the above code(singlewebapp/WebContent/src/modules/settings/privatemessages/newPrivateMessage.lzx) for loop like this,

 if($debug) Debug.write("canvas.roomTypesInitValues[i].label :",canvas.roomTypesInitValues[i].label);

The result which I got was,

canvas.roomTypesInitValues[i].label : null 

This means the label has been assigned by a null value. So I put another debug log to a point where all the room types are retrieved from DB(netRemoteCallHib name="getRoomTypes" of the singlewebapp/WebContent/src/base/hibernate/hibRtmpConnection.lzx). Here is the result I got,

getRoomTypes****************************************************************  «Array(3)#612| [{deleted: false, fieldvalues_id: null, label: null, name: 'conference (1-25 users)', roomtypes_id: 1, starttime: Mon Apr 1 21:45:46 GMT+0530 2013, updatetime: null}, {deleted: false, fieldvalues_id: null, label: null, name: 'restricted  (1-150 users)', roomtypes_id: 3, starttime: Mon Apr 1 21:45:46 GMT+0530 2013, updatetime: null}, {deleted: false, fieldvalues_id: null, label: null, name: 'interview  (1:1 meeting with recording)', roomtypes_id: 4, starttime: Mon Apr 1 21:45:46 GMT+0530 2013, updatetime: null}]» 

What I noticed was all the label values of the rooms are null. Then I have looked at the the code where default room types are initialized(loadRoomTypes method of the singlewebapp/src/org/apache/openmeetings/installation/ImportInitvalues.java). It uses these kind of codes to load rooms,

long conference_Id = roomManager.addRoomType("conference", 1541, false);

In the addRoomType method there is no mention about value called label. The label id 1541 is passed to a field called fieldvalues_id. Also I checked the back-end DB's roomtype table. It also doesn't have a column called label. 

Also the room type is represented by a object of singlewebapp/src/org/apache/openmeetings/persistence/beans/room/RoomType.java. It also doesn't have a attribute called label. Then how come this label in to the code ?

I think we have to replace canvas.roomTypesInitValues[i].label.value in the room type list code by canvas.roomTypesInitValues[i].name. Need your comments.

Thanks
AndunSLG
                
      was (Author: andunslg):
    I have put a debug log inside the above code(singlewebapp/WebContent/src/modules/settings/privatemessages/newPrivateMessage.lzx) for loop like this,

 if($debug) Debug.write("canvas.roomTypesInitValues[i].label :",canvas.roomTypesInitValues[i].label);

The result which I got was,

canvas.roomTypesInitValues[i].label : null 

This means the label has been assigned by a null value. So I put another debug log to a point where all the room types are retrieved from DB(netRemoteCallHib name="getRoomTypes" of the singlewebapp/WebContent/src/base/hibernate/hibRtmpConnection.lzx). Here is the result I got,

getRoomTypes****************************************************************  «Array(3)#612| [{deleted: false, fieldvalues_id: null, label: null, name: 'conference (1-25 users)', roomtypes_id: 1, starttime: Mon Apr 1 21:45:46 GMT+0530 2013, updatetime: null}, {deleted: false, fieldvalues_id: null, label: null, name: 'restricted  (1-150 users)', roomtypes_id: 3, starttime: Mon Apr 1 21:45:46 GMT+0530 2013, updatetime: null}, {deleted: false, fieldvalues_id: null, label: null, name: 'interview  (1:1 meeting with recording)', roomtypes_id: 4, starttime: Mon Apr 1 21:45:46 GMT+0530 2013, updatetime: null}]» 

What I noticed was all the label values of the rooms are null. Then I have looked at the the code where default room types are initialized(loadRoomTypes method of the singlewebapp/src/org/apache/openmeetings/installation/ImportInitvalues.java). It uses these kind of codes to load rooms,

long conference_Id = roomManager.addRoomType("conference", 1541, false);

In the addRoomType methode there is no mention about value called label. The label id 1541 is passed to a field called fieldvalues_id. Also I checked the back-end DB's roomtype table. It also doesn't have a column called label. Then how come this label in to the code ?

I think we have to replace canvas.roomTypesInitValues[i].label.value in the room type list code by canvas.roomTypesInitValues[i].name. Need your comments.

Thanks
AndunSLG
                  
> Conference Room Types List doesn't display textual content - Book Conference Room Option Selected while Sending an Email 
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OPENMEETINGS-603
>                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-603
>             Project: Openmeetings
>          Issue Type: Bug
>          Components: UI
>    Affects Versions: 3.0.0 Apache Release
>         Environment: Ubuntu 12.10, Mozilla Firefox
>            Reporter: Andun Sameera Liyanagunawardana
>            Assignee: SebastianWagner
>            Priority: Critical
>             Fix For: 3.0.0 Apache Release
>
>
> I am working on the issue [1]. When I was trying to reproduce it, in the latest trunk I got this issue.
> Steps to Reproduce, 
> -Go to Contacts and messages Tab
> -Click on New Email button
> -When write new message window shows, Tick the Book conference room option
> -Click on the drop-down button of the Type
> -There will be 3-item list is shown. We can select these three items. But no textual captions to these items is shown.
> [1] - https://issues.apache.org/jira/browse/OPENMEETINGS-481

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira