[GitHub] [flink] StephanEwen commented on a change in pull request #10921: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default

[GitBox <gi...@apache.org>]

StephanEwen commented on a change in pull request #10921: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10921#discussion_r369710339
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendMigrationTestBase.java
 ##########
 @@ -71,12 +74,26 @@
 
 	protected abstract B getStateBackend() throws Exception;
 
+	protected abstract long getManagedMemorySize();
 
 Review comment:
   Not sure I fully understand.
   
   All managed memory (on heap and off heap) is not eagerly allocated or reserved. Having some managed memory by default would not hurt, because it is not materialized as memory segments. All tests that would not use it would not behave any different if the managed memory was there or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services