[GitHub] [mina-sshd] tomaswolf commented on pull request #156: [SSHD-1050] Fixed race condition in AuthFuture if exception caught before authentication started

[GitBox <gi...@apache.org>]

tomaswolf commented on pull request #156:
URL: https://github.com/apache/mina-sshd/pull/156#issuecomment-668803523


   I've pushed https://github.com/tomaswolf/mina-sshd/commit/3f15c6dbcce1dae0c88cae5b2ad0c2f07ebbc43e in https://github.com/tomaswolf/mina-sshd/tree/SSHD-1050 . It's a follow-up commit on this one; IMO solves the problem and I don't see any race conditions anymore. Feel free to fetch and squash into your change here.
   
   Ran a full build of sshd, no tests failed. JGit tests also work with this.
   
   BTW, I like your test for this; it reproduces consistently; much better than my original attempt.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org