You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/07/30 02:23:38 UTC
[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request, #3242: [SCB-2650][SCB-2290]support instance isolation and instance bulkhead
liubao68 opened a new pull request, #3242:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3242
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3242: [SCB-2650][SCB-2290]support instance isolation and instance bulkhead
Posted by GitBox <gi...@apache.org>.
liubao68 merged PR #3242:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3242: [SCB-2650][SCB-2290]support instance isolation and instance bulkhead
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3242:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3242#issuecomment-1200123708
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3242](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c0e69fd) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/0b4b0d83b29675aba30e588705792a5adfb8095f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b4b0d8) will **increase** coverage by `0.01%`.
> The diff coverage is `75.00%`.
```diff
@@ Coverage Diff @@
## master #3242 +/- ##
============================================
+ Coverage 77.48% 77.49% +0.01%
Complexity 1439 1439
============================================
Files 1629 1631 +2
Lines 43409 43441 +32
Branches 3652 3654 +2
============================================
+ Hits 33634 33666 +32
- Misses 8267 8268 +1
+ Partials 1508 1507 -1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mb/governance/handler/InstanceBulkheadHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9oYW5kbGVyL0luc3RhbmNlQnVsa2hlYWRIYW5kbGVyLmphdmE=) | `70.37% <70.37%> (ø)` | |
| [...ervicecomb/governance/GovernanceConfiguration.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9Hb3Zlcm5hbmNlQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ernance/properties/InstanceBulkheadProperties.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9wcm9wZXJ0aWVzL0luc3RhbmNlQnVsa2hlYWRQcm9wZXJ0aWVzLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `9.57% <0.00%> (-1.07%)` | :arrow_down: |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `70.93% <0.00%> (+0.76%)` | :arrow_up: |
| [...he/servicecomb/foundation/common/net/NetUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9OZXRVdGlscy5qYXZh) | `66.40% <0.00%> (+1.60%)` | :arrow_up: |
| [...mb/serviceregistry/client/http/RestClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1Jlc3RDbGllbnRVdGlsLmphdmE=) | `80.37% <0.00%> (+1.86%)` | :arrow_up: |
| [...comb/core/definition/MicroserviceVersionsMeta.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9kZWZpbml0aW9uL01pY3Jvc2VydmljZVZlcnNpb25zTWV0YS5qYXZh) | `100.00% <0.00%> (+5.26%)` | :arrow_up: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3242: [SCB-2650][SCB-2290]support instance isolation and instance bulkhead
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3242:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3242#discussion_r933914112
##########
handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/filterext/IsolationDiscoveryFilter.java:
##########
@@ -44,7 +44,7 @@ public class IsolationDiscoveryFilter implements ServerListFilterExt {
private static final Logger LOGGER = LoggerFactory.getLogger(IsolationDiscoveryFilter.class);
private final DynamicBooleanProperty emptyProtection = DynamicPropertyFactory.getInstance()
- .getBooleanProperty(EMPTY_INSTANCE_PROTECTION, false);
+ .getBooleanProperty(EMPTY_INSTANCE_PROTECTION, true);
Review Comment:
I changed back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on a diff in pull request #3242: [SCB-2650][SCB-2290]support instance isolation and instance bulkhead
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #3242:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3242#discussion_r933913741
##########
handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/filterext/IsolationDiscoveryFilter.java:
##########
@@ -44,7 +44,7 @@ public class IsolationDiscoveryFilter implements ServerListFilterExt {
private static final Logger LOGGER = LoggerFactory.getLogger(IsolationDiscoveryFilter.class);
private final DynamicBooleanProperty emptyProtection = DynamicPropertyFactory.getInstance()
- .getBooleanProperty(EMPTY_INSTANCE_PROTECTION, false);
+ .getBooleanProperty(EMPTY_INSTANCE_PROTECTION, true);
Review Comment:
does this is a default value change? should we put it in the upgrade guide?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org