[GitHub] nifi pull request #2375: autoclosesocket

[guangxuewu <gi...@git.apache.org>]

GitHub user guangxuewu opened a pull request:

    https://github.com/apache/nifi/pull/2375

    autoclosesocket

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guangxuewu/nifi master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2375.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2375
    
----
commit 7c9456d25b273bd8586a9352772801f5d9b462be
Author: guangxuewu <st...@...>
Date:   2018-01-05T05:46:55Z

    autoclosesocket

----


---

[GitHub] nifi issue #2375: autoclosesocket

[markap14 <gi...@git.apache.org>]

Github user markap14 commented on the issue:

    https://github.com/apache/nifi/pull/2375
  
    @guangxuewu thanks for your interest in contributing to NiFi! Is there a JIRA that this PR should be associated with?


---

[GitHub] nifi pull request #2375: autoclosesocket

[markap14 <gi...@git.apache.org>]

Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2375#discussion_r160507869
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowService.java ---
    @@ -533,7 +533,9 @@ public void load(final DataFlow dataFlow) throws IOException, FlowSerializationE
                     // operating in standalone mode, so load proposed flow and initialize the controller
                     loadFromBytes(dataFlow, true);
                     initializeController();
    -                dao.save(controller, true);
    --- End diff --
    
    Saving the flow here is important when interacting with a cluster. I don't think this is something that can/should be removed.


---