You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "Maxwell-Guo (via GitHub)" <gi...@apache.org> on 2023/04/12 02:18:04 UTC
[GitHub] [cassandra] Maxwell-Guo commented on a diff in pull request #2267: CASSANDRA-18398: Trie-indexed SSTable format
Maxwell-Guo commented on code in PR #2267:
URL: https://github.com/apache/cassandra/pull/2267#discussion_r1162272763
##########
src/java/org/apache/cassandra/db/DeletionTime.java:
##########
@@ -191,4 +201,4 @@ public long serializedSize(DeletionTime delTime)
+ TypeSizes.sizeof(delTime.markedForDeleteAt());
}
}
-}
+}
Review Comment:
seems no necessary to remove and add a new line.
##########
src/java/org/apache/cassandra/io/sstable/format/bti/BtiFormat.java:
##########
@@ -0,0 +1,490 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.cassandra.io.sstable.format.bti;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Set;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.collect.Lists;
+import com.google.common.collect.Sets;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.cassandra.db.ColumnFamilyStore;
+import org.apache.cassandra.db.DecoratedKey;
+import org.apache.cassandra.db.lifecycle.LifecycleTransaction;
+import org.apache.cassandra.dht.IPartitioner;
+import org.apache.cassandra.io.sstable.Component;
+import org.apache.cassandra.io.sstable.Descriptor;
+import org.apache.cassandra.io.sstable.GaugeProvider;
+import org.apache.cassandra.io.sstable.IScrubber;
+import org.apache.cassandra.io.sstable.MetricsProviders;
+import org.apache.cassandra.io.sstable.SSTable;
+import org.apache.cassandra.io.sstable.filter.BloomFilterMetrics;
+import org.apache.cassandra.io.sstable.format.AbstractSSTableFormat;
+import org.apache.cassandra.io.sstable.format.SSTableFormat;
+import org.apache.cassandra.io.sstable.format.SSTableReader;
+import org.apache.cassandra.io.sstable.format.SSTableReaderLoadingBuilder;
+import org.apache.cassandra.io.sstable.format.SSTableWriter;
+import org.apache.cassandra.io.sstable.format.SortedTableScrubber;
+import org.apache.cassandra.io.sstable.format.Version;
+import org.apache.cassandra.net.MessagingService;
+import org.apache.cassandra.schema.TableMetadataRef;
+import org.apache.cassandra.utils.JVMStabilityInspector;
+import org.apache.cassandra.utils.OutputHandler;
+import org.apache.cassandra.utils.Pair;
+
+/**
+ * Bigtable format with trie indices
+ */
+public class BtiFormat extends AbstractSSTableFormat<BtiTableReader, BtiTableWriter>
+{
+ private final static Logger logger = LoggerFactory.getLogger(BtiFormat.class);
+
+ public static final BtiFormat instance = new BtiFormat();
+
+ public static final Version latestVersion = new BtiVersion(BtiVersion.current_version);
+ static final BtiTableReaderFactory readerFactory = new BtiTableReaderFactory();
+ static final BtiTableWriterFactory writerFactory = new BtiTableWriterFactory();
+
+ public static class Components extends AbstractSSTableFormat.Components
+ {
+ public static class Types extends AbstractSSTableFormat.Components.Types
+ {
+ public static final Component.Type PARTITION_INDEX = Component.Type.createSingleton("PARTITION_INDEX", "Partitions.db", BtiFormat.class);
+ public static final Component.Type ROW_INDEX = Component.Type.createSingleton("ROW_INDEX", "Rows.db", BtiFormat.class);
+ }
+
+ public final static Component PARTITION_INDEX = Types.PARTITION_INDEX.getSingleton();
+
+ public final static Component ROW_INDEX = Types.ROW_INDEX.getSingleton();
+
+ private final static Set<Component> STREAMING_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ STATS,
+ COMPRESSION_INFO,
+ FILTER,
+ DIGEST,
+ CRC);
+
+ private final static Set<Component> PRIMARY_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX);
+
+ private final static Set<Component> MUTABLE_COMPONENTS = ImmutableSet.of(STATS);
+
+ private static final Set<Component> UPLOAD_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ COMPRESSION_INFO,
+ STATS);
+
+ private static final Set<Component> BATCH_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ COMPRESSION_INFO,
+ FILTER,
+ STATS);
+
+ private final static Set<Component> ALL_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ STATS,
+ COMPRESSION_INFO,
+ FILTER,
+ DIGEST,
+ CRC,
+ TOC);
+
+ private final static Set<Component> GENERATED_ON_LOAD_COMPONENTS = ImmutableSet.of(FILTER);
+ }
+
+
+ private BtiFormat()
+ {
+
+ }
+
+ public static BtiFormat getInstance()
+ {
+ return instance;
+ }
+
+ public static boolean isDefault()
+ {
+ return getInstance().getType() == Type.current();
+ }
+
+ @Override
+ public Version getLatestVersion()
+ {
+ return latestVersion;
+ }
+
+ @Override
+ public Version getVersion(String version)
+ {
+ return new BtiVersion(version);
+ }
+
+ @Override
+ public BtiTableWriterFactory getWriterFactory()
+ {
+ return writerFactory;
+ }
+
+ @Override
+ public BtiTableReaderFactory getReaderFactory()
+ {
+ return readerFactory;
+ }
+
+ @Override
+ public Set<Component> streamingComponents()
+ {
+ return Components.STREAMING_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> primaryComponents()
+ {
+ return Components.PRIMARY_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> batchComponents()
+ {
+ return Components.BATCH_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> uploadComponents()
+ {
+ return Components.UPLOAD_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> mutableComponents()
+ {
+ return Components.MUTABLE_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> allComponents()
+ {
+ return Components.ALL_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> generatedOnLoadComponents()
+ {
+ return Components.GENERATED_ON_LOAD_COMPONENTS;
+ }
+
+ @Override
+ public SSTableFormat.KeyCacheValueSerializer<BtiTableReader, TrieIndexEntry> getKeyCacheValueSerializer()
+ {
+ throw new AssertionError("BTI sstables do not use key cache");
+ }
+
+ @Override
+ public IScrubber getScrubber(ColumnFamilyStore cfs, LifecycleTransaction transaction, OutputHandler outputHandler, IScrubber.Options options)
+ {
+ Preconditions.checkArgument(cfs.metadata().equals(transaction.onlyOne().metadata()));
+ return new BtiTableScrubber(cfs, transaction, outputHandler, options);
+ }
+
+ @Override
+ public BtiTableReader cast(SSTableReader sstr)
+ {
+ return (BtiTableReader) sstr;
+ }
+
+ @Override
+ public BtiTableWriter cast(SSTableWriter sstw)
+ {
+ return (BtiTableWriter) sstw;
+ }
+
+ @Override
+ public MetricsProviders getFormatSpecificMetricsProviders()
+ {
+ return BtiTableSpecificMetricsProviders.instance;
+ }
+
+ @Override
+ public void deleteOrphanedComponents(Descriptor descriptor, Set<Component> components)
+ {
+ SortedTableScrubber.deleteOrphanedComponents(descriptor, components);
+ }
+
+ private void delete(Descriptor desc, List<Component> components)
+ {
+ logger.info("Deleting sstable: {}", desc);
+
+ if (components.remove(SSTableFormat.Components.DATA))
+ components.add(0, SSTableFormat.Components.DATA); // DATA component should be first
+
+ for (Component component : components)
+ {
+ logger.trace("Deleting component {} of {}", component, desc);
+ desc.fileFor(component).deleteIfExists();
+ }
+ }
+
+ @Override
+ public void delete(Descriptor desc)
+ {
+ try
+ {
+ delete(desc, Lists.newArrayList(Sets.intersection(allComponents(), desc.discoverComponents())));
+ }
+ catch (Throwable t)
+ {
+ JVMStabilityInspector.inspectThrowable(t);
+ }
+ }
+
+ static class BtiTableReaderFactory implements SSTableReaderFactory<BtiTableReader, BtiTableReader.Builder>
+ {
+ @Override
+ public SSTableReader.Builder<BtiTableReader, BtiTableReader.Builder> builder(Descriptor descriptor)
+ {
+ return new BtiTableReader.Builder(descriptor);
+ }
+
+ @Override
+ public SSTableReaderLoadingBuilder<BtiTableReader, BtiTableReader.Builder> loadingBuilder(Descriptor descriptor, TableMetadataRef tableMetadataRef, Set<Component> components)
+ {
+ return new BtiTableReaderLoadingBuilder(new SSTable.Builder<>(descriptor).setTableMetadataRef(tableMetadataRef)
+ .setComponents(components));
+ }
+
+ @Override
+ public Pair<DecoratedKey, DecoratedKey> readKeyRange(Descriptor descriptor, IPartitioner partitioner) throws IOException
+ {
+ return PartitionIndex.readFirstAndLastKey(descriptor.fileFor(Components.PARTITION_INDEX), partitioner);
+ }
+
+ @Override
+ public Class<BtiTableReader> getReaderClass()
+ {
+ return BtiTableReader.class;
+ }
+ }
+
+ static class BtiTableWriterFactory implements SSTableWriterFactory<BtiTableWriter, BtiTableWriter.Builder>
+ {
+ @Override
+ public BtiTableWriter.Builder builder(Descriptor descriptor)
+ {
+ return new BtiTableWriter.Builder(descriptor);
+ }
+
+ @Override
+ public long estimateSize(SSTableWriter.SSTableSizeParameters parameters)
+ {
+ return (long) ((parameters.partitionCount() // index entries
+ + parameters.partitionCount() // keys in data file
+ + parameters.dataSize()) // data
+ * 1.2); // bloom filter and row index overhead
+ }
+ }
+
+ // versions are denoted as [major][minor]. Minor versions must be forward-compatible:
+ // new fields are allowed in e.g. the metadata component, but fields can't be removed
+ // or have their size changed.
+ //
+ static class BtiVersion extends Version
+ {
+ public static final String current_version = "da";
+ public static final String earliest_supported_version = "ca";
+
+ // aa (DSE 6.0): trie index format
Review Comment:
I think these descriptions for DSE can be removed ,although dse and apache cassandra may have some in common, but I think developers may do not really know the version or sstable version for DSE.
some descriptions for apache cassandra sstable may be more suitable。
##########
src/java/org/apache/cassandra/io/compress/CompressedSequentialWriter.java:
##########
@@ -337,6 +337,41 @@ private void seekToChunkStart()
}
}
+ // Page management using chunk boundaries
Review Comment:
What does line 340 means ? a comment for method "maxBytesInPage()" ？
##########
src/java/org/apache/cassandra/io/sstable/format/bti/BtiFormat.java:
##########
@@ -0,0 +1,490 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.cassandra.io.sstable.format.bti;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Set;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.collect.Lists;
+import com.google.common.collect.Sets;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.cassandra.db.ColumnFamilyStore;
+import org.apache.cassandra.db.DecoratedKey;
+import org.apache.cassandra.db.lifecycle.LifecycleTransaction;
+import org.apache.cassandra.dht.IPartitioner;
+import org.apache.cassandra.io.sstable.Component;
+import org.apache.cassandra.io.sstable.Descriptor;
+import org.apache.cassandra.io.sstable.GaugeProvider;
+import org.apache.cassandra.io.sstable.IScrubber;
+import org.apache.cassandra.io.sstable.MetricsProviders;
+import org.apache.cassandra.io.sstable.SSTable;
+import org.apache.cassandra.io.sstable.filter.BloomFilterMetrics;
+import org.apache.cassandra.io.sstable.format.AbstractSSTableFormat;
+import org.apache.cassandra.io.sstable.format.SSTableFormat;
+import org.apache.cassandra.io.sstable.format.SSTableReader;
+import org.apache.cassandra.io.sstable.format.SSTableReaderLoadingBuilder;
+import org.apache.cassandra.io.sstable.format.SSTableWriter;
+import org.apache.cassandra.io.sstable.format.SortedTableScrubber;
+import org.apache.cassandra.io.sstable.format.Version;
+import org.apache.cassandra.net.MessagingService;
+import org.apache.cassandra.schema.TableMetadataRef;
+import org.apache.cassandra.utils.JVMStabilityInspector;
+import org.apache.cassandra.utils.OutputHandler;
+import org.apache.cassandra.utils.Pair;
+
+/**
+ * Bigtable format with trie indices
+ */
+public class BtiFormat extends AbstractSSTableFormat<BtiTableReader, BtiTableWriter>
+{
+ private final static Logger logger = LoggerFactory.getLogger(BtiFormat.class);
+
+ public static final BtiFormat instance = new BtiFormat();
+
+ public static final Version latestVersion = new BtiVersion(BtiVersion.current_version);
+ static final BtiTableReaderFactory readerFactory = new BtiTableReaderFactory();
+ static final BtiTableWriterFactory writerFactory = new BtiTableWriterFactory();
+
+ public static class Components extends AbstractSSTableFormat.Components
+ {
+ public static class Types extends AbstractSSTableFormat.Components.Types
+ {
+ public static final Component.Type PARTITION_INDEX = Component.Type.createSingleton("PARTITION_INDEX", "Partitions.db", BtiFormat.class);
+ public static final Component.Type ROW_INDEX = Component.Type.createSingleton("ROW_INDEX", "Rows.db", BtiFormat.class);
+ }
+
+ public final static Component PARTITION_INDEX = Types.PARTITION_INDEX.getSingleton();
+
+ public final static Component ROW_INDEX = Types.ROW_INDEX.getSingleton();
+
+ private final static Set<Component> STREAMING_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ STATS,
+ COMPRESSION_INFO,
+ FILTER,
+ DIGEST,
+ CRC);
+
+ private final static Set<Component> PRIMARY_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX);
+
+ private final static Set<Component> MUTABLE_COMPONENTS = ImmutableSet.of(STATS);
+
+ private static final Set<Component> UPLOAD_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ COMPRESSION_INFO,
+ STATS);
+
+ private static final Set<Component> BATCH_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ COMPRESSION_INFO,
+ FILTER,
+ STATS);
+
+ private final static Set<Component> ALL_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ STATS,
+ COMPRESSION_INFO,
+ FILTER,
+ DIGEST,
+ CRC,
+ TOC);
+
+ private final static Set<Component> GENERATED_ON_LOAD_COMPONENTS = ImmutableSet.of(FILTER);
+ }
+
+
+ private BtiFormat()
+ {
+
+ }
+
+ public static BtiFormat getInstance()
+ {
+ return instance;
+ }
+
+ public static boolean isDefault()
+ {
+ return getInstance().getType() == Type.current();
+ }
+
+ @Override
+ public Version getLatestVersion()
+ {
+ return latestVersion;
+ }
+
+ @Override
+ public Version getVersion(String version)
+ {
+ return new BtiVersion(version);
+ }
+
+ @Override
+ public BtiTableWriterFactory getWriterFactory()
+ {
+ return writerFactory;
+ }
+
+ @Override
+ public BtiTableReaderFactory getReaderFactory()
+ {
+ return readerFactory;
+ }
+
+ @Override
+ public Set<Component> streamingComponents()
+ {
+ return Components.STREAMING_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> primaryComponents()
+ {
+ return Components.PRIMARY_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> batchComponents()
+ {
+ return Components.BATCH_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> uploadComponents()
+ {
+ return Components.UPLOAD_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> mutableComponents()
+ {
+ return Components.MUTABLE_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> allComponents()
+ {
+ return Components.ALL_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> generatedOnLoadComponents()
+ {
+ return Components.GENERATED_ON_LOAD_COMPONENTS;
+ }
+
+ @Override
+ public SSTableFormat.KeyCacheValueSerializer<BtiTableReader, TrieIndexEntry> getKeyCacheValueSerializer()
+ {
+ throw new AssertionError("BTI sstables do not use key cache");
+ }
+
+ @Override
+ public IScrubber getScrubber(ColumnFamilyStore cfs, LifecycleTransaction transaction, OutputHandler outputHandler, IScrubber.Options options)
+ {
+ Preconditions.checkArgument(cfs.metadata().equals(transaction.onlyOne().metadata()));
+ return new BtiTableScrubber(cfs, transaction, outputHandler, options);
+ }
+
+ @Override
+ public BtiTableReader cast(SSTableReader sstr)
+ {
+ return (BtiTableReader) sstr;
+ }
+
+ @Override
+ public BtiTableWriter cast(SSTableWriter sstw)
+ {
+ return (BtiTableWriter) sstw;
+ }
+
+ @Override
+ public MetricsProviders getFormatSpecificMetricsProviders()
+ {
+ return BtiTableSpecificMetricsProviders.instance;
+ }
+
+ @Override
+ public void deleteOrphanedComponents(Descriptor descriptor, Set<Component> components)
+ {
+ SortedTableScrubber.deleteOrphanedComponents(descriptor, components);
+ }
+
+ private void delete(Descriptor desc, List<Component> components)
+ {
+ logger.info("Deleting sstable: {}", desc);
+
+ if (components.remove(SSTableFormat.Components.DATA))
+ components.add(0, SSTableFormat.Components.DATA); // DATA component should be first
+
+ for (Component component : components)
+ {
+ logger.trace("Deleting component {} of {}", component, desc);
+ desc.fileFor(component).deleteIfExists();
+ }
+ }
+
+ @Override
+ public void delete(Descriptor desc)
+ {
+ try
+ {
+ delete(desc, Lists.newArrayList(Sets.intersection(allComponents(), desc.discoverComponents())));
+ }
+ catch (Throwable t)
+ {
+ JVMStabilityInspector.inspectThrowable(t);
+ }
+ }
+
+ static class BtiTableReaderFactory implements SSTableReaderFactory<BtiTableReader, BtiTableReader.Builder>
+ {
+ @Override
+ public SSTableReader.Builder<BtiTableReader, BtiTableReader.Builder> builder(Descriptor descriptor)
+ {
+ return new BtiTableReader.Builder(descriptor);
+ }
+
+ @Override
+ public SSTableReaderLoadingBuilder<BtiTableReader, BtiTableReader.Builder> loadingBuilder(Descriptor descriptor, TableMetadataRef tableMetadataRef, Set<Component> components)
+ {
+ return new BtiTableReaderLoadingBuilder(new SSTable.Builder<>(descriptor).setTableMetadataRef(tableMetadataRef)
+ .setComponents(components));
+ }
+
+ @Override
+ public Pair<DecoratedKey, DecoratedKey> readKeyRange(Descriptor descriptor, IPartitioner partitioner) throws IOException
+ {
+ return PartitionIndex.readFirstAndLastKey(descriptor.fileFor(Components.PARTITION_INDEX), partitioner);
+ }
+
+ @Override
+ public Class<BtiTableReader> getReaderClass()
+ {
+ return BtiTableReader.class;
+ }
+ }
+
+ static class BtiTableWriterFactory implements SSTableWriterFactory<BtiTableWriter, BtiTableWriter.Builder>
+ {
+ @Override
+ public BtiTableWriter.Builder builder(Descriptor descriptor)
+ {
+ return new BtiTableWriter.Builder(descriptor);
+ }
+
+ @Override
+ public long estimateSize(SSTableWriter.SSTableSizeParameters parameters)
+ {
+ return (long) ((parameters.partitionCount() // index entries
+ + parameters.partitionCount() // keys in data file
+ + parameters.dataSize()) // data
+ * 1.2); // bloom filter and row index overhead
+ }
+ }
+
+ // versions are denoted as [major][minor]. Minor versions must be forward-compatible:
+ // new fields are allowed in e.g. the metadata component, but fields can't be removed
+ // or have their size changed.
+ //
+ static class BtiVersion extends Version
+ {
+ public static final String current_version = "da";
+ public static final String earliest_supported_version = "ca";
+
+ // aa (DSE 6.0): trie index format
+ // ab (DSE pre-6.8): ILLEGAL - handled as 'b' (predates 'ba'). Pre-GA "LABS" releases of DSE 6.8 used this
+ // sstable version.
+ // ac (DSE 6.0.11, 6.7.6): corrected sstable min/max clustering (DB-3691/CASSANDRA-14861)
+ // ad (DSE 6.0.14, 6.7.11): added hostId of the node from which the sstable originated (DB-4629)
+ // b (DSE early 6.8 "LABS") has some of 6.8 features but not all
+ // ba (DSE 6.8): encrypted indices and metadata
+ // new BloomFilter serialization format
+ // add incremental NodeSync information to metadata
+ // improved min/max clustering representation
+ // presence marker for partition level deletions
+ // bb (DSE 6.8.5): added hostId of the node from which the sstable originated (DB-4629)
+ // versions aa-bz are not supported in OSS
+ // ca (DSE-DB aka Stargazer based on OSS 4.0): all OSS fields + all DSE fields in DSE serialization format
+ // da - same as ca but in OSS serialization format
+ // NOTE: when adding a new version, please add that to LegacySSTableTest, too.
+
+ private final boolean isLatestVersion;
+
+ /**
+ * DB-2648/CASSANDRA-9067: DSE 6.8/OSS 4.0 bloom filter representation changed (bitset data is no longer stored
+ * as BIG_ENDIAN longs, which avoids some redundant bit twiddling).
+ */
+ private final int correspondingMessagingVersion;
+
+ private final boolean hasOldBfFormat;
+ private final boolean hasAccurateMinMax;
+ private final boolean hasImprovedMinMax;
+ private final boolean hasKeyRange;
+ private final boolean hasPartitionLevelDeletionsPresenceMarker;
+ private final boolean hasOriginatingHostId;
+
+ BtiVersion(String version)
+ {
+ super(instance, version = mapAb(version));
+
+ isLatestVersion = version.compareTo(current_version) == 0;
+ hasOldBfFormat = version.compareTo("b") < 0;
+ hasAccurateMinMax = version.compareTo("ac") >= 0;
+ hasOriginatingHostId = version.matches("(a[d-z])|(b[b-z])") || version.compareTo("ca") >= 0;
+ hasImprovedMinMax = version.compareTo("ba") >= 0;
+ hasKeyRange = version.compareTo("da") >= 0;
+ hasPartitionLevelDeletionsPresenceMarker = version.compareTo("ba") >= 0;
+ correspondingMessagingVersion = MessagingService.VERSION_40;
+ }
+
+ // this is for the ab version which was used in the LABS, and then has been renamed to ba
Review Comment:
what does this comment LABS mean ?
##########
src/java/org/apache/cassandra/io/sstable/format/bti/BtiFormat.java:
##########
@@ -0,0 +1,490 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.cassandra.io.sstable.format.bti;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Set;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.collect.Lists;
+import com.google.common.collect.Sets;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.cassandra.db.ColumnFamilyStore;
+import org.apache.cassandra.db.DecoratedKey;
+import org.apache.cassandra.db.lifecycle.LifecycleTransaction;
+import org.apache.cassandra.dht.IPartitioner;
+import org.apache.cassandra.io.sstable.Component;
+import org.apache.cassandra.io.sstable.Descriptor;
+import org.apache.cassandra.io.sstable.GaugeProvider;
+import org.apache.cassandra.io.sstable.IScrubber;
+import org.apache.cassandra.io.sstable.MetricsProviders;
+import org.apache.cassandra.io.sstable.SSTable;
+import org.apache.cassandra.io.sstable.filter.BloomFilterMetrics;
+import org.apache.cassandra.io.sstable.format.AbstractSSTableFormat;
+import org.apache.cassandra.io.sstable.format.SSTableFormat;
+import org.apache.cassandra.io.sstable.format.SSTableReader;
+import org.apache.cassandra.io.sstable.format.SSTableReaderLoadingBuilder;
+import org.apache.cassandra.io.sstable.format.SSTableWriter;
+import org.apache.cassandra.io.sstable.format.SortedTableScrubber;
+import org.apache.cassandra.io.sstable.format.Version;
+import org.apache.cassandra.net.MessagingService;
+import org.apache.cassandra.schema.TableMetadataRef;
+import org.apache.cassandra.utils.JVMStabilityInspector;
+import org.apache.cassandra.utils.OutputHandler;
+import org.apache.cassandra.utils.Pair;
+
+/**
+ * Bigtable format with trie indices
+ */
+public class BtiFormat extends AbstractSSTableFormat<BtiTableReader, BtiTableWriter>
+{
+ private final static Logger logger = LoggerFactory.getLogger(BtiFormat.class);
+
+ public static final BtiFormat instance = new BtiFormat();
+
+ public static final Version latestVersion = new BtiVersion(BtiVersion.current_version);
+ static final BtiTableReaderFactory readerFactory = new BtiTableReaderFactory();
+ static final BtiTableWriterFactory writerFactory = new BtiTableWriterFactory();
+
+ public static class Components extends AbstractSSTableFormat.Components
+ {
+ public static class Types extends AbstractSSTableFormat.Components.Types
+ {
+ public static final Component.Type PARTITION_INDEX = Component.Type.createSingleton("PARTITION_INDEX", "Partitions.db", BtiFormat.class);
+ public static final Component.Type ROW_INDEX = Component.Type.createSingleton("ROW_INDEX", "Rows.db", BtiFormat.class);
+ }
+
+ public final static Component PARTITION_INDEX = Types.PARTITION_INDEX.getSingleton();
+
+ public final static Component ROW_INDEX = Types.ROW_INDEX.getSingleton();
+
+ private final static Set<Component> STREAMING_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ STATS,
+ COMPRESSION_INFO,
+ FILTER,
+ DIGEST,
+ CRC);
+
+ private final static Set<Component> PRIMARY_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX);
+
+ private final static Set<Component> MUTABLE_COMPONENTS = ImmutableSet.of(STATS);
+
+ private static final Set<Component> UPLOAD_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ COMPRESSION_INFO,
+ STATS);
+
+ private static final Set<Component> BATCH_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ COMPRESSION_INFO,
+ FILTER,
+ STATS);
+
+ private final static Set<Component> ALL_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ STATS,
+ COMPRESSION_INFO,
+ FILTER,
+ DIGEST,
+ CRC,
+ TOC);
+
+ private final static Set<Component> GENERATED_ON_LOAD_COMPONENTS = ImmutableSet.of(FILTER);
+ }
+
+
+ private BtiFormat()
+ {
+
+ }
+
+ public static BtiFormat getInstance()
+ {
+ return instance;
+ }
+
+ public static boolean isDefault()
+ {
+ return getInstance().getType() == Type.current();
+ }
+
+ @Override
+ public Version getLatestVersion()
+ {
+ return latestVersion;
+ }
+
+ @Override
+ public Version getVersion(String version)
+ {
+ return new BtiVersion(version);
+ }
+
+ @Override
+ public BtiTableWriterFactory getWriterFactory()
+ {
+ return writerFactory;
+ }
+
+ @Override
+ public BtiTableReaderFactory getReaderFactory()
+ {
+ return readerFactory;
+ }
+
+ @Override
+ public Set<Component> streamingComponents()
+ {
+ return Components.STREAMING_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> primaryComponents()
+ {
+ return Components.PRIMARY_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> batchComponents()
+ {
+ return Components.BATCH_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> uploadComponents()
+ {
+ return Components.UPLOAD_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> mutableComponents()
+ {
+ return Components.MUTABLE_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> allComponents()
+ {
+ return Components.ALL_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> generatedOnLoadComponents()
+ {
+ return Components.GENERATED_ON_LOAD_COMPONENTS;
+ }
+
+ @Override
+ public SSTableFormat.KeyCacheValueSerializer<BtiTableReader, TrieIndexEntry> getKeyCacheValueSerializer()
+ {
+ throw new AssertionError("BTI sstables do not use key cache");
+ }
+
+ @Override
+ public IScrubber getScrubber(ColumnFamilyStore cfs, LifecycleTransaction transaction, OutputHandler outputHandler, IScrubber.Options options)
+ {
+ Preconditions.checkArgument(cfs.metadata().equals(transaction.onlyOne().metadata()));
+ return new BtiTableScrubber(cfs, transaction, outputHandler, options);
+ }
+
+ @Override
+ public BtiTableReader cast(SSTableReader sstr)
+ {
+ return (BtiTableReader) sstr;
+ }
+
+ @Override
+ public BtiTableWriter cast(SSTableWriter sstw)
+ {
+ return (BtiTableWriter) sstw;
+ }
+
+ @Override
+ public MetricsProviders getFormatSpecificMetricsProviders()
+ {
+ return BtiTableSpecificMetricsProviders.instance;
+ }
+
+ @Override
+ public void deleteOrphanedComponents(Descriptor descriptor, Set<Component> components)
+ {
+ SortedTableScrubber.deleteOrphanedComponents(descriptor, components);
+ }
+
+ private void delete(Descriptor desc, List<Component> components)
+ {
+ logger.info("Deleting sstable: {}", desc);
+
+ if (components.remove(SSTableFormat.Components.DATA))
+ components.add(0, SSTableFormat.Components.DATA); // DATA component should be first
+
+ for (Component component : components)
+ {
+ logger.trace("Deleting component {} of {}", component, desc);
+ desc.fileFor(component).deleteIfExists();
+ }
+ }
+
+ @Override
+ public void delete(Descriptor desc)
+ {
+ try
+ {
+ delete(desc, Lists.newArrayList(Sets.intersection(allComponents(), desc.discoverComponents())));
+ }
+ catch (Throwable t)
+ {
+ JVMStabilityInspector.inspectThrowable(t);
+ }
+ }
+
+ static class BtiTableReaderFactory implements SSTableReaderFactory<BtiTableReader, BtiTableReader.Builder>
+ {
+ @Override
+ public SSTableReader.Builder<BtiTableReader, BtiTableReader.Builder> builder(Descriptor descriptor)
+ {
+ return new BtiTableReader.Builder(descriptor);
+ }
+
+ @Override
+ public SSTableReaderLoadingBuilder<BtiTableReader, BtiTableReader.Builder> loadingBuilder(Descriptor descriptor, TableMetadataRef tableMetadataRef, Set<Component> components)
+ {
+ return new BtiTableReaderLoadingBuilder(new SSTable.Builder<>(descriptor).setTableMetadataRef(tableMetadataRef)
+ .setComponents(components));
+ }
+
+ @Override
+ public Pair<DecoratedKey, DecoratedKey> readKeyRange(Descriptor descriptor, IPartitioner partitioner) throws IOException
+ {
+ return PartitionIndex.readFirstAndLastKey(descriptor.fileFor(Components.PARTITION_INDEX), partitioner);
+ }
+
+ @Override
+ public Class<BtiTableReader> getReaderClass()
+ {
+ return BtiTableReader.class;
+ }
+ }
+
+ static class BtiTableWriterFactory implements SSTableWriterFactory<BtiTableWriter, BtiTableWriter.Builder>
+ {
+ @Override
+ public BtiTableWriter.Builder builder(Descriptor descriptor)
+ {
+ return new BtiTableWriter.Builder(descriptor);
+ }
+
+ @Override
+ public long estimateSize(SSTableWriter.SSTableSizeParameters parameters)
+ {
+ return (long) ((parameters.partitionCount() // index entries
+ + parameters.partitionCount() // keys in data file
+ + parameters.dataSize()) // data
+ * 1.2); // bloom filter and row index overhead
+ }
+ }
+
+ // versions are denoted as [major][minor]. Minor versions must be forward-compatible:
+ // new fields are allowed in e.g. the metadata component, but fields can't be removed
+ // or have their size changed.
+ //
+ static class BtiVersion extends Version
+ {
+ public static final String current_version = "da";
+ public static final String earliest_supported_version = "ca";
+
+ // aa (DSE 6.0): trie index format
Review Comment:
I think as this sstable format may be used in dse for long time ,so these comments are left, in my mind, we may need to add comments to identify this file format, as this is the first time we introduce this sstable file format to apache cassandra, so we may do not need to describle the differences betweetn dse versions for Trie-indexed sstable, only need to add some comments about the reason this file format has now evolved to the current committed version.
##########
src/java/org/apache/cassandra/io/sstable/format/bti/BtiFormat.java:
##########
@@ -0,0 +1,490 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.cassandra.io.sstable.format.bti;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Set;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.collect.Lists;
+import com.google.common.collect.Sets;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.cassandra.db.ColumnFamilyStore;
+import org.apache.cassandra.db.DecoratedKey;
+import org.apache.cassandra.db.lifecycle.LifecycleTransaction;
+import org.apache.cassandra.dht.IPartitioner;
+import org.apache.cassandra.io.sstable.Component;
+import org.apache.cassandra.io.sstable.Descriptor;
+import org.apache.cassandra.io.sstable.GaugeProvider;
+import org.apache.cassandra.io.sstable.IScrubber;
+import org.apache.cassandra.io.sstable.MetricsProviders;
+import org.apache.cassandra.io.sstable.SSTable;
+import org.apache.cassandra.io.sstable.filter.BloomFilterMetrics;
+import org.apache.cassandra.io.sstable.format.AbstractSSTableFormat;
+import org.apache.cassandra.io.sstable.format.SSTableFormat;
+import org.apache.cassandra.io.sstable.format.SSTableReader;
+import org.apache.cassandra.io.sstable.format.SSTableReaderLoadingBuilder;
+import org.apache.cassandra.io.sstable.format.SSTableWriter;
+import org.apache.cassandra.io.sstable.format.SortedTableScrubber;
+import org.apache.cassandra.io.sstable.format.Version;
+import org.apache.cassandra.net.MessagingService;
+import org.apache.cassandra.schema.TableMetadataRef;
+import org.apache.cassandra.utils.JVMStabilityInspector;
+import org.apache.cassandra.utils.OutputHandler;
+import org.apache.cassandra.utils.Pair;
+
+/**
+ * Bigtable format with trie indices
+ */
+public class BtiFormat extends AbstractSSTableFormat<BtiTableReader, BtiTableWriter>
+{
+ private final static Logger logger = LoggerFactory.getLogger(BtiFormat.class);
+
+ public static final BtiFormat instance = new BtiFormat();
+
+ public static final Version latestVersion = new BtiVersion(BtiVersion.current_version);
+ static final BtiTableReaderFactory readerFactory = new BtiTableReaderFactory();
+ static final BtiTableWriterFactory writerFactory = new BtiTableWriterFactory();
+
+ public static class Components extends AbstractSSTableFormat.Components
+ {
+ public static class Types extends AbstractSSTableFormat.Components.Types
+ {
+ public static final Component.Type PARTITION_INDEX = Component.Type.createSingleton("PARTITION_INDEX", "Partitions.db", BtiFormat.class);
+ public static final Component.Type ROW_INDEX = Component.Type.createSingleton("ROW_INDEX", "Rows.db", BtiFormat.class);
+ }
+
+ public final static Component PARTITION_INDEX = Types.PARTITION_INDEX.getSingleton();
+
+ public final static Component ROW_INDEX = Types.ROW_INDEX.getSingleton();
+
+ private final static Set<Component> STREAMING_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ STATS,
+ COMPRESSION_INFO,
+ FILTER,
+ DIGEST,
+ CRC);
+
+ private final static Set<Component> PRIMARY_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX);
+
+ private final static Set<Component> MUTABLE_COMPONENTS = ImmutableSet.of(STATS);
+
+ private static final Set<Component> UPLOAD_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ COMPRESSION_INFO,
+ STATS);
+
+ private static final Set<Component> BATCH_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ COMPRESSION_INFO,
+ FILTER,
+ STATS);
+
+ private final static Set<Component> ALL_COMPONENTS = ImmutableSet.of(DATA,
+ PARTITION_INDEX,
+ ROW_INDEX,
+ STATS,
+ COMPRESSION_INFO,
+ FILTER,
+ DIGEST,
+ CRC,
+ TOC);
+
+ private final static Set<Component> GENERATED_ON_LOAD_COMPONENTS = ImmutableSet.of(FILTER);
+ }
+
+
+ private BtiFormat()
+ {
+
+ }
+
+ public static BtiFormat getInstance()
+ {
+ return instance;
+ }
+
+ public static boolean isDefault()
+ {
+ return getInstance().getType() == Type.current();
+ }
+
+ @Override
+ public Version getLatestVersion()
+ {
+ return latestVersion;
+ }
+
+ @Override
+ public Version getVersion(String version)
+ {
+ return new BtiVersion(version);
+ }
+
+ @Override
+ public BtiTableWriterFactory getWriterFactory()
+ {
+ return writerFactory;
+ }
+
+ @Override
+ public BtiTableReaderFactory getReaderFactory()
+ {
+ return readerFactory;
+ }
+
+ @Override
+ public Set<Component> streamingComponents()
+ {
+ return Components.STREAMING_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> primaryComponents()
+ {
+ return Components.PRIMARY_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> batchComponents()
+ {
+ return Components.BATCH_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> uploadComponents()
+ {
+ return Components.UPLOAD_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> mutableComponents()
+ {
+ return Components.MUTABLE_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> allComponents()
+ {
+ return Components.ALL_COMPONENTS;
+ }
+
+ @Override
+ public Set<Component> generatedOnLoadComponents()
+ {
+ return Components.GENERATED_ON_LOAD_COMPONENTS;
+ }
+
+ @Override
+ public SSTableFormat.KeyCacheValueSerializer<BtiTableReader, TrieIndexEntry> getKeyCacheValueSerializer()
+ {
+ throw new AssertionError("BTI sstables do not use key cache");
+ }
+
+ @Override
+ public IScrubber getScrubber(ColumnFamilyStore cfs, LifecycleTransaction transaction, OutputHandler outputHandler, IScrubber.Options options)
+ {
+ Preconditions.checkArgument(cfs.metadata().equals(transaction.onlyOne().metadata()));
+ return new BtiTableScrubber(cfs, transaction, outputHandler, options);
+ }
+
+ @Override
+ public BtiTableReader cast(SSTableReader sstr)
+ {
+ return (BtiTableReader) sstr;
+ }
+
+ @Override
+ public BtiTableWriter cast(SSTableWriter sstw)
+ {
+ return (BtiTableWriter) sstw;
+ }
+
+ @Override
+ public MetricsProviders getFormatSpecificMetricsProviders()
+ {
+ return BtiTableSpecificMetricsProviders.instance;
+ }
+
+ @Override
+ public void deleteOrphanedComponents(Descriptor descriptor, Set<Component> components)
+ {
+ SortedTableScrubber.deleteOrphanedComponents(descriptor, components);
+ }
+
+ private void delete(Descriptor desc, List<Component> components)
+ {
+ logger.info("Deleting sstable: {}", desc);
+
+ if (components.remove(SSTableFormat.Components.DATA))
+ components.add(0, SSTableFormat.Components.DATA); // DATA component should be first
+
+ for (Component component : components)
+ {
+ logger.trace("Deleting component {} of {}", component, desc);
+ desc.fileFor(component).deleteIfExists();
+ }
+ }
+
+ @Override
+ public void delete(Descriptor desc)
+ {
+ try
+ {
+ delete(desc, Lists.newArrayList(Sets.intersection(allComponents(), desc.discoverComponents())));
+ }
+ catch (Throwable t)
+ {
+ JVMStabilityInspector.inspectThrowable(t);
+ }
+ }
+
+ static class BtiTableReaderFactory implements SSTableReaderFactory<BtiTableReader, BtiTableReader.Builder>
+ {
+ @Override
+ public SSTableReader.Builder<BtiTableReader, BtiTableReader.Builder> builder(Descriptor descriptor)
+ {
+ return new BtiTableReader.Builder(descriptor);
+ }
+
+ @Override
+ public SSTableReaderLoadingBuilder<BtiTableReader, BtiTableReader.Builder> loadingBuilder(Descriptor descriptor, TableMetadataRef tableMetadataRef, Set<Component> components)
+ {
+ return new BtiTableReaderLoadingBuilder(new SSTable.Builder<>(descriptor).setTableMetadataRef(tableMetadataRef)
+ .setComponents(components));
+ }
+
+ @Override
+ public Pair<DecoratedKey, DecoratedKey> readKeyRange(Descriptor descriptor, IPartitioner partitioner) throws IOException
+ {
+ return PartitionIndex.readFirstAndLastKey(descriptor.fileFor(Components.PARTITION_INDEX), partitioner);
+ }
+
+ @Override
+ public Class<BtiTableReader> getReaderClass()
+ {
+ return BtiTableReader.class;
+ }
+ }
+
+ static class BtiTableWriterFactory implements SSTableWriterFactory<BtiTableWriter, BtiTableWriter.Builder>
+ {
+ @Override
+ public BtiTableWriter.Builder builder(Descriptor descriptor)
+ {
+ return new BtiTableWriter.Builder(descriptor);
+ }
+
+ @Override
+ public long estimateSize(SSTableWriter.SSTableSizeParameters parameters)
+ {
+ return (long) ((parameters.partitionCount() // index entries
+ + parameters.partitionCount() // keys in data file
+ + parameters.dataSize()) // data
+ * 1.2); // bloom filter and row index overhead
+ }
+ }
+
+ // versions are denoted as [major][minor]. Minor versions must be forward-compatible:
+ // new fields are allowed in e.g. the metadata component, but fields can't be removed
+ // or have their size changed.
+ //
+ static class BtiVersion extends Version
+ {
+ public static final String current_version = "da";
+ public static final String earliest_supported_version = "ca";
+
+ // aa (DSE 6.0): trie index format
Review Comment:
as these versions may be used int the construct function of BtiVersion, and as cassandra do not have these sstable versions as dse have ,so I think we need to modify the code here to adapt to the existing file format(version) of apache cassandra
##########
src/java/org/apache/cassandra/io/sstable/format/bti/BtiTableVerifier.java:
##########
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.cassandra.io.sstable.format.bti;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Collections;
+import java.util.List;
+import java.util.Objects;
+
+import com.google.common.base.Throwables;
+
+import org.apache.cassandra.db.ColumnFamilyStore;
+import org.apache.cassandra.db.DecoratedKey;
+import org.apache.cassandra.db.compaction.CompactionInterruptedException;
+import org.apache.cassandra.db.rows.UnfilteredRowIterator;
+import org.apache.cassandra.dht.LocalPartitioner;
+import org.apache.cassandra.dht.Range;
+import org.apache.cassandra.dht.Token;
+import org.apache.cassandra.io.sstable.CorruptSSTableException;
+import org.apache.cassandra.io.sstable.IVerifier;
+import org.apache.cassandra.io.sstable.KeyReader;
+import org.apache.cassandra.io.sstable.SSTableIdentityIterator;
+import org.apache.cassandra.io.sstable.format.SSTableReader;
+import org.apache.cassandra.io.sstable.format.SortedTableVerifier;
+import org.apache.cassandra.utils.ByteBufferUtil;
+import org.apache.cassandra.utils.FBUtilities;
+import org.apache.cassandra.utils.OutputHandler;
+
+public class BtiTableVerifier extends SortedTableVerifier<BtiTableReader> implements IVerifier
+{
+ public BtiTableVerifier(ColumnFamilyStore cfs, BtiTableReader sstable, OutputHandler outputHandler, boolean isOffline, Options options)
+ {
+ super(cfs, sstable, outputHandler, isOffline, options);
+ }
+
+ public void verify()
+ {
+ verifySSTableVersion();
+
+ verifySSTableMetadata();
+
+ verifyIndex();
+
+ verifyBloomFilter();
+
+ if (options.checkOwnsTokens && !isOffline && !(cfs.getPartitioner() instanceof LocalPartitioner))
+ {
+ if (verifyOwnedRanges() == 0)
+ return;
+ }
+
+ if (options.quick)
+ return;
+
+ if (verifyDigest() && !options.extendedVerification)
+ return;
+
+ verifySSTable();
+
+ outputHandler.output("Verify of %s succeeded. All %d rows read successfully", sstable, goodRows);
+ }
+
+ private void verifySSTable()
+ {
+ long rowStart;
Review Comment:
I think rowStart can be move to line 95 in the while loop
##########
src/java/org/apache/cassandra/io/compress/CompressedSequentialWriter.java:
##########
@@ -337,6 +337,41 @@ private void seekToChunkStart()
}
}
+ // Page management using chunk boundaries
Review Comment:
What does line 340 means ? a comment for method "maxBytesInPage()" ？
##########
src/java/org/apache/cassandra/io/sstable/format/bti/BtiTableScrubber.java:
##########
@@ -0,0 +1,303 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.cassandra.io.sstable.format.bti;
+
+import java.io.IOError;
+import java.io.IOException;
+import java.nio.ByteBuffer;
+
+import org.apache.cassandra.db.ColumnFamilyStore;
+import org.apache.cassandra.db.DecoratedKey;
+import org.apache.cassandra.db.TypeSizes;
+import org.apache.cassandra.db.compaction.CompactionInterruptedException;
+import org.apache.cassandra.db.lifecycle.LifecycleTransaction;
+import org.apache.cassandra.db.rows.UnfilteredRowIterator;
+import org.apache.cassandra.db.rows.UnfilteredRowIterators;
+import org.apache.cassandra.io.sstable.IScrubber;
+import org.apache.cassandra.io.sstable.SSTableRewriter;
+import org.apache.cassandra.io.sstable.format.SortedTableScrubber;
+import org.apache.cassandra.io.sstable.format.bti.BtiFormat.Components;
+import org.apache.cassandra.io.util.FileUtils;
+import org.apache.cassandra.utils.ByteBufferUtil;
+import org.apache.cassandra.utils.FBUtilities;
+import org.apache.cassandra.utils.OutputHandler;
+import org.apache.cassandra.utils.Throwables;
+
+public class BtiTableScrubber extends SortedTableScrubber<BtiTableReader> implements IScrubber
+{
+ private final boolean isIndex;
+ private ScrubPartitionIterator indexIterator;
+
+ public BtiTableScrubber(ColumnFamilyStore cfs,
+ LifecycleTransaction transaction,
+ OutputHandler outputHandler,
+ IScrubber.Options options)
+ {
+ super(cfs, transaction, outputHandler, options);
+
+ boolean hasIndexFile = sstable.getComponents().contains(Components.PARTITION_INDEX);
+ this.isIndex = cfs.isIndex();
+ if (!hasIndexFile)
+ {
+ // if there's any corruption in the -Data.db then partitions can't be skipped over. but it's worth a shot.
+ outputHandler.warn("Missing index component");
+ }
+
+ try
+ {
+ this.indexIterator = hasIndexFile
+ ? openIndexIterator()
+ : null;
+ }
+ catch (RuntimeException ex)
+ {
+ outputHandler.warn("Detected corruption in the index file - cannot open index iterator", ex);
+ }
+ }
+
+ private ScrubPartitionIterator openIndexIterator()
+ {
+ try
+ {
+ return sstable.scrubPartitionsIterator();
+ }
+ catch (IOException e)
+ {
+ outputHandler.warn("Index is unreadable.");
Review Comment:
I think the message is not detailed enough， and the exception stack can be added.
##########
conf/cassandra.yaml:
##########
@@ -1924,8 +1924,14 @@ drop_compact_storage_enabled: false
# which is used in some serialization to denote the format type in a compact way (such as local key cache); and 'name'
# which will be used to recognize the format type - in particular that name will be used in sstable file names and in
# stream headers so the name has to be the same for the same format across all the nodes in the cluster.
+# The first entry in this list is the format that will be used for newly-created SSTables. The other formats given
+# will be used to read any SSTables present in the data directories or streamed.
sstable_formats:
- class_name: org.apache.cassandra.io.sstable.format.big.BigFormat
parameters:
id: 0
name: big
+ - class_name: org.apache.cassandra.io.sstable.format.bti.BtiFormat
+ parameters:
+ id: 1
+ name: bti
Review Comment:
This seems introduce in CASSANDRA-17056, aggree with "Hard to know without actually writing the code" , and I think at the very least we should add more detailed comments to explain the useage of "sstable_formats" .
I think it is not enough for users to configure this options if they do not read the code, "what does the id mean ? " , "Can I set the id to 100? ", "what does name mean? "
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org