You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Ruediger Pluem <rp...@apache.org> on 2006/05/04 22:30:06 UTC

Re: svn commit: r399668 - in /httpd/httpd/trunk: CHANGES modules/filters/mod_charset_lite.c


On 05/04/2006 01:26 PM, wrote:
> Author: trawick

>  
> +  *) mod_charset_lite: Bypass translation when the source and dest charsets
> +     are the same.  [Jeff Trawick]

As I am not an expert on mod_charset_lite a short question:
Can this ever happen apart from a situation where the server is misconfigured
by setting CharsetDefault and CharsetSourceEnc to the same value in the configuration?

Regards

RĂ¼diger

Re: svn commit: r399668 - in /httpd/httpd/trunk: CHANGES modules/filters/mod_charset_lite.c

Posted by Ruediger Pluem <rp...@apache.org>.

On 05/04/2006 10:51 PM, Jeff Trawick wrote:

> 
> Here is the expected way to encounter that:
> 
> <Location />
> CharsetSourceEnc IBM-1047
> CharsetDefault ISO-8859-1
> </Location>
> 
> <Location /somedir/>
> # already in the right charset
> CharsetSourceEnc ISO-8859-1
> </Location>
> 
> So we shouldn't go through the motions when processing /somedir/

Understood. Thanks for explanation. So I am +1 on this for backport.

Regards

RĂ¼diger



Re: svn commit: r399668 - in /httpd/httpd/trunk: CHANGES modules/filters/mod_charset_lite.c

Posted by Jeff Trawick <tr...@gmail.com>.
On 5/4/06, Ruediger Pluem <rp...@apache.org> wrote:
>
>
> On 05/04/2006 01:26 PM, wrote:
> > Author: trawick
>
> >
> > +  *) mod_charset_lite: Bypass translation when the source and dest charsets
> > +     are the same.  [Jeff Trawick]
>
> As I am not an expert on mod_charset_lite a short question:
> Can this ever happen apart from a situation where the server is misconfigured
> by setting CharsetDefault and CharsetSourceEnc to the same value in the configuration?

Here is the expected way to encounter that:

<Location />
CharsetSourceEnc IBM-1047
CharsetDefault ISO-8859-1
</Location>

<Location /somedir/>
# already in the right charset
CharsetSourceEnc ISO-8859-1
</Location>

So we shouldn't go through the motions when processing /somedir/