You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/09/21 20:24:16 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #43038: [SPARK-45261][CORE] Fix `EventLogFileWriters` to handle `none` codec case
dongjoon-hyun opened a new pull request, #43038:
URL: https://github.com/apache/spark/pull/43038
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #43038: [SPARK-45261][CORE] Fix `EventLogFileWriters` to handle `none` as a codec
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43038:
URL: https://github.com/apache/spark/pull/43038#issuecomment-1730341665
Let me merge this `none` is only used that test case. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #43038: [SPARK-45261][CORE] Fix `EventLogFileWriters` to handle `none` as a codec
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43038:
URL: https://github.com/apache/spark/pull/43038#issuecomment-1730299378
I manually test this.
```
$ build/sbt "core/testOnly *EventLogFile*ReaderSuite*"
...
[info] RollingEventLogFilesReaderSuite:
[info] - Retrieve EventLogFileReader correctly (96 milliseconds)
[info] - get information, list event log files, zip log files - with codec None (80 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(lz4) (109 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(lzf) (44 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(snappy) (96 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(zstd) (145 milliseconds)
[info] - rolling event log files - codec None (394 milliseconds)
[info] - rolling event log files - codec Some(lz4) (91 milliseconds)
[info] - rolling event log files - codec Some(lzf) (105 milliseconds)
[info] - rolling event log files - codec Some(snappy) (117 milliseconds)
[info] - rolling event log files - codec Some(zstd) (86 milliseconds)
[info] SingleFileEventLogFileReaderSuite:
[info] - Retrieve EventLogFileReader correctly (66 milliseconds)
[info] - get information, list event log files, zip log files - with codec None (14 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(lz4) (13 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(lzf) (12 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(snappy) (12 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(zstd) (11 milliseconds)
[info] Run completed in 2 seconds, 501 milliseconds.
[info] Total number of tests run: 17
[info] Suites: completed 2, aborted 0
[info] Tests: succeeded 17, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 29 s, completed Sep 21, 2023, 2:03:02 PM
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #43038: [SPARK-45261][CORE] Fix `EventLogFileWriters` to handle `none` as a codec
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43038:
URL: https://github.com/apache/spark/pull/43038#issuecomment-1730314731
One line is added to update `SparkContext` in the consistent way. Sorry for missing this at the initial commit.
```
$ bin/spark-shell -c spark.eventLog.enabled=true -c spark.eventLog.compress=true -c spark.eventLog.compression.codec=none
Setting default log level to "WARN".
To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
23/09/21 14:16:37 WARN NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
Spark context Web UI available at http://localhost:4040
Spark context available as 'sc' (master = local[*], app id = local-1695330997677).
Spark session available as 'spark'.
Welcome to
____ __
/ __/__ ___ _____/ /__
_\ \/ _ \/ _ `/ __/ '_/
/___/ .__/\_,_/_/ /_/\_\ version 4.0.0-SNAPSHOT
/_/
Using Scala version 2.12.18 (OpenJDK 64-Bit Server VM, Java 17.0.8)
Type in expressions to have them evaluated.
Type :help for more information.
scala> :quit
max ~s:SPARK-45261 $ ls -al /tmp/spark-events/local-1695330997677
-rw-rw---- 1 dongjoon wheel 86285 Sep 21 14:16 /tmp/spark-events/local-1695330997677
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #43038: [SPARK-45261][CORE] Fix `EventLogFileWriters` to handle `none` as a codec
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43038:
URL: https://github.com/apache/spark/pull/43038#issuecomment-1730309385
Thank you, @viirya .
I did verified the relevant suite, but it seems there is some unhandled logic for `spark-shell`. Let me check more.
```
[info] RollingEventLogFilesReaderSuite:
[info] - Retrieve EventLogFileReader correctly (92 milliseconds)
[info] - get information, list event log files, zip log files - with codec None (76 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(lz4) (116 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(lzf) (49 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(snappy) (74 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(zstd) (105 milliseconds)
[info] - rolling event log files - codec None (366 milliseconds)
[info] - rolling event log files - codec Some(lz4) (86 milliseconds)
[info] - rolling event log files - codec Some(lzf) (89 milliseconds)
[info] - rolling event log files - codec Some(snappy) (96 milliseconds)
[info] - rolling event log files - codec Some(zstd) (75 milliseconds)
[info] SingleFileEventLogFileReaderSuite:
[info] - Retrieve EventLogFileReader correctly (65 milliseconds)
[info] - get information, list event log files, zip log files - with codec None (13 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(lz4) (23 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(lzf) (11 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(snappy) (12 milliseconds)
[info] - get information, list event log files, zip log files - with codec Some(zstd) (12 milliseconds)
[info] Run completed in 2 seconds, 339 milliseconds.
[info] Total number of tests run: 17
[info] Suites: completed 2, aborted 0
[info] Tests: succeeded 17, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 10 s, completed Sep 21, 2023, 2:11:43 PM
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #43038: [SPARK-45261][CORE] Fix `EventLogFileWriters` to handle `none` as a codec
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #43038: [SPARK-45261][CORE] Fix `EventLogFileWriters` to handle `none` as a codec
URL: https://github.com/apache/spark/pull/43038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org