You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/03/10 12:39:01 UTC
[GitHub] [hadoop] brfrn169 opened a new pull request #1889: HDFS-15215 The
Timestamp for longest write/read lock held log is wrong
brfrn169 opened a new pull request #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] goiri commented on issue #1889: HDFS-15215 The Timestamp
for longest write/read lock held log is wrong
Posted by GitBox <gi...@apache.org>.
goiri commented on issue #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889#issuecomment-598487732
I'm approving this but I'd like for @xkrogen to take a look if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] brfrn169 commented on issue #1889: HDFS-15215 The
Timestamp for longest write/read lock held log is wrong
Posted by GitBox <gi...@apache.org>.
brfrn169 commented on issue #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889#issuecomment-600962616
Ping @xkrogen
Could you please take a look at it when you get a chance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] brfrn169 edited a comment on issue #1889: HDFS-15215 The
Timestamp for longest write/read lock held log is wrong
Posted by GitBox <gi...@apache.org>.
brfrn169 edited a comment on issue #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889#issuecomment-602956686
@xkrogen Thank you for reviewing this.
@xkrogen @goiri Could you please merge this if you are okay? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] goiri merged pull request #1889: HDFS-15215 The Timestamp
for longest write/read lock held log is wrong
Posted by GitBox <gi...@apache.org>.
goiri merged pull request #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] brfrn169 commented on a change in pull request #1889:
HDFS-15215 The Timestamp for longest write/read lock held log is wrong
Posted by GitBox <gi...@apache.org>.
brfrn169 commented on a change in pull request #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889#discussion_r391371213
##########
File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/FakeTimer.java
##########
@@ -29,17 +29,19 @@
@InterfaceAudience.Private
@InterfaceStability.Unstable
public class FakeTimer extends Timer {
+ private long now;
private long nowNanos;
/** Constructs a FakeTimer with a non-zero value */
public FakeTimer() {
// Initialize with a non-trivial value.
+ now = 1577836800000L; // 2020-01-01 00:00:00,000+0000
Review comment:
Thank you for the comment.
Actually, I think it's more real behavior than original one, because `Timer.now()` returns the time based on `System.currentTimeMillis()`, and `Timer.monotonicNow()` and `Timer.monotonicNowNanos()` return the time based on `System.nanoTime()`, which are different times.
This change is useful to verify the fix in this PR. Also, it doesn't break the existing tests.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] brfrn169 commented on issue #1889: HDFS-15215 The
Timestamp for longest write/read lock held log is wrong
Posted by GitBox <gi...@apache.org>.
brfrn169 commented on issue #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889#issuecomment-602956686
@xkrogen Thank you for reviewing this.
@xkrogen @goiri Could you please commit merge this if you are okay? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1889: HDFS-15215 The
Timestamp for longest write/read lock held log is wrong
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889#issuecomment-597161178
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 22s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 22m 57s | trunk passed |
| +1 :green_heart: | compile | 1m 9s | trunk passed |
| +1 :green_heart: | checkstyle | 0m 45s | trunk passed |
| +1 :green_heart: | mvnsite | 1m 18s | trunk passed |
| +1 :green_heart: | shadedclient | 17m 35s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 42s | trunk passed |
| +0 :ok: | spotbugs | 3m 4s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 2s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 8s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| -0 :warning: | checkstyle | 0m 39s | hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1) |
| +1 :green_heart: | mvnsite | 1m 8s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 15m 21s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | the patch passed |
| +1 :green_heart: | findbugs | 3m 7s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 115m 58s | hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 36s | The patch does not generate ASF License warnings. |
| | | 189m 38s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdfs.TestBlocksScheduledCounter |
| | hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy |
| | hadoop.hdfs.server.datanode.TestDirectoryScanner |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1889/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1889 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 1d6cfe5b2b56 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 44afe11 |
| Default Java | 1.8.0_242 |
| checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1889/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1889/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1889/1/testReport/ |
| Max. process+thread count | 3092 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1889/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1889: HDFS-15215 The
Timestamp for longest write/read lock held log is wrong
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889#issuecomment-597481223
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 24m 52s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 1m 20s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 19m 34s | trunk passed |
| +1 :green_heart: | compile | 17m 3s | trunk passed |
| +1 :green_heart: | checkstyle | 2m 42s | trunk passed |
| +1 :green_heart: | mvnsite | 2m 54s | trunk passed |
| +1 :green_heart: | shadedclient | 21m 4s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 56s | trunk passed |
| +0 :ok: | spotbugs | 3m 23s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 5m 31s | trunk passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 7s | the patch passed |
| +1 :green_heart: | compile | 16m 24s | the patch passed |
| +1 :green_heart: | javac | 16m 24s | the patch passed |
| -0 :warning: | checkstyle | 2m 39s | root: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3) |
| +1 :green_heart: | mvnsite | 2m 54s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 14m 4s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 2m 0s | the patch passed |
| +1 :green_heart: | findbugs | 5m 23s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 9m 9s | hadoop-common in the patch passed. |
| -1 :x: | unit | 93m 44s | hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 1m 6s | The patch does not generate ASF License warnings. |
| | | 246m 35s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdfs.server.namenode.ha.TestAddBlockTailing |
| | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1889/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1889 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux efb7d44196fd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / cf9cf83 |
| Default Java | 1.8.0_242 |
| checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1889/2/artifact/out/diff-checkstyle-root.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1889/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1889/2/testReport/ |
| Max. process+thread count | 4442 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1889/2/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] brfrn169 commented on issue #1889: HDFS-15215 The
Timestamp for longest write/read lock held log is wrong
Posted by GitBox <gi...@apache.org>.
brfrn169 commented on issue #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889#issuecomment-602411115
It looks like @xkrogen is busy and he can't respond to this.
How can we proceed with this? @goiri
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] brfrn169 edited a comment on issue #1889: HDFS-15215 The
Timestamp for longest write/read lock held log is wrong
Posted by GitBox <gi...@apache.org>.
brfrn169 edited a comment on issue #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889#issuecomment-598495978
@goiri Thank you for approving this!
@xkrogen Could you please take a look at it when you get a chance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] brfrn169 commented on issue #1889: HDFS-15215 The
Timestamp for longest write/read lock held log is wrong
Posted by GitBox <gi...@apache.org>.
brfrn169 commented on issue #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889#issuecomment-598495978
@goiri Thank you for approving this!
@xkrogen Could you please take a look it when you get a chance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1889: HDFS-15215 The
Timestamp for longest write/read lock held log is wrong
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889#issuecomment-597622324
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 4s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 23m 55s | trunk passed |
| +1 :green_heart: | compile | 17m 56s | trunk passed |
| +1 :green_heart: | checkstyle | 2m 45s | trunk passed |
| +1 :green_heart: | mvnsite | 2m 44s | trunk passed |
| +1 :green_heart: | shadedclient | 22m 21s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 43s | trunk passed |
| +0 :ok: | spotbugs | 3m 7s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 5m 11s | trunk passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 59s | the patch passed |
| +1 :green_heart: | compile | 17m 7s | the patch passed |
| +1 :green_heart: | javac | 17m 7s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 46s | the patch passed |
| +1 :green_heart: | mvnsite | 2m 46s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 16m 7s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 48s | the patch passed |
| +1 :green_heart: | findbugs | 6m 1s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 9m 50s | hadoop-common in the patch passed. |
| -1 :x: | unit | 112m 13s | hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 52s | The patch does not generate ASF License warnings. |
| | | 250m 22s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1889/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1889 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 085133adf7b0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / cf9cf83 |
| Default Java | 1.8.0_242 |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1889/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1889/3/testReport/ |
| Max. process+thread count | 3238 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1889/3/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] xkrogen commented on issue #1889: HDFS-15215 The Timestamp
for longest write/read lock held log is wrong
Posted by GitBox <gi...@apache.org>.
xkrogen commented on issue #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889#issuecomment-602791236
Hey folks, apologies for the late response. I'm just getting back from vacation.
The change looks good to me. Good catch @brfrn169 . I agree with your `FakeTimer` change, it seems that separating the `now()` and `monotonicNow()` will help catch such issues in the future. I've made this same mistake in another place and didn't catch it because the `FakeTimer` treats them the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] goiri commented on a change in pull request #1889:
HDFS-15215 The Timestamp for longest write/read lock held log is wrong
Posted by GitBox <gi...@apache.org>.
goiri commented on a change in pull request #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889#discussion_r391119110
##########
File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/FakeTimer.java
##########
@@ -29,17 +29,19 @@
@InterfaceAudience.Private
@InterfaceStability.Unstable
public class FakeTimer extends Timer {
+ private long now;
private long nowNanos;
/** Constructs a FakeTimer with a non-zero value */
public FakeTimer() {
// Initialize with a non-trivial value.
+ now = 1577836800000L; // 2020-01-01 00:00:00,000+0000
Review comment:
Can we leave the old behavior as it was and add a method to change the nowNanos so we only set it there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org