You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Max Bernhardt - extern TAGP - Tel. 3749" <Ma...@vodafone.com> on 2004/12/09 11:11:27 UTC
[PATCH] Add Commandline Option '--no-diffs-added' to svnlook
Added a new Commandline Option to svnlook that allows users
to suppress the full listing of added files.
--no-diffs-added behaves just like --no-diffs-deleted
Re: [PATCH] Add Commandline Option '--no-diffs-added' to svnlook
Posted by "Max Bernhardt - extern TAGP - Tel. 3749" <Ma...@vodafone.com>.
Ben Collins-Sussman wrote:
>
> On Dec 10, 2004, at 2:13 AM, Max Bernhardt - extern TAGP - Tel. 3749
> wrote:
>
>>
>> I think this feature makes sense regarding oost commit emails. It's
>> just a little annoying to get
>> a mail that is a couple of hundred kB or even a few MB everytime
>> somebody checks in a new file.
>>
>
> IIRC, mailer.py can be configured to not show the contents of newly
> added files. I know I've seen it behave that way already. Maybe
> commit-email.pl should grow that same ability...?
>
That's what the patch does ... :-)
But since commit-email.pl uses svnlook I thought it made more sense
to add the filter to svnlook than to add a filter to commit-email.pl.
Max
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Add Commandline Option '--no-diffs-added' to svnlook
Posted by Ben Collins-Sussman <su...@collab.net>.
On Dec 10, 2004, at 2:13 AM, Max Bernhardt - extern TAGP - Tel. 3749
wrote:
>
> I think this feature makes sense regarding oost commit emails. It's
> just a little annoying to get
> a mail that is a couple of hundred kB or even a few MB everytime
> somebody checks in a new file.
>
IIRC, mailer.py can be configured to not show the contents of newly
added files. I know I've seen it behave that way already. Maybe
commit-email.pl should grow that same ability...?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Add Commandline Option '--no-diffs-added' to svnlook
Posted by Michael W Thelen <mi...@pietdepsi.com>.
Max Bernhardt - extern TAGP - Tel. 3749 wrote:
>>> Added a new Commandline Option to svnlook that allows users
>>> to suppress the full listing of added files.
>>> --no-diffs-added behaves just like --no-diffs-deleted
>>
>> Could you write a full log message? See the HACKING file or run svn
>> log on the repository.
>>
> Find the attached file PATCH_LOG
Thanks for the patch. I've filed it as issue #2180:
http://subversion.tigris.org/issues/show_bug.cgi?id=2180
--
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes. -- Douglas Adams
Re: [PATCH] Add Commandline Option '--no-diffs-added' to svnlook
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Fri, 10 Dec 2004, Max Bernhardt - extern TAGP - Tel. 3749 wrote:
> a little annoying to get
> a mail that is a couple of hundred kB or even a few MB everytime
> somebody checks in a new file.
>
+0 for the new option.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Add Commandline Option '--no-diffs-added' to svnlook
Posted by "Max Bernhardt - extern TAGP - Tel. 3749" <Ma...@vodafone.com>.
Hi Philip,
thanks a lot for the pointers.
>"Max Bernhardt - extern TAGP - Tel. 3749" <Ma...@vodafone.com> writes:
>
>
>
>>Added a new Commandline Option to svnlook that allows users
>>to suppress the full listing of added files.
>>--no-diffs-added behaves just like --no-diffs-deleted
>>
>>
>
>Could you write a full log message? See the HACKING file or run svn
>log on the repository.
>
>
>
Find the attached file PATCH_LOG
>>Index: main.c
>>===================================================================
>>--- main.c (revision 12259)
>>+++ main.c (working copy)
>>
>>
>
>Patches from the trunk directory are better, we have more than one
>main.c file.
>
>
I changed the diff: find the attached file PATCH_SVN_LOOK_MAIN.
> <>
> Have you looked at the regression tests? Could you write a basic
> "this feature works" test? Take a look at the existing tests in
> subversion/tests/clients/cmdline/svnlook_tests.py
I'd love to, but that will have to wait because I really don't know
enough about python yet ... ;-)
I will try to get to it as soon as have a better understanding about
python and the testframework
subversion uses. Then i would probably add a test for --no-diffs-deleted
as well ...
> <>The patch changes looks OK, is there support for adding this feature?
> (Obviously Max wants it :)
I think this feature makes sense regarding oost commit emails. It's just
a little annoying to get
a mail that is a couple of hundred kB or even a few MB everytime
somebody checks in a new file.
Hence i add another patch for commit-email.pl.in (PATCH_COMMIT_EMAIL).
CU
Max
Re: [PATCH] Add Commandline Option '--no-diffs-added' to svnlook
Posted by Philip Martin <ph...@codematters.co.uk>.
"Max Bernhardt - extern TAGP - Tel. 3749" <Ma...@vodafone.com> writes:
> Added a new Commandline Option to svnlook that allows users
> to suppress the full listing of added files.
> --no-diffs-added behaves just like --no-diffs-deleted
Could you write a full log message? See the HACKING file or run svn
log on the repository.
>
> Index: main.c
> ===================================================================
> --- main.c (revision 12259)
> +++ main.c (working copy)
Patches from the trunk directory are better, we have more than one
main.c file.
Have you looked at the regression tests? Could you write a basic
"this feature works" test? Take a look at the existing tests in
subversion/tests/clients/cmdline/svnlook_tests.py
The patch changes looks OK, is there support for adding this feature?
(Obviously Max wants it :)
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org